commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Sanders" <ssand...@nextance.com>
Subject RE: cvs commit: jakarta-commons-sandbox/fileupload/src/java/org/apache/commons/fileuploadDefaultFileItem.javaFileItem.javaFileUpload.java FileUploadException.javaMultipartStream.java
Date Mon, 19 Aug 2002 18:20:52 GMT
So you are not stopping me, just recommending that I do not?

If so, then why do we publish standards?

Scott

> -----Original Message-----
> From: Nicola Ken Barozzi [mailto:nicolaken@apache.org] 
> Sent: Monday, August 19, 2002 11:16 AM
> To: Jakarta Commons Developers List
> Subject: Re: cvs commit: 
> jakarta-commons-sandbox/fileupload/src/java/org/apache/commons
> /fileuploadDefaultFileItem.javaFileItem.javaFileUpload.java 
> FileUploadException.javaMultipartStream.java
> 
> 
> 
> 
> Scott Sanders wrote:
> > Agreed from the separation perspective, but the notion that I 
> > shouldn't commit style changes to conform to a standard because of 
> > stats is ludicrous.
> > 
> > So, if I use IntelliJ to reformat to the currently accepted 
> standard, 
> > ie the jakarta standard since Commons has not created one of their 
> > own, why should I not commit that?
> 
> I never said that.
> I don't care if you do.
> 
> But I wouldn't encourage you to do it, that's all.
> 
> 
> >>-----Original Message-----
> >>From: Steve Downey [mailto:steve.downey@netfolio.com]
> >>Sent: Monday, August 19, 2002 11:09 AM
> >>To: Jakarta Commons Developers List
> >>Subject: Re: cvs commit: 
> >>jakarta-commons-sandbox/fileupload/src/java/org/apache/commons
> >>/fileuploadDefaultFileItem.javaFileItem.java FileUpload.java 
> >>FileUploadException.javaMultipartStream.java
> >>
> >>
> >>Code reformat commits should be separate from any other commits.
> >>Otherwise, you end up sifting through a lot of meaningless 
> >>diffs to find 
> >>out what really changed.
> >>
> >>Scott Sanders wrote:
> >>
> >>
> >>>So, if I am using something as wonderful as Intellij, and I
> >>
> >>happen to
> >>
> >>>format the code to the current standard, I cannot/should not
> >>
> >>commit it?
> >>
> >>>I would tend to disagree with this.  I think there does need
> >>
> >>to be some
> >>
> >>>common standard, although I do not care what it is.  I am
> >>
> >>much faster
> >>
> >>>at understanding code if it looks the same as the code that I just
> >>>looked at.
> >>>
> >>>Scott
> >>>
> >>>
> >>>>-----Original Message-----
> >>>>From: Nicola Ken Barozzi [mailto:nicolaken@apache.org]
> >>>>Sent: Monday, August 19, 2002 10:49 AM
> >>>>To: Jakarta Commons Developers List
> >>>>Subject: Re: cvs commit:
> >>>>jakarta-commons-sandbox/fileupload/src/java/org/apache/commons
> >>>>/fileuploadDefaultFileItem.java FileItem.java FileUpload.java 
> >>>>FileUploadException.javaMultipartStream.java
> >>>>
> >>>>
> >>>>I find reformatting of code a useless task.
> >>>>Each of us has his own style, and has to learn to work with
> >>>
> >>different
> >>
> >>>>styles.
> >>>>If the code was so horrible that it's not understandable, I
> >>>>really think 
> >>>>that no reformatting can make it better.
> >>>>
> >>>>If someone needs to reformat the code to understand it 
> better, then 
> >>>>there are various automatic formatters available. If 
> someone likes 
> >>>>to spend his time reformatting his code by hand, it's
> >>>>*his* problem, not mine.
> >>>>
> >>>>But please, leave alone the code that's already there, so
> >>>
> >>that we can
> >>
> >>>>have meaningful CVS diffs and automatic code diff metrics.
> >>>>
> >>>>
> >>>>Scott Sanders wrote:
> >>>>
> >>>>
> >>>>>I would tend to agree with this.  Commons does not use 
> the Turbine 
> >>>>>convention.  I don't think code in Commons should be style
> >>>>>
> >>>>
> >>>>as to where
> >>>>
> >>>>
> >>>>>it came from.
> >>>>>
> >>>>>Scott
> >>>>>
> >>>>>
> >>>>>
> >>>>>>-----Original Message-----
> >>>>>>From: Lavandowska [mailto:flanandowska@yahoo.com]
> >>>>>>Sent: Sunday, August 18, 2002 1:22 PM
> >>>>>>To: Jakarta Commons Developers List
> >>>>>>Subject: Re: cvs commit: 
> >>>>>>jakarta-commons-sandbox/fileupload/src/java/org/apache/commons
> >>>>>>/fileupload DefaultFileItem.java FileItem.java
> >>>>>>FileUpload.java FileUploadException.java MultipartStream.java
> >>>>>>
> >>>>>>
> >>>>>>Since it is no longer a part of Turbine, doesn't it make
> >>>>>
> >>more sense
> >>
> >>>>>>for it to change to the Sun conventions?  That is the common
> >>>>>>denominator in commons, isn't it?
> >>>>>>
> >>>>>>--- Jason van Zyl <jason@zenplex.com> wrote:
> >>>>>>
> >>>>>
> >>>>...
> >>>>
> >>>>
> >>>>>>>It used the one's that Turbine has used forever.  
> Would you mind 
> >>>>>>>putting the code back to its original style? The Maven
> >>>>>>
> >>checkstyle
> >>
> >>>>>>>plugin supports the Turbine mode and I believe this is
> >>>>>>
> >>fair to ask
> >>
> >>>>>>>given that
> >>>>>>>the code originally came from the Turbine code base.
> >>>>>>>
> >>>>>>
> >>>>-- 
> >>>>Nicola Ken Barozzi                   nicolaken@apache.org
> >>>>            - verba volant, scripta manent -
> >>>>   (discussions get forgotten, just code remains)
> >>>>------------------------------------------------------------
> >>>
> >>---------
> >>
> >>>>
> >>>>--
> >>>>To unsubscribe, e-mail:   
> >>>><mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> >>>>For
> >>>>additional commands,
> >>>>e-mail: <mailto:commons-dev-help@jakarta.apache.org>
> >>>>
> >>>>
> >>>--
> >>>To unsubscribe, e-mail:   
> >>
> >><mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> >>
> >>>For
> >>
> >>additional commands,
> >>e-mail: 
> >>
> >>><mailto:commons-dev-help@jakarta.apache.org>
> >>>
> >>>
> >>
> >>
> >>
> >>--
> >>To unsubscribe, e-mail:   
> >><mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> >>For
> >>additional commands, 
> >>e-mail: <mailto:commons-dev-help@jakarta.apache.org>
> >>
> >>
> > 
> > --
> > To unsubscribe, e-mail:   
> <mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> > For 
> additional commands, 
> e-mail: 
> > <mailto:commons-dev-help@jakarta.apache.org>
> > 
> > 
> > 
> 
> 
> -- 
> Nicola Ken Barozzi                   nicolaken@apache.org
>              - verba volant, scripta manent -
>     (discussions get forgotten, just code remains)
> ---------------------------------------------------------------------
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> For 
> additional commands, 
> e-mail: <mailto:commons-dev-help@jakarta.apache.org>
> 
> 

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message