commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Sanders" <ssand...@nextance.com>
Subject RE: cvs commit: jakarta-commons-sandbox/fileupload/src/java/org/apache/commons/fileupload DefaultFileItem.java FileItem.java FileUpload.java FileUploadException.java MultipartStream.java
Date Mon, 19 Aug 2002 16:33:38 GMT
I would tend to agree with this.  Commons does not use the Turbine
convention.  I don't think code in Commons should be style as to where
it came from.

Scott

> -----Original Message-----
> From: Lavandowska [mailto:flanandowska@yahoo.com] 
> Sent: Sunday, August 18, 2002 1:22 PM
> To: Jakarta Commons Developers List
> Subject: Re: cvs commit: 
> jakarta-commons-sandbox/fileupload/src/java/org/apache/commons
> /fileupload DefaultFileItem.java FileItem.java 
> FileUpload.java FileUploadException.java MultipartStream.java
> 
> 
> Since it is no longer a part of Turbine, doesn't it make more 
> sense for it to change to the Sun conventions?  That is the 
> common denominator in commons, isn't it?
> 
> --- Jason van Zyl <jason@zenplex.com> wrote:
> > On Sun, 2002-08-18 at 02:09, martinc@apache.org wrote:
> > > martinc     2002/08/17 23:09:21
> > > 
> > >   Modified:    fileupload/src/java/org/apache/commons/fileupload
> > >                         DefaultFileItem.java FileItem.java
> > FileUpload.java
> > >                         FileUploadException.java
> > MultipartStream.java
> > >   Log:
> > >   Stylistic changes only, to adhere to coding conventions and keep
> > >   checkstyle happy.
> > 
> > This code came from Turbine and didn't use the Sun coding 
> conventions.
> > It used the one's that Turbine has used forever.  Would you mind
> > putting
> > the code back to its original style? The Maven checkstyle plugin
> > supports the Turbine mode and I believe this is fair to ask given
> > that
> > the code originally came from the Turbine code base.
> > 
> > --
> > jvz.
> 
> 
> __________________________________________________
> Do You Yahoo!?
> HotJobs - Search Thousands of New Jobs
> http://www.hotjobs.com
> 
> --
> To unsubscribe, e-mail:   
> <mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> For 
> additional commands, 
> e-mail: <mailto:commons-dev-help@jakarta.apache.org>
> 
> 

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message