Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 42882 invoked from network); 17 Jul 2002 17:34:19 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 17 Jul 2002 17:34:19 -0000 Received: (qmail 1877 invoked by uid 97); 17 Jul 2002 17:34:34 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 1861 invoked by uid 97); 17 Jul 2002 17:34:34 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 1849 invoked by uid 98); 17 Jul 2002 17:34:33 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Date: Wed, 17 Jul 2002 18:34:49 +0100 Subject: [digester] CallMethodRule bug Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v482) From: robert burrell donkin To: "Jakarta Commons Developers List" Content-Transfer-Encoding: 7bit In-Reply-To: <20020717101800.W48584-100000@icarus.apache.org> Message-Id: <7E78E934-99AB-11D6-B493-003065DC754C@mac.com> X-Mailer: Apple Mail (2.482) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N at the moment: 1. the java doc comments have always said that methods with primitive arg could be called by passing in corresponding java.lang classes (eg. Boolean) . 2. this doesn't work! 3. CallMethodRule uses invokeExactMethod (rather than invokeMethod) invokeExactMethod uses class.getMethod. in order to support matching primitives with java.lang classes, this would need to work more like invokeMethod. i'd prefer to change invokeMethod so that it supports this kind of matching and change CallMethodRule to use invokeMethod by default and invokeExactMethod with a flag. this may subtly break some digestion rulesets (since invokeMethod may under some rare circumstances return a different match from invokeExactMethod) which will have to be fixed by setting flags on some CallMethodRules. we didn't have any complaints from users when we made this change for other rules so i'm pretty confident that the incompatibility doesn't occur often in the wild. is this a good plan? comments? - robert -- To unsubscribe, e-mail: For additional commands, e-mail: