Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 11313 invoked from network); 2 Jul 2002 00:06:35 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by 209.66.108.5 with SMTP; 2 Jul 2002 00:06:35 -0000 Received: (qmail 17017 invoked by uid 97); 2 Jul 2002 00:06:49 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 17001 invoked by uid 97); 2 Jul 2002 00:06:49 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 16988 invoked by uid 98); 2 Jul 2002 00:06:48 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <00b501c2215c$db1fd700$5c3929d9@oemcomputer> From: "Stephen Colebourne" To: "Jakarta Commons Developers List" References: <001901c2215a$ecf46c90$6501a8c0@LT1> Subject: Re: [lang] [patch] Numbers.containsDigits(String) Date: Tue, 2 Jul 2002 01:10:21 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: 209.66.108.5 1.6.2 0/1000/N X-Spam-Rating: 209.66.108.5 1.6.2 0/1000/N From: "Rand McNeely" > I'll be happy to write the unit test. ;-) > rename containsDigits to isOnlyDigits ("a9ez" contains digits) I agree, we need to confer on this however > and as noted there may be some performance issues in the > isNumber(String) method. Probably not worth worrying about > Also, is there a reason we don't have a maximum(int,int,int) for > completeness (as far as that goes, what about longs, etc - perhaps the > method should be changed to use longs instead of ints)? I added maximum as I checked in your patch. > Other methods that might be nice but can wait until a 1.0 release are > operators for the primitive wrappers (add(Integer a,Integer b), etc). +1, but less important than the tests Stephen > > -----Original Message----- > > From: Stephen Colebourne [mailto:scolebourne@btopenworld.com] > > Sent: Monday, July 01, 2002 6:46 PM > > To: Jakarta Commons Developers List > > Subject: Re: [lang] [patch] Numbers.containsDigits(String) > > > > Patch applied, thanks. > > > > Are there any more changes you want to make to Numbers? (If you'd like > to > > help a Numbers unit test would be useful!) > > > > Stephen > > > > ----- Original Message ----- > > From: "Rand McNeely" > > To: "'Jakarta Commons Developers List'" > > > Sent: Tuesday, July 02, 2002 12:06 AM > > Subject: [lang] [patch] Numbers.containsDigits(String) > > > > > > > > > > > > > > -----Original Message----- > > > > From: Stephen Colebourne [mailto:scolebourne@btopenworld.com] > > > > Sent: Monday, July 01, 2002 6:02 PM > > > > To: Jakarta Commons Developers List > > > > Subject: Re: [lang] is there a release on the visible horizon? > > > > > > > > +1, please submit a patch > > > > > > > > Stephen > > > > > > > > ----- Original Message ----- > > > > From: "Rand McNeely" > > > > To: "'Jakarta Commons Developers List'" > > > > > > > Sent: Monday, July 01, 2002 10:41 PM > > > > Subject: RE: [lang] is there a release on the visible horizon? > > > > > > > > > > > > > > > > > > > > > > > > > > > 6) Numbers has a lot of comments about future things. Plus > > > > > > containsDigits() > > > > > > > > has question marks against the null handling > > > > > > > > > > > > > > Question marks meaning, should containsDigit consider null > to > > > > > contain > > > > > > > digits or not, or should it not even check. > > > > > > Or should it throw an exception (and which one) > > > > > > > > > > > > > > > > I think the current implementation for nulls is fine but there > is > > > one > > > > > other problem, the method will return true if passed "". I can > go > > > ahead > > > > > and take care of this. > > > > > > > > > > Rand > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > To unsubscribe, e-mail: > > > > > > > > > For additional commands, e-mail: > > > > > > > > > > > > > > > > > > > > > -- > > > > To unsubscribe, e-mail: > > > unsubscribe@jakarta.apache.org> > > > > For additional commands, e-mail: > > > help@jakarta.apache.org> > > > > > > > > > > ------------------------------------------------------------------------ > -- > > -- > > ---- > > > > > > > -- > > > To unsubscribe, e-mail: > > > > > For additional commands, e-mail: > > > > > > > > -- > > To unsubscribe, e-mail: > unsubscribe@jakarta.apache.org> > > For additional commands, e-mail: > help@jakarta.apache.org> > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- To unsubscribe, e-mail: For additional commands, e-mail: