commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertdon...@mac.com>
Subject Re: cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt XMLIntrospector.java
Date Mon, 01 Jul 2002 20:32:26 GMT
thanks jon.

(i had to think about it but as usual) you're right!

i'm used to log4j where there's little or no overhead associated with 
logging an object to a disabled category. betwixt uses commons-logging 
where this isn't necessarily true.


on a (slightly) wider note, most logging APIs contain guidelines about the 
best way to use the API. commons-logging doesn't really have any 
guidelines for log wrapper implementors or for components logging to 
commons-logging. the only documentation is aimed at component users. there 
really isn't a contract between log wrapper implementors and the 
components logging to them. perhaps there should be.

- robert

On Monday, July 1, 2002, at 08:45 PM, Jon Scott Stevens wrote:

> Missing isTraceEnabled().
>
> -jon
>
> on 7/1/02 11:45 AM, "rdonkin@apache.org" <rdonkin@apache.org> wrote:
>
>> rdonkin     2002/07/01 11:45:20
>>
>> Modified:    betwixt/src/java/org/apache/commons/betwixt
>>                       XMLIntrospector.java
>> Log:
>> Added trace logging messages
>>
>> Revision  Changes    Path
>> 1.3       +6 -1
>> jakarta-
>> commons/betwixt/src/java/org/apache/commons/betwixt/XMLIntrospector.ja
>> va
>>
>> Index: XMLIntrospector.java
>> ===================================================================
>> RCS file:
>> /home/cvs/jakarta-
>> commons/betwixt/src/java/org/apache/commons/betwixt/XMLIntro
>> spector.java,v
>> retrieving revision 1.2
>> retrieving revision 1.3
>> diff -u -r1.2 -r1.3
>> --- XMLIntrospector.java    11 Jun 2002 16:05:20 -0000    1.2
>> +++ XMLIntrospector.java    1 Jul 2002 18:45:20 -0000    1.3
>> @@ -206,7 +206,12 @@
>>              if (xmlInfo != null) {
>>                  cacheXMLBeanInfos.put( aClass, xmlInfo );
>>              }
>> -        }
>> +        } else {
>> +            log.trace("Used cached XMLBeanInfo.");
>> +        }
>> +
>> +        log.trace(xmlInfo);
>> +
>>          return xmlInfo;
>>      }
>
>
> --
> To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.
> org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.
> org>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message