commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Dever" <jdev...@nortelnetworks.com>
Subject RE: [HttpClient] [Patch] Proxies and SSL
Date Thu, 18 Jul 2002 17:12:21 GMT
Odi,

A few comments on your patch:
- Feel free to add your name to the authors list of any file you modify
- In various files you somtimes remove o.a.c.h.log.Log and LogSource.  dIon
went through many file to make  the log imports consistant which will make
it easier to move to commons-logging.  In the mean time we should just leave
these alone. 
- Providing some unit tests is pretty important in a patch that adds new
functionality like this one.
- Its too bad that you have to call toLowerCase on the Authenticator
constants (like WWW_AUTH).  I added a bug for the Header class for this
reason: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10957

Lastly, there is a merge confilct between a previously applied patch (posted
to the mailing list at Tue 7/16/2002 9:04 PM EST, applied at Thu 7/18/2002
1:06 PM EST) and this one.  I don't know if dIon will be able to cope with
the merge or will need a reworked patch.  Its up to him at this point.



-----Original Message-----
From: dion@multitask.com.au [mailto:dion@multitask.com.au]
Sent: Thursday, July 18, 2002 1:02 PM
To: Jakarta Commons Developers List
Subject: RE: [HttpClient] [Patch] Proxies and SSL


"Jeff Dever" <jdever1@nortelnetworks.com> wrote on 07/18/2002 01:32:08 AM:

> Ortwin,
> Thanks for the patch.  Please attch to the bug for tracking purposes.
> 
> dIon, 
> You were dealing with the previous proxy patches so it'd be best if you
> could consider applying this patch.  I know that you like to keep the
> HttpClient/HttpMultiClient functionality consistant.  My feeling we 
should
> go ahead with the patch with the knowledge that mixing those two 
interfaces
> is a top priority to tackle ASAP.

Yep....unfortunately for me for the next two weeks, I'm out of the office, 
not connected to a network. I'll try to get to it in my home time.

> -----Original Message-----
> From: Ortwin Glück [mailto:ortwin.glueck@nose.ch]
> Sent: Wednesday, July 17, 2002 11:11 AM
> To: commons-dev@jakarta.apache.org
> Cc: Andreas Weder
> Subject: [HttpClient] [Patch] Proxies and SSL
> 
> 
> This patch contains the following changes:
> 
> - Proxy Authentication
> - SSL tunneling through proxies (ConnectMethod)
> - free choice of the SSLSocketFactory
> - setting SO_TIMEOUT from HttpClient
> - POST method accepts InputStream as body
> - POST and PUT do not follow redirects by default
> - GetMethod: doc
> 
> Note that HttpMultiClient was not touched.
> Testing was done with one of our applications that uses HttpClient 
> against an authencticating proxy using SSL (SSLava). Still all the 
> Webapp tests need to be modified so that one can specify if to run them 
> through a proxy or not.
> 
> Evert: This patch contains the patch that I sent you three weeks ago, so 

> this patch will conflict with the one you supplied earlier but was only 
> partly committed.
> 
> I attach a patch file along with a newly added source file. Since I have 

> no commit rights I can not add a file myself. I tried to keep the diff 
> as clean as possible.
> 
> Regards
> 
> Ortwin Glück aka Odi
--
dIon Gillard, Multitask Consulting
Work:      http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers



Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message