commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HeaderElement.java
Date Sun, 14 Jul 2002 04:29:20 GMT
dion        2002/07/13 21:29:20

  Modified:    httpclient/src/java/org/apache/commons/httpclient
                        HeaderElement.java
  Log:
  Comments
  
  Revision  Changes    Path
  1.8       +8 -5      jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HeaderElement.java
  
  Index: HeaderElement.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HeaderElement.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- HeaderElement.java	14 Jul 2002 02:57:48 -0000	1.7
  +++ HeaderElement.java	14 Jul 2002 04:29:19 -0000	1.8
  @@ -249,7 +249,7 @@
        * @param headerValue  the string representation of the header value
        *                     (as received from the web server).
        * @return the header elements containing <code>Header</code> elements.
  -     * @exception HttpException if the above syntax rules are violated.
  +     * @throws HttpException if the above syntax rules are violated.
        */
       public final static HeaderElement[] parse(String headerValue)
               throws HttpException
  @@ -265,6 +265,7 @@
           while (tokenizer.countTokens() > 0) {
               String nextToken = tokenizer.nextToken();
   
  +            // FIXME: refactor into private method named ?
               // careful... there may have been a comma in a quoted string
               try {
                   while (HeaderElement.hasOddNumberOfQuotationMarks(
  @@ -276,6 +277,7 @@
                       "Bad header format: wrong number of quotation marks");
               }
   
  +            // FIXME: Refactor out into a private method named ?
               try {
                   /**
                    * Following to RFC 2109 and 2965, in order not to conflict
  @@ -314,6 +316,7 @@
               }
               char[] header = tmp.toCharArray();
   
  +            // FIXME: refactor into a private method named? parseElement?
               boolean inAString = false;
               int startPos = 0;
               HeaderElement element = new HeaderElement();
  
  
  

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message