commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [lang] patch Numbers/NumbersTest
Date Mon, 08 Jul 2002 22:14:23 GMT
Patch mostly applied, thanks

I did not apply the NullPointerException code. At the moment, the rest of
the Strings class is being coded to return null if passed in null. This
needs to be discussed if Numbers is to be different (and may need guards in
the createFloat etc. methods)

I haven't changed the test, so the test fails at present.

Stephen

----- Original Message -----
From: "Rand McNeely" <rand_mcneely@yahoo.com>
To: "'Jakarta Commons Developers List'" <commons-dev@jakarta.apache.org>
Sent: Saturday, July 06, 2002 5:44 PM
Subject: [lang] patch Numbers/NumbersTest


> Modified Numbers.isNumber to return true iff Numbers.createNumber can
> create a number.
>
> Changed the null handling in createNumber to throw a
> NullPointerException if null was passed.  This is more inline with the
> JDK number parsing routines.  Comments?
>
> One final thing, createNumber only returns hex if the string uses the 0x
> qualifier.  I didn't like the idea of the user thinking things like
> "ABC123" were interpreted as hex and then passing in "123E45" and
> getting a Double.
>
> Rand
>


----------------------------------------------------------------------------
----


> --
> To unsubscribe, e-mail:
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message