commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [lang] PATCH exception Nestable interface, implementation classes, and test cases
Date Wed, 17 Jul 2002 22:26:19 GMT
The exception functionality is mostly fine. My comments are:

The interface change I would make would be to the getLength() method. This
seems too unspecific a name. Maybe something like getThrowableCount()  ??

The functionality change I would make is to the index out of bounds
handling. I would favour throwing an IndexOutOfBoundsException if the class
is used wrongly, rather than absorbing invalid indices silently. This would
bring the class in line with String, which was the intention.

Stephen

----- Original Message -----
From: "Henri Yandell" <bayard@generationjava.com>
To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Sent: Wednesday, July 17, 2002 6:07 AM
Subject: Re: [lang] PATCH exception Nestable interface, implementation
classes, and test cases


> Applied. Am not going to consider the assumptions about specific
> functionality to hinder a promotion to Commons proper, however it might
> hold off a beta release if people think the API is going to change
> mightily, so would be good if those interested got their oar in over the
> next day or two.
>
> Hen
>
> On Tue, 16 Jul 2002, Steven Caswell wrote:
>
> > The attached patch contains the revised Nestable interface,
> > implementation classes,
> > and test cases. The interface has been revised as discussed in recent
> > e-mails. I made
> > A few assumptions about specific functionaltiy, so those with an
> > interest in the interface, please review the javadoc comments.
> >
> > I also refactored the test cases along method boundaries. All test cases
> > run successfully.
> >
> >
> > Steven Caswell
> > steven@caswell.name
> >
> >
> >
>
>
> --
> To unsubscribe, e-mail:
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message