Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 11241 invoked from network); 25 Jun 2002 18:00:19 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 25 Jun 2002 18:00:19 -0000 Received: (qmail 11650 invoked by uid 97); 25 Jun 2002 18:00:27 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 11634 invoked by uid 97); 25 Jun 2002 18:00:26 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 11623 invoked by uid 97); 25 Jun 2002 18:00:26 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Date: 25 Jun 2002 18:00:09 -0000 Message-ID: <20020625180009.52750.qmail@icarus.apache.org> From: jstrachan@apache.org To: jakarta-commons-sandbox-cvs@apache.org Subject: cvs commit: jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/ant DataTypeTag.java AntTagSupport.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N jstrachan 2002/06/25 11:00:09 Modified: jelly/src/java/org/apache/commons/jelly/tags/ant DataTypeTag.java AntTagSupport.java Log: allowed setAttribute() to throw an exception so that DynaTag errors can popup to the TagScript for better error reporting Revision Changes Path 1.9 +1 -1 jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/ant/DataTypeTag.java Index: DataTypeTag.java =================================================================== RCS file: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/ant/DataTypeTag.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- DataTypeTag.java 18 Jun 2002 18:36:43 -0000 1.8 +++ DataTypeTag.java 25 Jun 2002 18:00:09 -0000 1.9 @@ -229,7 +229,7 @@ setDynaBean( new ConvertingWrapDynaBean(dataType) ); } - public void setAttribute(String name, Object value) { + public void setAttribute(String name, Object value) throws Exception { if ( "id".equals( name ) ) { getAntProject().addReference( (String) value, dataType ); return; 1.3 +9 -13 jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/ant/AntTagSupport.java Index: AntTagSupport.java =================================================================== RCS file: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/tags/ant/AntTagSupport.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- AntTagSupport.java 25 Jun 2002 17:13:32 -0000 1.2 +++ AntTagSupport.java 25 Jun 2002 18:00:09 -0000 1.3 @@ -136,7 +136,7 @@ return task; } - public void setAttribute(String name, Object value) { + public void setAttribute(String name, Object value) throws Exception { Object obj = null; @@ -146,7 +146,7 @@ e.printStackTrace(); return; } - + if ( obj == null ) { return; } @@ -167,13 +167,9 @@ } catch (Exception e) { // e.printStackTrace(); - try - { - super.setAttribute( name, value ); - } - catch (Exception f) { - // f.printStackTrace(); - } + // let any exceptions bubble up from here + + super.setAttribute( name, value ); } } -- To unsubscribe, e-mail: For additional commands, e-mail: