Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 22515 invoked from network); 3 Apr 2002 12:42:00 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 3 Apr 2002 12:42:00 -0000 Received: (qmail 7029 invoked by uid 97); 3 Apr 2002 12:41:58 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 7013 invoked by uid 97); 3 Apr 2002 12:41:57 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 7002 invoked by uid 97); 3 Apr 2002 12:41:57 -0000 Date: 3 Apr 2002 12:41:56 -0000 Message-ID: <20020403124156.81654.qmail@icarus.apache.org> From: rwaldhoff@apache.org To: jakarta-commons-cvs@apache.org Subject: cvs commit: jakarta-commons/dbcp/src/test/org/apache/commons/dbcp TestManual.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N rwaldhoff 02/04/03 04:41:56 Modified: dbcp/src/test/org/apache/commons/dbcp TestManual.java Log: better test in testPooling, we don't care what order the pooled Connections are returned Revision Changes Path 1.5 +8 -8 jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestManual.java Index: TestManual.java =================================================================== RCS file: /home/cvs/jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestManual.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- TestManual.java 3 Apr 2002 12:33:02 -0000 1.4 +++ TestManual.java 3 Apr 2002 12:41:56 -0000 1.5 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestManual.java,v 1.4 2002/04/03 12:33:02 rwaldhoff Exp $ - * $Revision: 1.4 $ - * $Date: 2002/04/03 12:33:02 $ + * $Header: /home/cvs/jakarta-commons/dbcp/src/test/org/apache/commons/dbcp/TestManual.java,v 1.5 2002/04/03 12:41:56 rwaldhoff Exp $ + * $Revision: 1.5 $ + * $Date: 2002/04/03 12:41:56 $ * * ==================================================================== * @@ -68,7 +68,7 @@ /** * @author Rodney Waldhoff - * @version $Id: TestManual.java,v 1.4 2002/04/03 12:33:02 rwaldhoff Exp $ + * @version $Id: TestManual.java,v 1.5 2002/04/03 12:41:56 rwaldhoff Exp $ */ public class TestManual extends TestCase { public TestManual(String testName) { @@ -150,8 +150,8 @@ conn.createStatement(); fail("Can't use closed connections"); } catch(SQLException e) { - ; // expected - } + ;testSimpleve // expected + }testSimpleve conn = DriverManager.getConnection("jdbc:apache:commons:dbcp:test"); assertTrue(null != conn); @@ -185,7 +185,7 @@ assertTrue(conn != conn2); conn2.close(); conn.close(); - conn2 = DriverManager.getConnection("jdbc:apache:commons:dbcp:test"); - assertSame(conn,conn2); + Connection conn3 = DriverManager.getConnection("jdbc:apache:commons:dbcp:test"); + assertTrue( conn3 == conn || conn3 == conn2 ); } } -- To unsubscribe, e-mail: For additional commands, e-mail: