Return-Path: 
 <commons-dev-return-5713-qmlist-jakarta-archive-commons-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-commons-dev-archive@apache.org
Received: (qmail 29819 invoked from network); 23 Mar 2002 05:39:06 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 23 Mar 2002 05:39:06 -0000
Received: (qmail 11215 invoked by uid 97); 23 Mar 2002 05:39:14 -0000
Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org
Received: (qmail 11199 invoked by uid 97); 23 Mar 2002 05:39:14 -0000
Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:commons-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:commons-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:commons-dev-help@jakarta.apache.org>
List-Post: <mailto:commons-dev@jakarta.apache.org>
List-Id: "Jakarta Commons Developers List" <commons-dev.jakarta.apache.org>
Reply-To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
Delivered-To: mailing list commons-dev@jakarta.apache.org
Received: (qmail 11185 invoked from network); 23 Mar 2002 05:39:13 -0000
Date: Sat, 23 Mar 2002 16:46:28 +1100
From: Jeff Turner <jeff@socialchange.net.au>
To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
Subject: Re: [PATCH] beanutils build system
Message-ID: <20020323054628.GA17689@snow.socialchange.net.au>
References: <B8C0FF62.2365B%jon@latchkey.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B8C0FF62.2365B%jon@latchkey.com>
User-Agent: Mutt/1.3.27i
Sender: Jeff Turner <jeff@snow.socialchange.net.au>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Hi Jon,

Would you be happy (ie, would it build on your system) if we applied the
patch with the following modifications?

1) Source ${basedir}/build.properties before
${user.home}/build.properties

Many people have a ~/build.properties with default values, which only
needs to be overridden by ./build.properties for unusual cases. Changing
the order breaks these people's setups. So I'm proposing that the order
be:

<property file="${basedir}/build.properties" />
<property file="${user.home}/beanutils.build.properties" />
<property file="${user.home}/build.properties" />
<property file="${basedir}/default.properties" />


2) Not delete build.properties.sample. Ie, defaults.properties will
default the values to ${lib.repo}/.., but people without a jar
repository can still 'cp build.properties.sample build.properties' and
have things working.


I quite like the defaults.properties idea. Keeps build.xml clean, and
you don't lose your place in build.xml when looking up the value of a
property.

If we're all happy with this, the change should be done to all projects,
not just beanutils (yes I volunteer).


--Jeff


On Fri, Mar 22, 2002 at 03:33:54PM -0800, Jon Scott Stevens wrote:
> Included is a patch for the beanutils build system so that it will build out
> of the box without having to mv build.properties.sample to build.properties.
> It removes the build.properties.sample file and adds it as
> default.properties.
> 
> It basically implements a build system similar to Lucene, Scarab, Turbine,
> etc...please apply it.
>
...
> -jon
> 

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>