commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Turner <j...@socialchange.net.au>
Subject Re: [PATCH] beanutils build system
Date Sat, 23 Mar 2002 05:46:28 GMT
Hi Jon,

Would you be happy (ie, would it build on your system) if we applied the
patch with the following modifications?

1) Source ${basedir}/build.properties before
${user.home}/build.properties

Many people have a ~/build.properties with default values, which only
needs to be overridden by ./build.properties for unusual cases. Changing
the order breaks these people's setups. So I'm proposing that the order
be:

<property file="${basedir}/build.properties" />
<property file="${user.home}/beanutils.build.properties" />
<property file="${user.home}/build.properties" />
<property file="${basedir}/default.properties" />


2) Not delete build.properties.sample. Ie, defaults.properties will
default the values to ${lib.repo}/.., but people without a jar
repository can still 'cp build.properties.sample build.properties' and
have things working.


I quite like the defaults.properties idea. Keeps build.xml clean, and
you don't lose your place in build.xml when looking up the value of a
property.

If we're all happy with this, the change should be done to all projects,
not just beanutils (yes I volunteer).


--Jeff


On Fri, Mar 22, 2002 at 03:33:54PM -0800, Jon Scott Stevens wrote:
> Included is a patch for the beanutils build system so that it will build out
> of the box without having to mv build.properties.sample to build.properties.
> It removes the build.properties.sample file and adds it as
> default.properties.
> 
> It basically implements a build system similar to Lucene, Scarab, Turbine,
> etc...please apply it.
>
...
> -jon
> 

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message