Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 73803 invoked from network); 19 Feb 2002 01:42:33 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 19 Feb 2002 01:42:33 -0000 Received: (qmail 5860 invoked by uid 97); 19 Feb 2002 01:42:39 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 5826 invoked by uid 97); 19 Feb 2002 01:42:39 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 5815 invoked from network); 19 Feb 2002 01:42:38 -0000 Message-ID: From: Marc Saegesser To: Jakarta Commons Developers List Subject: RE: [httpclient] revised patches: ResponseInputStream.java, Reque stOutputStream.java Date: Mon, 18 Feb 2002 19:44:50 -0600 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="iso-8859-1" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Oh, come on, there are more important issues to fix in HttpClient than debating this. Look at the program below and tell me what the output is. It behaves just like the current implementation of RequestOutputStream.print(). I for one would be rather surprized if a print method behaved any other way. public class Fubar { public static void main(String args[]) { System.out.println("Printing a null value: " + null); } } Marc Saegesser > -----Original Message----- > From: otisg@ivillage.com [mailto:otisg@ivillage.com] > Sent: Monday, February 18, 2002 5:54 PM > To: commons-dev@jakarta.apache.org > Subject: RE: [httpclient] revised patches: ResponseInputStream.java, > Reque stOutputStream.java > > > On Sun, 17 February 2002, "Waldhoff, Rodney" wrote: > > > > > > AFAIK, the change to print would've broken > > > existing code compatibility. > > > > True, although the current behavior: > > if(s == null) s = "null"; > > is a bit quirky, don't you think? > > Yes, doesn't look pretty, looks hacky to me. > > > I'd be in favor of not allowing null, but just let the > s.length() call throw > > the NullPointerException rather than explictly checking for > null on each and > > every call. When a one arg method throws NPE, it's pretty > easy to figure > > out what's null. > > Isn't this bad coding practice that also affects the code efficiency? > > Otis > > _________________________________________________________________ > iVillage.com: Solutions for Your Life > Check out the most exciting women's community on the Web > http://www.ivillage.com > > -- > To unsubscribe, e-mail: > > For additional commands, e-mail: > > -- To unsubscribe, e-mail: For additional commands, e-mail: