Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 13237 invoked from network); 12 Feb 2002 18:54:33 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 12 Feb 2002 18:54:33 -0000 Received: (qmail 28855 invoked by uid 97); 12 Feb 2002 18:54:34 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 28829 invoked by uid 97); 12 Feb 2002 18:54:34 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 28813 invoked from network); 12 Feb 2002 18:54:33 -0000 Date: 12 Feb 2002 10:54:18 -0800 Message-ID: <20020212185418.19949.cpmta@c006.snv.cp.net> X-Sent: 12 Feb 2002 18:54:18 GMT Content-Type: text/plain Content-Disposition: inline Mime-Version: 1.0 To: commons-dev@jakarta.apache.org From: otisg@ivillage.com X-Mailer: Web Mail 3.9.3.5 X-Sent-From: otisg@ivillage.com Subject: Re: [httpclient] patches for HttpClient.java, HttpConnection.java X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sun, 10 February 2002, dIon Gillard wrote: > > Sean C. Sullivan wrote: > > > > > I updated the code for the HttpClient: > > > > HttpClient.java > > HttpConnection.java > > > >Patch files attached. > > > > I created the patch files using this command: > > > > cvs diff -c Foo.java > Foo.patch > > > >-Sean > > > Hi Sean, > > for the HttpConnection patch, you've used a throw new > NullPointerException. From an API point of view, this makes more sense > (IMHO) as a IllegalArgumentException. What do you think? I agree with that. That is the exception I use in such cases. Otis _________________________________________________________________ iVillage.com: Solutions for Your Life Check out the most exciting women's community on the Web http://www.ivillage.com -- To unsubscribe, e-mail: For additional commands, e-mail: