commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Gaspar" <paulo.gas...@krankikom.de>
Subject RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance
Date Fri, 01 Feb 2002 13:47:14 GMT
I just took a look at the code.

There were a couple of details that are still not clear to me (as
around the "sentinel" use) but it looks much better than what we have
and it is e very complete implementation of the Map interface.

However (playing Jon) there is a code style issue there.

Michael, you sure save on lines of code but is is not so easy to read
that way.


Have fun,
Paulo Gaspar

> -----Original Message-----
> From: James Strachan [mailto:james_strachan@yahoo.co.uk]
> Sent: Friday, February 01, 2002 2:01 PM
> To: Jakarta Commons Developers List
> Subject: Re: [collections][PATCH] SequencedHashMap violates Map
> contract, has poor performance
>
>
> +1
>
> Sounds good to me.
>
> James
> ----- Original Message -----
> From: "Remy Maucherat" <remm@apache.org>
> > > I've submitted this patch twice now (once back in mid-November, once a
> > > week ago), but it still has yet to be committed.
> >
> > If nobody has time to apply or look at Michael's patches, how
> about giving
> > him karma on jakarta-commons ?
> >
> > Remy
> >
> >
> > --
> > To unsubscribe, e-mail:
> <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> <mailto:commons-dev-help@jakarta.apache.org>
>
>
> _________________________________________________________
> Do You Yahoo!?
> Get your free @yahoo.com address at http://mail.yahoo.com
>
>
> --
> To unsubscribe, e-mail:
<mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail:
<mailto:commons-dev-help@jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message