commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dIon Gillard <d...@multitask.com.au>
Subject Re: [httpclient] revised patches: ResponseInputStream.java, RequestOutputStream.java
Date Mon, 18 Feb 2002 06:28:26 GMT
Sean C. Sullivan wrote:

>From: "dIon Gillard" <dion@multitask.com.au>
>
>>these patches failed to apply. Could you recreate them off the latest code?
>>
>
>Revised patches are attached.
>
>-Sean
>
>
>--------
>
>Here is another patch for RequestOutputStream.java
>
>A patch file is attached.
>
> I created the patch file using this command:
>
>                   cvs diff -u Foo.java > Foo.patch
>
>Changes in RequestOutputStream:
>
>    updated the class javadoc with an "@see"
>    fixed erroneous javadoc parameter comments
>    the method "public void print(String)" will no longer accept a null
>parameter
>
> I executed the tests and everything passed.
>
>----
>
>
>Here is another patch for ResponseInputStream.java
> 
> A patch file is attached.
> 
> I created the patch file using this command:
> 
>                    cvs diff -u Foo.java > Foo.patch
> 
> Changes in ResponseInputStream:
>
>     improved javadoc comments
>
>     improved code comments in constructor
>
>     improved implementation of the "close()" method
>
>I executed the tests and everything passed. 
>
Mostly applied, except for null handling in print and the unused 
isUsingChunked method. AFAIK, the change to print would've broken 
existing code compatibility.

-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message