commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ot...@ivillage.com
Subject Re: [httpclient] patches for HttpClient.java, HttpConnection.java
Date Tue, 12 Feb 2002 18:54:18 GMT
On Sun, 10 February 2002, dIon Gillard wrote:

> 
> Sean C. Sullivan wrote:
> 
> > 
> > I updated the code for the HttpClient:
> > 
> >         HttpClient.java   
> >         HttpConnection.java
> >
> >Patch files attached.
> > 
> > I created the patch files using this command:
> >  
> >              cvs diff -c Foo.java > Foo.patch
> >  
> >-Sean
> >
> Hi Sean,
> 
> for the HttpConnection patch, you've used a throw new 
> NullPointerException. From an API point of view, this makes more sense 
> (IMHO) as a IllegalArgumentException. What do you think?

I agree with that.  That is the exception I use in such cases.

Otis

_________________________________________________________________
iVillage.com: Solutions for Your Life 
Check out the most exciting women's community on the Web   
http://www.ivillage.com

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message