commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: [Fwd: Servlet Filters Proposal]
Date Tue, 12 Feb 2002 16:40:26 GMT
On Tue, 12 Feb 2002, Glenn Nielsen wrote:

> Date: Tue, 12 Feb 2002 10:24:52 -0600
> From: Glenn Nielsen <glenn@voyager.apg.more.net>
> Reply-To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
> To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
> Subject: Re: [Fwd: Servlet Filters Proposal]
>
> I didn't put commons in the package name because some
> feel that commons isn't a good fit for servlet filters,
> and this may become a top level project if there is
> enough interest.
>
> I agree that having "servlet.filters" in the package
> name is pretty generic, but it is an apt and easy
> to remember package name.  Especially since the
> package name will need to be configured in the
> web.xml file.
>
> So far suggested package names are:
>
> org.apache.servlet.filters.{filter-name}
> org.apache.commons.filters.{filter-name}
> org.apache.jakarta.commons.servlet.filters.{filter-name}
>

While it's in the sandbox (or in jakarta-commons if it gets promoted), the
base package name really needs to follow the Commons conventions (i.e.
"org.apache.commons.filters" for a package named "Filters").  If this is
ever promoted to a full-fledged Jakarta package like Taglibs, it will need
to be repackaged -- this is what happened to Cactus when it was promoted.

Is there really a need for sub-packages for individual filters?  Nearly
all of the ones proposed so far are single classes, so having them
together would seem reasonable -- this is how commons-collections is set
up, and doesn't seem to cause any grief.  For Filters that require some
supporting classes (or where there is a set of Filters that might be used
together), a subpackage is reasonable.

I don't see a need for "servlet.filters" versus "filters" -- the proposal,
and the Javadocs once we have some code -- make it very clear that these
are filters in the Servlet 2.3 sense of the word (i.e. they all implement
javax.servlet.Filter).

> Any other suggestions?
>
> Regards,
>
> Glenn
>

Craig


> Paulo Gaspar wrote:
>
> > And filters is very generic too!
> >
> > What about
> >   org.apache.jakarta.commons.servlet.filters
> >
> > or something like that?
> >
> > (There must be something better than "servlet".)
> >
> >
> > Have fun,
> > Paulo Gaspar
> >
> >
> >
> >>-----Original Message-----
> >>From: Lavandowska [mailto:flanandowska@yahoo.com]
> >>Sent: Tuesday, February 12, 2002 4:58 PM
> >>To: Jakarta Commons Developers List
> >>Subject: Re: [Fwd: Servlet Filters Proposal]
> >>
> >>
> >>Glenn,
> >>
> >>I've started working on getting my filters ready for submission, but am
> >>not sure which "package" they belong in.  In the PROPOSAL you state
> >>"The proposed package name for servlet filters is
> >>org.apache.servlet.filters...", but if this is in Commons shouldn't it
> >>be org.apache.jakarta.commons.filters ?
> >>
> >>Lance
> >>
> >>--- Glenn Nielsen <glenn@voyager.apg.more.net> wrote:
> >>
> >>>Here is the link:
> >>>
> >>>
> >>>
> >>http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/filters/PROP
> >>
> > OSAL.html
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Send FREE Valentine eCards with Yahoo! Greetings!
> > http://greetings.yahoo.com
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:commons-dev-help@jakarta.apache.org>
> >
> >
> > --
> > To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>
> >
>
>
>
> --
> ----------------------------------------------------------------------
> Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
> MOREnet System Programming               |  * if iz ina coment.      |
> Missouri Research and Education Network  |  */                       |
> ----------------------------------------------------------------------
>
>
> --
> To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message