Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 1378 invoked from network); 11 Jan 2002 01:30:17 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 11 Jan 2002 01:30:17 -0000 Received: (qmail 28749 invoked by uid 97); 11 Jan 2002 01:30:20 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 28739 invoked by uid 97); 11 Jan 2002 01:30:20 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 23866 invoked from network); 11 Jan 2002 01:23:27 -0000 Message-ID: <3C3E3CDD.3040003@pbryan.net> Date: Thu, 10 Jan 2002 17:16:13 -0800 From: "Paul C. Bryan" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5) Gecko/20011023 X-Accept-Language: en MIME-Version: 1.0 To: Jakarta Commons Developers List Subject: Re: HTTPClient - setting default request headers impl Q References: <20020110230032.25406.cpmta@c006.snv.cp.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N otisg@ivillage.com wrote: > Yes, yes, I'm aware of those two, but I was wondering what I should do > when the default header is set. > > I guess I will just add another pair of methods: > > setDefaultRequestHeader(String,String) > addDefaultRequestHeader(String,String) My vote: only *one* method: setDefaultRequestHeader(String name, String value). In this case, if multiple headers are required, chain them together in the value parameter with semicolons. meth.addRequestHeader allows addition of multiple header values when some already exist. With setDefaultRequestHeader, you are assigning the values, presumably for the duration of the use of the method. > However, what should happen when someone calls > setRequestHeader("header", "FOO") or addRequestHeader("header", "BAR") > after already specifying the value for that header using: > setDefaultRequestHeader("header", "BAR"), for instance? My vote: setRequestHeader should override the default value. addRequestHeader should add the value to the existing header value. > Should setRequestHeader override the default one? In my opinion, yes. However, if the method is recycled, then the default value should be reinstated. Paul -- To unsubscribe, e-mail: For additional commands, e-mail: