commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Rall <...@finemaltcoding.com>
Subject [PATCH][LOGGING] Corrected jikes compilation warning
Date Fri, 25 Jan 2002 07:12:18 GMT
This change corrects a compilation warning I got using Jikes by
removing a try/catch block which does absolutely nothing.

dlr@despot:logging$ ant
Adding Ant development JAR /home/dlr/ant/build/lib/ant.jar and JAXP /usr/lib/java/xerces-1.4.3.jar
to CLASSPATH
Buildfile: build.xml

init:
     [echo] -------- Logging Library 1.0-dev --------

prepare:
    [mkdir] Created dir: /usr/src/apache.org/jakarta-commons/logging/target
    [mkdir] Created dir: /usr/src/apache.org/jakarta-commons/logging/target/classes
    [mkdir] Created dir: /usr/src/apache.org/jakarta-commons/logging/target/conf    [mkdir]
Created dir: /usr/src/apache.org/jakarta-commons/logging/target/docs    [mkdir] Created dir:
/usr/src/apache.org/jakarta-commons/logging/target/docs/api
    [mkdir] Created dir: /usr/src/apache.org/jakarta-commons/logging/target/tests

static:
     [copy] Copying 1 file to /usr/src/apache.org/jakarta-commons/logging/target/conf

compile:
     [echo] jdk.1.4.present=${jdk.1.4.present}
    [javac] Compiling 6 source files to /usr/src/apache.org/jakarta-commons/logging/target/classes
    [javac] /usr/src/apache.org/jakarta-commons/logging/src/java/org/apache/commons/logging/SimpleLog.java:167:17:167:27:
Caution: This catch block may be unreachable because there is no exception whose type is assignable
to "java/lang/Throwable" that can be thrown during execution of the body of the try block.
However, this being a base exception class, compilation will proceed.
     [copy] Copying 1 file to /usr/src/apache.org/jakarta-commons/logging/target/classes

BUILD SUCCESSFUL

Total time: 3 seconds


Index: SimpleLog.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons/logging/src/java/org/apache/commons/logging/SimpleLog.java,v
retrieving revision 1.10
diff -u -u -r1.10 SimpleLog.java
--- SimpleLog.java	21 Jan 2002 21:19:38 -0000	1.10
+++ SimpleLog.java	25 Jan 2002 07:10:23 -0000
@@ -163,11 +163,6 @@
             }
         }
         
-        try {
-        } catch(Throwable t) {
-            // ignored
-        }
-        
         showLogName = "true".equalsIgnoreCase(
                 simpleLogProps.getProperty(
                     systemPrefix + "showlogname","true"));

--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message