commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert burrell donkin <robertdon...@mac.com>
Subject Re: More abuse of coding styles...
Date Fri, 04 Jan 2002 17:49:42 GMT
i'd just like to point out that i didn't write that bit of code (but 
neither did i correct it).

personally speaking, i'm not going to risk having patches vetoed because i 
try to correct the original author's coding style.

any committer who has the time and energy to fight is very welcome to 
correct the many deviations from the standards that you'll find in the 
commons (and in the other projects as well, no doubt).
- robert

On Friday, January 4, 2002, at 01:54 AM, Jon Scott Stevens wrote:

> It is amazing to me...with all the discussion about coding styles and
> following them, we still have people committing code that doesn't follow
> what rules we do have...
>
> on 1/3/02 11:00 AM, "rdonkin@apache.org" <rdonkin@apache.org> wrote:
>
> Re: cvs commit: jakarta-
> commons/logging/src/java/org/apache/commons/logging
> SimpleLog.java
>
>> +        if(_showtime) {
>
> <http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html#367>
>
> "Variable names should not start with underscore _ or dollar sign $
> characters, even though both are allowed."
>
> <http://jakarta.apache.org/site/source.html>
>
> "All Java Language source code in the repository must be written in
> conformance to the "Code Conventions for the Java Programming Language as
> published by Sun."
>
> -jon
>
>
> --
> To unsubscribe, e-mail:   <mailto:general-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:general-help@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message