commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: Second patch, somewhat easier, replacing the first one....
Date Tue, 18 Dec 2001 03:37:12 GMT


On Tue, 18 Dec 2001, Mika Goeckel wrote:

> Date: Tue, 18 Dec 2001 00:09:48 +0100
> From: Mika Goeckel <mika.goeckel@gmx.de>
> Reply-To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
> To: Jakarta Commons Developers List <commons-dev@jakarta.apache.org>
> Subject: Re: Second patch, somewhat easier, replacing the first  one....
>
> Rob,
>
> do you think of a callback in the digester to get the information what last
> matched?
> The problem with that is that the digester would need to store the
> information in an instance variable then.
> Ok, digester is not multithread-safe, but my blood always runs cold when I
> think about 'global' variables.
> I'd prefer a clean way of passing the information to the configuration
> method.
>

My blood shivers at things like that as well, but there's already 25 or so
other instance variables ... one more wouldn't matter.  I can't really see
why anyone would need a thread-safe Digester, so I don't see much point in
making it so (or paying the extra synchronization costs).

> Is that what you propose?
>
> Cheers, Mika

Craig


>
>
> ----- Original Message -----
> From: "robert burrell donkin" <robertdonkin@mac.com>
> To: "Jakarta Commons Developers List" <commons-dev@jakarta.apache.org>
> Sent: Monday, December 17, 2001 9:01 PM
> Subject: Re: Second patch, somewhat easier, replacing the first one....
>
>
> >
> > On Thursday, December 13, 2001, at 11:41 PM, Mika Goeckel wrote:
> >
> > > Rob,
> > >
> > > is that what you thought of? I got rid of the second interface by
> changing
> > > 'Rule'. Seems more straightforward.
> >
> > hi mika
> >
> > you probably don't need to change the Rule interface.
> > i'd prefer it if you call methods on the digester instance. (that's how
> > the BeanPropertySetterRule automagically knows how to match the property
> > called to the current element tag.) if the digester doesn't currently
> > expose the property you're after, then it's easy to add it.
> >
> > > About other matching methods: Yes, I think other methods of matching
> > > (XPath
> > > i.e.) could come, but as long as the interface is backwards compatible,
> > > selfconfiguring objects will continue to work.
> >
> > i don't think that different matching pattern rules will be a problem in
> > practice provided that the self-configuring behaviour can be turned on and
> > off.
> >
> > - robert
> >
> >
> > --
> > To unsubscribe, e-mail:
> <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> <mailto:commons-dev-help@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:commons-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-dev-help@jakarta.apache.org>


Mime
View raw message