Return-Path: Delivered-To: apmail-jakarta-commons-dev-archive@apache.org Received: (qmail 45566 invoked from network); 18 Nov 2001 21:15:59 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 18 Nov 2001 21:15:59 -0000 Received: (qmail 3756 invoked by uid 97); 18 Nov 2001 21:16:04 -0000 Delivered-To: qmlist-jakarta-archive-commons-dev@jakarta.apache.org Received: (qmail 3722 invoked by uid 97); 18 Nov 2001 21:16:02 -0000 Mailing-List: contact commons-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Developers List" Reply-To: "Jakarta Commons Developers List" Delivered-To: mailing list commons-dev@jakarta.apache.org Received: (qmail 3711 invoked from network); 18 Nov 2001 21:16:01 -0000 Sender: dlr@despot.finemaltcoding.com To: "Jakarta Commons Developers List" Cc: flanandowska@yahoo.com Subject: Re: [Submission] commons.util.http enhancements References: <20011101195324.8363.qmail@web10008.mail.yahoo.com> Content-Type: text/plain; charset=US-ASCII From: Daniel Rall Date: Sun, 18 Nov 2001 13:16:04 -0800 In-Reply-To: <20011101195324.8363.qmail@web10008.mail.yahoo.com> (Lavandowska's message of "Thu, 1 Nov 2001 11:53:24 -0800 (PST)") Message-ID: Lines: 14 User-Agent: Gnus/5.090004 (Oort Gnus v0.04) XEmacs/21.1 (Cuyahoga Valley) MIME-Version: 1.0 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Lavandowska writes: > I believe this (largely) fulfills your request. I've attached the > ExtendedBrowserDetector.java, RequestUtils.java, and modified build.xml I finally had some time to look at your patch, Lance. The build.xml file didn't have the JSDK JAR in the classpath at compile time, ExtendedBrowserDetector includes all of the content of BrowserDetector (which it sub-classes) and didn't compile. It might make more sense to have a single "flags" int member in ExtendedBrowserDetector and do bitwise ORs instead of having so many boolean flags. I didn't look at RequestUtils because I tired of fixing problems. Daniel -- To unsubscribe, e-mail: For additional commands, e-mail: