From commits-return-75557-apmail-commons-commits-archive=commons.apache.org@commons.apache.org Sun Aug 9 16:33:40 2020 Return-Path: X-Original-To: apmail-commons-commits-archive@locus.apache.org Delivered-To: apmail-commons-commits-archive@locus.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id E7DB419DBC for ; Sun, 9 Aug 2020 16:33:39 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 4D6AE124E84 for ; Sun, 9 Aug 2020 16:33:39 +0000 (UTC) Received: (qmail 60105 invoked by uid 500); 9 Aug 2020 16:33:38 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 59953 invoked by uid 500); 9 Aug 2020 16:33:38 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 59853 invoked by uid 99); 9 Aug 2020 16:33:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Aug 2020 16:33:38 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 51C958242E; Sun, 9 Aug 2020 16:33:38 +0000 (UTC) Date: Sun, 09 Aug 2020 16:33:38 +0000 To: "commits@commons.apache.org" Subject: [commons-io] branch master updated: assertion may fail MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <159699081825.19114.17961172024885662022@gitbox.apache.org> From: sebb@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: commons-io X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 93eada500cdfd4e3f44914e81c378814555fdb2b X-Git-Newrev: 73bd2591fa455aaaf6f1db3c5ce255a68fe67454 X-Git-Rev: 73bd2591fa455aaaf6f1db3c5ce255a68fe67454 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. sebb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git The following commit(s) were added to refs/heads/master by this push: new 73bd259 assertion may fail 73bd259 is described below commit 73bd2591fa455aaaf6f1db3c5ce255a68fe67454 Author: Sebb AuthorDate: Sun Aug 9 17:32:55 2020 +0100 assertion may fail --- src/test/java/org/apache/commons/io/input/TailerTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/apache/commons/io/input/TailerTest.java b/src/test/java/org/apache/commons/io/input/TailerTest.java index 3df483a..9ad67fd 100644 --- a/src/test/java/org/apache/commons/io/input/TailerTest.java +++ b/src/test/java/org/apache/commons/io/input/TailerTest.java @@ -234,9 +234,9 @@ public class TailerTest { // Delete & re-create file.delete(); - final boolean exists = file.exists(); - assertFalse(exists, "File should not exist"); + assertFalse(file.exists(), "File should not exist"); createFile(file, 0); + assertTrue(file.exists(), "File should now exist"); TestUtils.sleep(testDelayMillis); // Write another line @@ -255,7 +255,7 @@ public class TailerTest { assertNotNull(listener.exception, "Missing InterruptedException"); assertTrue(listener.exception instanceof InterruptedException, "Unexpected Exception: " + listener.exception); assertEquals(1 , listener.initialised, "Expected init to be called"); - assertEquals(0 , listener.notFound, "fileNotFound should not be called"); + // assertEquals(0 , listener.notFound, "fileNotFound should not be called"); // there is a window when it might be called assertEquals(1 , listener.rotated, "fileRotated should be be called"); }