commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [commons-io] branch master updated: assertion may fail
Date Sun, 09 Aug 2020 16:33:38 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 73bd259  assertion may fail
73bd259 is described below

commit 73bd2591fa455aaaf6f1db3c5ce255a68fe67454
Author: Sebb <sebb@apache.org>
AuthorDate: Sun Aug 9 17:32:55 2020 +0100

    assertion may fail
---
 src/test/java/org/apache/commons/io/input/TailerTest.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/input/TailerTest.java b/src/test/java/org/apache/commons/io/input/TailerTest.java
index 3df483a..9ad67fd 100644
--- a/src/test/java/org/apache/commons/io/input/TailerTest.java
+++ b/src/test/java/org/apache/commons/io/input/TailerTest.java
@@ -234,9 +234,9 @@ public class TailerTest {
 
         // Delete & re-create
         file.delete();
-        final boolean exists = file.exists();
-        assertFalse(exists, "File should not exist");
+        assertFalse(file.exists(), "File should not exist");
         createFile(file, 0);
+        assertTrue(file.exists(), "File should now exist");
         TestUtils.sleep(testDelayMillis);
 
         // Write another line
@@ -255,7 +255,7 @@ public class TailerTest {
         assertNotNull(listener.exception, "Missing InterruptedException");
         assertTrue(listener.exception instanceof InterruptedException, "Unexpected Exception:
" + listener.exception);
         assertEquals(1 , listener.initialised, "Expected init to be called");
-        assertEquals(0 , listener.notFound, "fileNotFound should not be called");
+        // assertEquals(0 , listener.notFound, "fileNotFound should not be called"); // there
is a window when it might be called
         assertEquals(1 , listener.rotated, "fileRotated should be be called");
     }
 


Mime
View raw message