From commits-return-72678-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Apr 5 12:44:08 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EB0FD180660 for ; Sun, 5 Apr 2020 14:44:07 +0200 (CEST) Received: (qmail 69285 invoked by uid 500); 5 Apr 2020 12:44:06 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 68941 invoked by uid 99); 5 Apr 2020 12:44:05 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Apr 2020 12:44:05 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 58F2081A13; Sun, 5 Apr 2020 12:44:05 +0000 (UTC) Date: Sun, 05 Apr 2020 12:44:08 +0000 To: "commits@commons.apache.org" Subject: [commons-numbers] 03/06: Fix coverage in PlaneAngleTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: aherbert@apache.org In-Reply-To: <158609064525.12606.6585162135697734800@gitbox.apache.org> References: <158609064525.12606.6585162135697734800@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: commons-numbers X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: 62c24fed077ec869a5d0b5fd4a32694891ff61a6 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20200405124405.58F2081A13@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git commit 62c24fed077ec869a5d0b5fd4a32694891ff61a6 Author: Alex Herbert AuthorDate: Sun Apr 5 12:26:00 2020 +0100 Fix coverage in PlaneAngleTest --- .../commons/numbers/angle/PlaneAngleTest.java | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java index 570edba..5cd2039 100644 --- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java +++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java @@ -160,24 +160,14 @@ public class PlaneAngleTest { } @Test - public void testEquals1() { + public void testEquals() { final double value = 12345.6789; final PlaneAngle a = PlaneAngle.ofRadians(value); - final PlaneAngle b = PlaneAngle.ofRadians(value); - Assertions.assertEquals(a, b); - } - @Test - public void testEquals2() { - final PlaneAngle a = PlaneAngle.ofRadians(153768.373486587); - final PlaneAngle b = null; - Assertions.assertFalse(a.equals(b)); - } - @Test - public void testEquals3() { - final double value = 0.987654321; - final PlaneAngle a = PlaneAngle.ofRadians(value); - final PlaneAngle b = PlaneAngle.ofRadians(value + 1e-16); - Assertions.assertNotEquals(a, b); + Assertions.assertTrue(a.equals(a)); + Assertions.assertTrue(a.equals(PlaneAngle.ofRadians(value))); + Assertions.assertFalse(a.equals(PlaneAngle.ofRadians(Math.nextUp(value)))); + Assertions.assertFalse(a.equals(new Object())); + Assertions.assertFalse(a.equals(null)); } @Test