From commits-return-72689-archive-asf-public=cust-asf.ponee.io@commons.apache.org Sun Apr 5 23:33:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C5FAC180638 for ; Mon, 6 Apr 2020 01:33:03 +0200 (CEST) Received: (qmail 8184 invoked by uid 500); 5 Apr 2020 23:33:03 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 8175 invoked by uid 99); 5 Apr 2020 23:33:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Apr 2020 23:33:03 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id E7760819F7; Sun, 5 Apr 2020 23:33:02 +0000 (UTC) Date: Sun, 05 Apr 2020 23:33:02 +0000 To: "commits@commons.apache.org" Subject: [commons-numbers] branch master updated: Fix coverage in SafeNormTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <158612958289.8331.2441016894843370053@gitbox.apache.org> From: aherbert@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: commons-numbers X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: a23596ae37ccba3657df18f01d02ca4ac5ef5dd3 X-Git-Newrev: c0a449face3959bb0cf09c43402ba88a69d5b2ab X-Git-Rev: c0a449face3959bb0cf09c43402ba88a69d5b2ab X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-numbers.git The following commit(s) were added to refs/heads/master by this push: new c0a449f Fix coverage in SafeNormTest c0a449f is described below commit c0a449face3959bb0cf09c43402ba88a69d5b2ab Author: Alex Herbert AuthorDate: Mon Apr 6 00:32:58 2020 +0100 Fix coverage in SafeNormTest Drop the redundant 0d delta for assertEquals. --- .../apache/commons/numbers/arrays/SafeNormTest.java | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java index 2b9aafe..82de37c 100644 --- a/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java +++ b/commons-numbers-arrays/src/test/java/org/apache/commons/numbers/arrays/SafeNormTest.java @@ -28,21 +28,21 @@ public class SafeNormTest { public void testTiny() { final double s = 1e-320; final double[] v = new double[] {s, s}; - Assertions.assertEquals(Math.sqrt(2) * s, SafeNorm.value(v), 0d); + Assertions.assertEquals(Math.sqrt(2) * s, SafeNorm.value(v)); } @Test public void testBig() { final double s = 1e300; final double[] v = new double[] {s, s}; - Assertions.assertEquals(Math.sqrt(2) * s, SafeNorm.value(v), 0d); + Assertions.assertEquals(Math.sqrt(2) * s, SafeNorm.value(v)); } @Test public void testOne3D() { final double s = 1; final double[] v = new double[] {s, s, s}; - Assertions.assertEquals(Math.sqrt(3), SafeNorm.value(v), 0d); + Assertions.assertEquals(Math.sqrt(3), SafeNorm.value(v)); } @Test @@ -56,13 +56,21 @@ public class SafeNormTest { public void testSimple() { final double[] v = new double[] {-0.9, 8.7, -6.5, -4.3, -2.1, 0, 1.2, 3.4, -5.6, 7.8, 9.0}; final double expected = direct(v); - Assertions.assertEquals(expected, SafeNorm.value(v), 0d); + Assertions.assertEquals(expected, SafeNorm.value(v)); } @Test public void testZero() { final double[] v = new double[] {0, 0, 0, 0, 0}; - Assertions.assertEquals(0d, SafeNorm.value(v), 0d); + Assertions.assertEquals(0d, SafeNorm.value(v)); + } + + @Test + public void testTinyAndSmallNormal() { + // Ensure the sum of the squared values for 'normal' values (1e-19*1e-19) + // is less than largest tiny value (1e-20) + final double[] v = new double[] {1e-20, 1e-19}; + Assertions.assertEquals(Math.sqrt(101) * 1e-20, SafeNorm.value(v)); } /**