commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aherb...@apache.org
Subject [commons-numbers] 01/09: Default the jacoco coverage checks to those in parent.
Date Sat, 04 Apr 2020 21:16:31 GMT
This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit c461f2509c08bf896beb8bbfc0b9c3bc7393c397
Author: Alex Herbert <aherbert@apache.org>
AuthorDate: Sat Apr 4 17:07:43 2020 +0100

    Default the jacoco coverage checks to those in parent.
    
    commons-parent is stricter than the removed configuration.
    
    Here we set the method ratio to 1.00. It should be possible to call all
    methods via the test suite.
    
    jacoco version 0.8.2 -> 0.8.5
    classRatio 0.96 -> 1.00
    instructionRatio 0.8 -> 0.90
    methodRatio 0.8 -> 0.95 => 1.00
    branchRatio 0.8 -> 0.85
    complexityRatio 0.8 -> 0.85
    lineRatio 0.85 -> 0.90
    
    haltOnFailure is still false to prevent build failure.
---
 pom.xml | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 70790c0..b7ccc85 100644
--- a/pom.xml
+++ b/pom.xml
@@ -67,14 +67,9 @@
     <!-- Workaround to avoid duplicating config files. -->
     <numbers.parent.dir>${basedir}</numbers.parent.dir>
 
-    <!-- Temporary fix to support Java 8 -->
-    <commons.jacoco.version>0.8.2</commons.jacoco.version>
-    <commons.jacoco.classRatio>0.96</commons.jacoco.classRatio>
-    <commons.jacoco.instructionRatio>0.8</commons.jacoco.instructionRatio>
-    <commons.jacoco.methodRatio>0.8</commons.jacoco.methodRatio>
-    <commons.jacoco.branchRatio>0.8</commons.jacoco.branchRatio>
-    <commons.jacoco.complexityRatio>0.8</commons.jacoco.complexityRatio>
-    <commons.jacoco.lineRatio>0.85</commons.jacoco.lineRatio>
+    <!-- Increase from commons-parent -->
+    <commons.jacoco.methodRatio>1.00</commons.jacoco.methodRatio>
+    <!-- Set to true when coverage goals are achieved -->
     <commons.jacoco.haltOnFailure>false</commons.jacoco.haltOnFailure>
 
     <!-- Override CP 47 -->


Mime
View raw message