From commits-return-72224-archive-asf-public=cust-asf.ponee.io@commons.apache.org Mon Feb 17 14:10:35 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE039180636 for ; Mon, 17 Feb 2020 15:10:34 +0100 (CET) Received: (qmail 38774 invoked by uid 500); 17 Feb 2020 14:10:31 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 38315 invoked by uid 99); 17 Feb 2020 14:10:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Feb 2020 14:10:30 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 582638B6A1; Mon, 17 Feb 2020 14:10:30 +0000 (UTC) Date: Mon, 17 Feb 2020 14:10:36 +0000 To: "commits@commons.apache.org" Subject: [commons-collections] 06/12: Remove extra lines. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: aherbert@apache.org In-Reply-To: <158194863013.17551.13458460103866144954@gitbox.apache.org> References: <158194863013.17551.13458460103866144954@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: commons-collections X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: b377f59613947a311a2fc3105dc7ae14b9343f24 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20200217141030.582638B6A1@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git commit b377f59613947a311a2fc3105dc7ae14b9343f24 Author: aherbert AuthorDate: Mon Feb 17 13:24:03 2020 +0000 Remove extra lines. --- .../collections4/bloomfilter/hasher/DynamicHasher.java | 1 - .../bloomfilter/hasher/HashFunctionIdentity.java | 3 --- .../commons/collections4/bloomfilter/hasher/Hasher.java | 1 - .../commons/collections4/bloomfilter/hasher/Shape.java | 3 --- .../collections4/bloomfilter/AbstractBloomFilterTest.java | 2 -- .../collections4/bloomfilter/BitSetBloomFilterTest.java | 4 ---- .../collections4/bloomfilter/CountingBloomFilterTest.java | 14 -------------- .../bloomfilter/DefaultBloomFilterMethodsTest.java | 2 -- .../collections4/bloomfilter/HasherBloomFilterTest.java | 1 - .../collections4/bloomfilter/SetOperationsTest.java | 13 ------------- .../bloomfilter/hasher/CommonComparatorTest.java | 2 -- .../bloomfilter/hasher/DeepComparatorTest.java | 2 -- .../bloomfilter/hasher/DynamicHasherBuilderTest.java | 1 - .../collections4/bloomfilter/hasher/DynamicHasherTest.java | 3 --- .../bloomfilter/hasher/HashFunctionIdentityImplTest.java | 1 - .../commons/collections4/bloomfilter/hasher/ShapeTest.java | 5 ----- .../collections4/bloomfilter/hasher/StaticHasherTest.java | 4 ---- .../bloomfilter/hasher/function/MD5CyclicTest.java | 1 - .../hasher/function/Murmur128x86CyclicTest.java | 1 - .../hasher/function/Murmur32x86IterativeTest.java | 1 - .../hasher/function/ObjectsHashIterativeTest.java | 1 - 21 files changed, 66 deletions(-) diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasher.java b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasher.java index 9036d79..56be62b 100644 --- a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasher.java +++ b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasher.java @@ -81,7 +81,6 @@ public class DynamicHasher implements Hasher { public final Builder with(final String property) { return with(property.getBytes(StandardCharsets.UTF_8)); } - } /** diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java index 00170e0..3b14b84 100644 --- a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java +++ b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java @@ -52,7 +52,6 @@ public interface HashFunctionIdentity { * HashFunctionIdentity name, signedness, and process. */ Comparator COMMON_COMPARATOR = new Comparator() { - @Override public int compare(final HashFunctionIdentity identity1, final HashFunctionIdentity identity2) { int result = identity1.getName().compareToIgnoreCase(identity2.getName()); @@ -71,7 +70,6 @@ public interface HashFunctionIdentity { * HashFunctionIdentity name, signedness, process, and privider.. */ Comparator DEEP_COMPARATOR = new Comparator() { - @Override public int compare(final HashFunctionIdentity identity1, final HashFunctionIdentity identity2) { int result = COMMON_COMPARATOR.compare(identity1, identity2); @@ -109,7 +107,6 @@ public interface HashFunctionIdentity { return String.format("%s-%s-%s", identity.getName().toUpperCase(Locale.ROOT), identity.getSignedness(), identity.getProcessType() ).getBytes(StandardCharsets.UTF_8); - } /** diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Hasher.java b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Hasher.java index 224902b..523438c 100644 --- a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Hasher.java +++ b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Hasher.java @@ -74,7 +74,6 @@ public interface Hasher { * @see #getBits(Shape) */ Builder with(String property); - } /** diff --git a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java index b3ac6ed..b241650 100644 --- a/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java +++ b/src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java @@ -167,7 +167,6 @@ public class Shape { this.hashCode = generateHashCode(); // check that probability is within range getProbability(); - } /** @@ -193,7 +192,6 @@ public class Shape { this.hashCode = generateHashCode(); // check that probability is within range getProbability(); - } /** @@ -224,7 +222,6 @@ public class Shape { this.hashCode = generateHashCode(); // check that probability is within range getProbability(); - } /** diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java index 9608373..a338899 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java @@ -365,7 +365,6 @@ public abstract class AbstractBloomFilterTest { hasher2 = new StaticHasher(values.iterator(), shape); filter = createFilter(hasher2, shape); assertFalse(filter.isFull()); - } /** @@ -519,5 +518,4 @@ public abstract class AbstractBloomFilterTest { assertEquals(20, bf.xorCardinality(bf2)); assertEquals(20, bf2.xorCardinality(bf)); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilterTest.java index 51c1027..9fc4995 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilterTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilterTest.java @@ -57,7 +57,6 @@ public class BitSetBloomFilterTest extends AbstractBloomFilterTest { bf2 = createFilter(hasher2, shape); assertEquals(0, bf.andCardinality(bf2)); assertEquals(0, bf2.andCardinality(bf)); - } @Override @@ -88,7 +87,6 @@ public class BitSetBloomFilterTest extends AbstractBloomFilterTest { bf.merge(bf2); assertEquals(27, bf.cardinality()); - } /** @@ -116,7 +114,5 @@ public class BitSetBloomFilterTest extends AbstractBloomFilterTest { bf2 = createFilter(hasher2, shape); assertEquals(15, bf.xorCardinality(bf2)); assertEquals(15, bf2.xorCardinality(bf)); - } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilterTest.java index c59dd9b..11cdeee 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilterTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilterTest.java @@ -37,7 +37,6 @@ import org.junit.Test; */ public class CountingBloomFilterTest extends AbstractBloomFilterTest { - /** * Tests that the andCardinality calculation executes correctly when using a * CountingBloomFilter argument. @@ -64,8 +63,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { bf2 = createFilter(hasher2, shape); assertEquals(0, bf.andCardinality(bf2)); assertEquals(0, bf2.andCardinality(bf)); - - } /** @@ -81,7 +78,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { assertEquals(0x1FFFF, lb[0]); assertEquals(1, lb.length); - assertEquals(17, bf.getCounts().count()); assertEquals(Integer.valueOf(1), bf.getCounts().map(Map.Entry::getValue).max(Integer::compare).get()); assertEquals(Integer.valueOf(1), bf.getCounts().map(Map.Entry::getValue).min(Integer::compare).get()); @@ -129,7 +125,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { { // expected } - } @Override @@ -142,7 +137,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { return new CountingBloomFilter(hasher, shape); } - /** * Tests that merge correctly updates the counts when a CountingBloomFilter is passed */ @@ -219,7 +213,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { assertEquals("Wrong value for "+i, expected[i], m.get(i).intValue()); } } - } /** @@ -233,7 +226,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { CountingBloomFilter bf = createFilter(hasher, shape); - final Map map = new HashMap<>(); bf.getCounts().forEach(e -> map.put(e.getKey(), e.getValue())); map.put(1, Integer.MAX_VALUE); @@ -328,7 +320,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { assertNotNull(map2.get(i)); assertEquals(1, map2.get(i).intValue()); } - } /** @@ -352,7 +343,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { final List lst = Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ,16 ,17); final Hasher hasher = new StaticHasher(lst.iterator(), shape); - bf.remove(hasher); assertEquals(17, bf.cardinality()); final Map map2 = new HashMap<>(); @@ -363,7 +353,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { assertNotNull(map2.get(i)); assertEquals(1, map2.get(i).intValue()); } - } /** @@ -398,7 +387,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { assertNotNull(map2.get(i)); assertEquals(1, map2.get(i).intValue()); } - } /** @@ -412,7 +400,6 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { CountingBloomFilter bf = createFilter(hasher, shape); - final Map map = new HashMap<>(); bf.getCounts().forEach(e -> map.put(e.getKey(), e.getValue())); map.remove(1); @@ -435,5 +422,4 @@ public class CountingBloomFilterTest extends AbstractBloomFilterTest { // do nothing } } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterMethodsTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterMethodsTest.java index 2c6fd2d..c1f248d 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterMethodsTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/DefaultBloomFilterMethodsTest.java @@ -84,7 +84,6 @@ public class DefaultBloomFilterMethodsTest extends AbstractBloomFilterTest { verifyHasher(hasher); hasher.getBits(getShape()).forEachRemaining((IntConsumer) bitSet::set); } - } @Override @@ -96,5 +95,4 @@ public class DefaultBloomFilterMethodsTest extends AbstractBloomFilterTest { protected AbstractBloomFilter createFilter(final Hasher hasher, final Shape shape) { return new BF(hasher, shape); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilterTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilterTest.java index 2c398b4..c0c4902 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilterTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/HasherBloomFilterTest.java @@ -57,5 +57,4 @@ public class HasherBloomFilterTest extends AbstractBloomFilterTest { protected HasherBloomFilter createFilter(final Hasher hasher, final Shape shape) { return new HasherBloomFilter(hasher, shape); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/SetOperationsTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/SetOperationsTest.java index a8fc4eb..233ec42 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/SetOperationsTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/SetOperationsTest.java @@ -95,7 +95,6 @@ public class SetOperationsTest { assertEquals(0.514928749927334, SetOperations.cosineDistance(filter1, filter2), 0.000000000000001); assertEquals(0.514928749927334, SetOperations.cosineDistance(filter2, filter1), 0.000000000000001); - } /** @@ -115,7 +114,6 @@ public class SetOperationsTest { assertEquals(1.0, SetOperations.cosineDistance(filter2, filter1), 0.0001); assertEquals(1.0, SetOperations.cosineDistance(filter1, filter3), 0.0001); assertEquals(1.0, SetOperations.cosineDistance(filter3, filter1), 0.0001); - } /** @@ -140,7 +138,6 @@ public class SetOperationsTest { assertEquals(0.485071250072666, SetOperations.cosineSimilarity(filter1, filter2), 0.000000000000001); assertEquals(0.485071250072666, SetOperations.cosineSimilarity(filter2, filter1), 0.000000000000001); - } /** @@ -160,7 +157,6 @@ public class SetOperationsTest { assertEquals(0.0, SetOperations.cosineSimilarity(filter2, filter1), 0.0001); assertEquals(0.0, SetOperations.cosineSimilarity(filter1, filter3), 0.0001); assertEquals(0.0, SetOperations.cosineSimilarity(filter3, filter1), 0.0001); - } /** @@ -180,7 +176,6 @@ public class SetOperationsTest { final long estimate = SetOperations.estimateIntersectionSize(filter1, filter2); assertEquals(1, estimate); - } /** @@ -207,10 +202,8 @@ public class SetOperationsTest { final BloomFilter filter2 = new HasherBloomFilter(hasher2, shape); assertEquals(3, SetOperations.estimateSize(filter2)); - } - /** * Tests that the union size estimate is correctly calculated. */ @@ -228,7 +221,6 @@ public class SetOperationsTest { final long estimate = SetOperations.estimateUnionSize(filter1, filter2); assertEquals(3, estimate); - } /** @@ -253,10 +245,8 @@ public class SetOperationsTest { assertEquals(17, SetOperations.hammingDistance(filter1, filter2)); assertEquals(17, SetOperations.hammingDistance(filter2, filter1)); - } - /** * Tests that the Jaccard distance is correctly calculated. */ @@ -279,7 +269,6 @@ public class SetOperationsTest { assertEquals(0.32, SetOperations.jaccardDistance(filter1, filter2), 0.001); assertEquals(0.32, SetOperations.jaccardDistance(filter2, filter1), 0.001); - } /** @@ -299,7 +288,6 @@ public class SetOperationsTest { assertEquals(1.0, SetOperations.jaccardDistance(filter2, filter1), 0.0001); assertEquals(0.0, SetOperations.jaccardDistance(filter1, filter3), 0.0001); assertEquals(0.0, SetOperations.jaccardDistance(filter3, filter1), 0.0001); - } /** @@ -343,6 +331,5 @@ public class SetOperationsTest { assertEquals(0.0, SetOperations.jaccardSimilarity(filter2, filter1), 0.0001); assertEquals(1.0, SetOperations.jaccardSimilarity(filter1, filter3), 0.0001); assertEquals(1.0, SetOperations.jaccardSimilarity(filter3, filter1), 0.0001); - } } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/CommonComparatorTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/CommonComparatorTest.java index 3c326d7..183bc02 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/CommonComparatorTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/CommonComparatorTest.java @@ -54,7 +54,6 @@ public class CommonComparatorTest { ProcessType.CYCLIC, 300L); assertEquals(0, HashFunctionIdentity.COMMON_COMPARATOR.compare(impl1, impl2)); - } /** @@ -160,5 +159,4 @@ public class CommonComparatorTest { assertEquals("Unexpected order for " + HashFunctionIdentity.asCommonString(id), idx++, id.getSignature()); } } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DeepComparatorTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DeepComparatorTest.java index e8649fd..b456930 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DeepComparatorTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DeepComparatorTest.java @@ -54,7 +54,6 @@ public class DeepComparatorTest { ProcessType.CYCLIC, 300L); assertEquals(0, HashFunctionIdentity.DEEP_COMPARATOR.compare(impl1, impl2)); - } /** @@ -187,5 +186,4 @@ public class DeepComparatorTest { idx++, id.getSignature()); } } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherBuilderTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherBuilderTest.java index 6aa0bac..a63e911 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherBuilderTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherBuilderTest.java @@ -66,7 +66,6 @@ public class DynamicHasherBuilderTest { assertTrue(iter.hasNext()); assertEquals(expected, iter.nextInt()); assertFalse(iter.hasNext()); - } /** diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherTest.java index e8d91d4..fa4efa5 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/DynamicHasherTest.java @@ -93,7 +93,6 @@ public class DynamicHasherTest { assertEquals(element, iter.nextInt()); } assertFalse(iter.hasNext()); - } /** @@ -113,7 +112,6 @@ public class DynamicHasherTest { assertEquals(element, iter.nextInt()); } assertFalse(iter.hasNext()); - } /** @@ -140,5 +138,4 @@ public class DynamicHasherTest { assertTrue(builder.build().isEmpty()); assertFalse(builder.with("Hello").build().isEmpty()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentityImplTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentityImplTest.java index 7356559..04b3651 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentityImplTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentityImplTest.java @@ -89,5 +89,4 @@ public class HashFunctionIdentityImplTest { assertEquals(ProcessType.ITERATIVE, impl.getProcessType()); assertEquals(-2l, impl.getSignature()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/ShapeTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/ShapeTest.java index af184ce..899cb65 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/ShapeTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/ShapeTest.java @@ -182,7 +182,6 @@ public class ShapeTest { assertEquals(4, filterConfig.getNumberOfHashFunctions()); assertEquals(5, filterConfig.getNumberOfItems()); assertEquals(0.102194782, filterConfig.getProbability(), 0.000001); - } /** @@ -200,7 +199,6 @@ public class ShapeTest { assertEquals(3, filterConfig.getNumberOfHashFunctions()); assertEquals(5, filterConfig.getNumberOfItems()); assertEquals(0.100375138, filterConfig.getProbability(), 0.000001); - } /** @@ -260,7 +258,6 @@ public class ShapeTest { assertEquals(3, shape.getNumberOfHashFunctions()); assertEquals(5, shape.getNumberOfItems()); assertEquals(0.100375138, shape.getProbability(), 0.000001); - } /** @@ -448,7 +445,6 @@ public class ShapeTest { }; assertNotEquals(new Shape(testFunction2, 4, 1.0 / 10), shape); - } /** @@ -459,5 +455,4 @@ public class ShapeTest { final int hashCode = Objects.hash(testFunction, 24, 3); assertEquals(hashCode, shape.hashCode()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasherTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasherTest.java index f622171..30daaa9 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasherTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/StaticHasherTest.java @@ -244,7 +244,6 @@ public class StaticHasherTest { final StaticHasher hasher2 = new StaticHasher(hasher, shape); assertEquals(shape, hasher2.getShape()); assertSameBits(hasher, hasher2); - } /** @@ -280,7 +279,6 @@ public class StaticHasherTest { assertEquals(i, iter.nextInt()); } assertFalse(iter.hasNext()); - } /** @@ -317,7 +315,6 @@ public class StaticHasherTest { } catch (final IllegalArgumentException expected) { // do nothing } - } /** @@ -328,7 +325,6 @@ public class StaticHasherTest { final List lst = new ArrayList<>(); StaticHasher hasher = new StaticHasher(lst.iterator(), shape); - assertTrue(hasher.isEmpty()); lst.add( Integer.valueOf(1)); diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5CyclicTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5CyclicTest.java index 16c59f4..428c02a 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5CyclicTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/MD5CyclicTest.java @@ -60,5 +60,4 @@ public class MD5CyclicTest { final long expected = md5.apply(arg.getBytes(StandardCharsets.UTF_8), 0); assertEquals(expected, md5.getSignature()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur128x86CyclicTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur128x86CyclicTest.java index 61f3a48..6dd9730 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur128x86CyclicTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur128x86CyclicTest.java @@ -62,5 +62,4 @@ public class Murmur128x86CyclicTest { final long expected = murmur.apply(arg.getBytes(StandardCharsets.UTF_8), 0); assertEquals(expected, murmur.getSignature()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur32x86IterativeTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur32x86IterativeTest.java index d15eb5a..96ad132 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur32x86IterativeTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/Murmur32x86IterativeTest.java @@ -60,5 +60,4 @@ public class Murmur32x86IterativeTest { final long expected = murmur.apply(arg.getBytes(StandardCharsets.UTF_8), 0); assertEquals(expected, murmur.getSignature()); } - } diff --git a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/ObjectsHashIterativeTest.java b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/ObjectsHashIterativeTest.java index 9387346..17ebb11 100644 --- a/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/ObjectsHashIterativeTest.java +++ b/src/test/java/org/apache/commons/collections4/bloomfilter/hasher/function/ObjectsHashIterativeTest.java @@ -65,5 +65,4 @@ public class ObjectsHashIterativeTest { assertEquals(expected, expected2); assertEquals(expected, obj.getSignature()); } - }