From commits-return-70614-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Nov 28 14:12:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EA42218064C for ; Thu, 28 Nov 2019 15:12:17 +0100 (CET) Received: (qmail 58380 invoked by uid 500); 28 Nov 2019 14:12:09 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 58003 invoked by uid 99); 28 Nov 2019 14:12:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Nov 2019 14:12:08 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 3CC108B692; Thu, 28 Nov 2019 14:12:08 +0000 (UTC) Date: Thu, 28 Nov 2019 14:12:17 +0000 To: "commits@commons.apache.org" Subject: [commons-geometry] 09/12: Prefer method reference (over lambda). MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: erans@apache.org In-Reply-To: <157495032799.2938.11632589601968629503@gitbox.apache.org> References: <157495032799.2938.11632589601968629503@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: commons-geometry X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: 0dd2ad4964ef2d85973258858e3f586d573c8e27 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20191128141208.3CC108B692@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-geometry.git commit 0dd2ad4964ef2d85973258858e3f586d573c8e27 Author: Gilles Sadowski AuthorDate: Thu Nov 28 14:54:23 2019 +0100 Prefer method reference (over lambda). Reported by "sonarcloud.io". --- .../java/org/apache/commons/geometry/euclidean/twod/Polyline.java | 6 +++--- .../java/org/apache/commons/geometry/spherical/oned/Point1S.java | 2 +- .../org/apache/commons/geometry/spherical/twod/ConvexArea2S.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Polyline.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Polyline.java index 236ac2e..9ef8a1c 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Polyline.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/Polyline.java @@ -172,7 +172,7 @@ public class Polyline implements Iterable { if (!isEmpty()) { final List transformed = segments.stream() .map(s -> s.transform(transform)) - .collect(Collectors.toCollection(() -> new ArrayList<>())); + .collect(Collectors.toCollection(ArrayList::new)); return new Polyline(transformed); } @@ -188,8 +188,8 @@ public class Polyline implements Iterable { public Polyline reverse() { if (!isEmpty()) { final List reversed = segments.stream() - .map(s -> s.reverse()) - .collect(Collectors.toCollection(() -> new ArrayList<>())); + .map(Segment::reverse) + .collect(Collectors.toCollection(ArrayList::new)); Collections.reverse(reversed); return new Polyline(reversed); diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Point1S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Point1S.java index c3f8fbe..0f8b006 100644 --- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Point1S.java +++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Point1S.java @@ -353,7 +353,7 @@ public final class Point1S implements Point { * @throws IllegalArgumentException if the given string has an invalid format */ public static Point1S parse(final String str) { - return SimpleTupleFormat.getDefault().parse(str, az -> Point1S.of(az)); + return SimpleTupleFormat.getDefault().parse(str, Point1S::of); } /** Compute the signed shortest distance (angular separation) between two points. The return diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/ConvexArea2S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/ConvexArea2S.java index 36f3241..7581b90 100644 --- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/ConvexArea2S.java +++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/ConvexArea2S.java @@ -258,8 +258,8 @@ public final class ConvexArea2S extends AbstractConvexHyperplaneBoundedRegion bounds = path.getArcs().stream() - .map(a -> a.getCircle()) - .collect(Collectors.toList()); + .map(GreatArc::getCircle) + .collect(Collectors.toList()); return fromBounds(bounds); }