From commits-return-70617-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Nov 28 14:12:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B0E6B18064C for ; Thu, 28 Nov 2019 15:12:18 +0100 (CET) Received: (qmail 58569 invoked by uid 500); 28 Nov 2019 14:12:10 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 57890 invoked by uid 99); 28 Nov 2019 14:12:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Nov 2019 14:12:08 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 22BF98B694; Thu, 28 Nov 2019 14:12:08 +0000 (UTC) Date: Thu, 28 Nov 2019 14:12:12 +0000 To: "commits@commons.apache.org" Subject: [commons-geometry] 04/12: Avoid several method having identical implementation. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: erans@apache.org In-Reply-To: <157495032799.2938.11632589601968629503@gitbox.apache.org> References: <157495032799.2938.11632589601968629503@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: commons-geometry X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: d7fb844a13c56823155e9797844ab345c3375691 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20191128141208.22BF98B694@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. erans pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-geometry.git commit d7fb844a13c56823155e9797844ab345c3375691 Author: Gilles Sadowski AuthorDate: Thu Nov 28 13:48:15 2019 +0100 Avoid several method having identical implementation. Aliases should call the "primary" method. Reported by "sonarcloud.io". --- .../commons/geometry/core/precision/EpsilonDoublePrecisionContext.java | 2 +- .../main/java/org/apache/commons/geometry/euclidean/threed/Plane.java | 2 +- .../apache/commons/geometry/spherical/twod/AbstractSubGreatCircle.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/precision/EpsilonDoublePrecisionContext.java b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/precision/EpsilonDoublePrecisionContext.java index 1bc6213..dfc9b34 100644 --- a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/precision/EpsilonDoublePrecisionContext.java +++ b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/precision/EpsilonDoublePrecisionContext.java @@ -56,7 +56,7 @@ public class EpsilonDoublePrecisionContext extends DoublePrecisionContext { */ @Override public double getMaxZero() { - return epsilon; + return getEpsilon(); } /** {@inheritDoc} **/ diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java index 14b423f..4fa7081 100644 --- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java +++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java @@ -149,7 +149,7 @@ public final class Plane extends AbstractHyperplane * @see #getW() */ public Vector3D getNormal() { - return w; + return getW(); } /** {@inheritDoc} */ diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/AbstractSubGreatCircle.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/AbstractSubGreatCircle.java index 1a314fd..0c1ba26 100644 --- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/AbstractSubGreatCircle.java +++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/AbstractSubGreatCircle.java @@ -46,7 +46,7 @@ abstract class AbstractSubGreatCircle /** {@inheritDoc} */ @Override public GreatCircle getHyperplane() { - return circle; + return getCircle(); } /** {@inheritDoc} */