From commits-return-70600-archive-asf-public=cust-asf.ponee.io@commons.apache.org Thu Nov 28 10:50:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 49DAD180674 for ; Thu, 28 Nov 2019 11:50:39 +0100 (CET) Received: (qmail 4123 invoked by uid 500); 28 Nov 2019 10:50:36 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 4072 invoked by uid 99); 28 Nov 2019 10:50:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Nov 2019 10:50:36 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id D7F6A8B691; Thu, 28 Nov 2019 10:50:35 +0000 (UTC) Date: Thu, 28 Nov 2019 10:50:36 +0000 To: "commits@commons.apache.org" Subject: [commons-codec] 01/05: [CODEC-270] Add more impossible base32/64 test cases. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: aherbert@apache.org In-Reply-To: <157493823580.31811.18280988533779367815@gitbox.apache.org> References: <157493823580.31811.18280988533779367815@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: commons-codec X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: 7b1961506509391ec847bb1dc3783a87f8069057 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20191128105035.D7F6A8B691@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-codec.git commit 7b1961506509391ec847bb1dc3783a87f8069057 Author: Alex Herbert AuthorDate: Sun Nov 24 23:08:14 2019 +0000 [CODEC-270] Add more impossible base32/64 test cases. These currently are parsed by the code as valid but should not be. Fixed the BCodec test impossible cases to contain the correct RFC 1522 header. --- src/test/java/org/apache/commons/codec/binary/Base32Test.java | 3 ++- src/test/java/org/apache/commons/codec/binary/Base64Test.java | 1 + src/test/java/org/apache/commons/codec/net/BCodecTest.java | 10 ++++++---- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/test/java/org/apache/commons/codec/binary/Base32Test.java b/src/test/java/org/apache/commons/codec/binary/Base32Test.java index d7d2d34..725b912 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base32Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base32Test.java @@ -51,7 +51,8 @@ public class Base32Test { "MZXE====", "MZXWB===", "MZXW6YB=", - "MZXW6YTBOC======" + "MZXW6YTBOC======", + "AB======" }; private static final String[] BASE32_IMPOSSIBLE_CASES_CHUNKED = { diff --git a/src/test/java/org/apache/commons/codec/binary/Base64Test.java b/src/test/java/org/apache/commons/codec/binary/Base64Test.java index a9b9867..442fc4c 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base64Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base64Test.java @@ -49,6 +49,7 @@ public class Base64Test { "ZmC=", "Zm9vYE==", "Zm9vYmC=", + "AB", }; private final Random random = new Random(); diff --git a/src/test/java/org/apache/commons/codec/net/BCodecTest.java b/src/test/java/org/apache/commons/codec/net/BCodecTest.java index 5a90629..2e23d5a 100644 --- a/src/test/java/org/apache/commons/codec/net/BCodecTest.java +++ b/src/test/java/org/apache/commons/codec/net/BCodecTest.java @@ -34,10 +34,12 @@ import org.junit.Test; */ public class BCodecTest { private static final String[] BASE64_IMPOSSIBLE_CASES = { - "ZE==", - "ZmC=", - "Zm9vYE==", - "Zm9vYmC=", + // Require the RFC 1522 "encoded-word" header + "=?ASCII?B?ZE==?=", + "=?ASCII?B?ZmC=?=", + "=?ASCII?B?Zm9vYE==?=", + "=?ASCII?B?Zm9vYmC=?=", + "=?ASCII?B?AB==?=" }; static final int SWISS_GERMAN_STUFF_UNICODE[] =