commons-commits mailing list archives

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit 8c1ac8e74cc22179848519f9258f95063101dff1
Author: Gilles Sadowski <gilles@harfang.homelinux.org>
AuthorDate: Thu Nov 28 12:48:19 2019 +0100

    Removed "onCut" check which at that point is always "true".
    
    Reported by "sonarcloud.io".
---
 .../apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
index b5aa0e0..e204e2c 100644
--- a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
+++ b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
@@ -339,7 +339,7 @@ public abstract class AbstractBSPTree<P extends Point<P>, N extends
AbstractBSPT
 
             if (onMinusSide || (onCut && cutBehavior == NodeCutRule.MINUS)) {
                 return findNode(start.getMinus(), pt, cutBehavior);
-            } else if (onPlusSide || (onCut && cutBehavior == NodeCutRule.PLUS))
{
+            } else if (onPlusSide || cutBehavior == NodeCutRule.PLUS) {
                 return findNode(start.getPlus(), pt, cutBehavior);
             }
         }