commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject [commons-vfs] branch master updated: Do not shutdown the Apache HttpClient connection pool at the end of the WebDAV tests because this messes up HTTP tests that run after in a Maven build on Linux. I do not know why the failure does not happen on Windows or macOS, maybe the tests are executed in a different order there and we are just lucky on Windows and macOS and not lucky on Linux. All tests pass locally.
Date Fri, 01 Feb 2019 14:00:31 GMT
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new ece7e96  Do not shutdown the Apache HttpClient connection pool at the end of the
WebDAV tests because this messes up HTTP tests that run after in a Maven build on Linux. I
do not know why the failure does not happen on Windows or macOS, maybe the tests are executed
in a different order there and we are just lucky on Windows and macOS and not lucky on Linux.
All tests pass locally.
ece7e96 is described below

commit ece7e96a93946e107626e3ffb840509c8dffb6ad
Author: Gary Gregory <ggregory@rocketsoftware.com>
AuthorDate: Fri Feb 1 09:00:30 2019 -0500

    Do not shutdown the Apache HttpClient connection pool at the end of the
    WebDAV tests because this messes up HTTP tests that run after in a Maven
    build on Linux. I do not know why the failure does not happen on Windows
    or macOS, maybe the tests are executed in a different order there and we
    are just lucky on Windows and macOS and not lucky on Linux. All tests
    pass locally.
---
 .../commons/vfs2/provider/webdav/test/WebdavProviderTestCase.java       | 2 --
 1 file changed, 2 deletions(-)

diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/webdav/test/WebdavProviderTestCase.java
b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/webdav/test/WebdavProviderTestCase.java
index 3258aac..4a844dc 100644
--- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/webdav/test/WebdavProviderTestCase.java
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/webdav/test/WebdavProviderTestCase.java
@@ -269,8 +269,6 @@ public class WebdavProviderTestCase extends AbstractProviderTestConfig
{
     private static void tearDownClass() throws Exception {
         // Main JR shutdown
         JrMain.shutdown();
-        // WARN logged because one thread is still there, so clean up explicitly.
-        MultiThreadedHttpConnectionManager.shutdownAll();
 
         if (DEBUG) {
             message("Skipping cleanup of " + RepoDirectory);


Mime
View raw message