From commits-return-64800-archive-asf-public=cust-asf.ponee.io@commons.apache.org Tue Oct 2 18:57:24 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 460F4180638 for ; Tue, 2 Oct 2018 18:57:24 +0200 (CEST) Received: (qmail 84721 invoked by uid 500); 2 Oct 2018 16:57:23 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 84712 invoked by uid 99); 2 Oct 2018 16:57:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 16:57:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CC8B9E0054; Tue, 2 Oct 2018 16:57:22 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: vanzin@apache.org To: commits@commons.apache.org Message-Id: <261119fa199248459ca97ab809ae70a6@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: commons-crypto git commit: Clean up a few build warnings. Date: Tue, 2 Oct 2018 16:57:22 +0000 (UTC) Repository: commons-crypto Updated Branches: refs/heads/master 2b6984939 -> ec4150fe3 Clean up a few build warnings. - remove references to the javancss plugin - clear up javadoc warnings from checkstyle by only requiring them for methods that are protected (or more visible) - remove an unused import Closes #86 Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/ec4150fe Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/ec4150fe Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/ec4150fe Branch: refs/heads/master Commit: ec4150fe30ceb9726618e60d6557a85cc122d77b Parents: 2b69849 Author: Marcelo Vanzin Authored: Mon Oct 1 18:12:13 2018 -0700 Committer: Marcelo Vanzin Committed: Tue Oct 2 09:57:04 2018 -0700 ---------------------------------------------------------------------- checkstyle.xml | 1 + pom.xml | 13 +------------ .../apache/commons/crypto/cipher/OpenSslCipher.java | 1 - .../commons/crypto/cipher/OpenSslCommonMode.java | 2 +- .../commons/crypto/cipher/OpenSslEvpCtrlValues.java | 2 +- 5 files changed, 4 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/ec4150fe/checkstyle.xml ---------------------------------------------------------------------- diff --git a/checkstyle.xml b/checkstyle.xml index 796ec19..5661e3a 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -38,6 +38,7 @@ limitations under the License. + http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/ec4150fe/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index bb23e3d..ea791a1 100644 --- a/pom.xml +++ b/pom.xml @@ -560,6 +560,7 @@ The following provides more details on the included cryptographic software: ${basedir}/checkstyle.xml false + true @@ -632,11 +633,6 @@ The following provides more details on the included cryptographic software: - org.codehaus.mojo - javancss-maven-plugin - 2.1 - - org.apache.rat apache-rat-plugin @@ -649,13 +645,6 @@ The following provides more details on the included cryptographic software: - - org.codehaus.mojo - javancss-maven-plugin - - true - - http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/ec4150fe/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java index c62d58b..aa0dfd2 100644 --- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java +++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCipher.java @@ -28,7 +28,6 @@ import javax.crypto.BadPaddingException; import javax.crypto.Cipher; import javax.crypto.IllegalBlockSizeException; import javax.crypto.ShortBufferException; -import javax.crypto.spec.IvParameterSpec; import org.apache.commons.crypto.utils.Utils; http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/ec4150fe/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java index f602d11..91475fc 100644 --- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java +++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslCommonMode.java @@ -32,7 +32,7 @@ import java.security.spec.AlgorithmParameterSpec; */ class OpenSslCommonMode extends OpenSslFeedbackCipher { - public OpenSslCommonMode(long context, int algorithmMode, int padding) { + OpenSslCommonMode(long context, int algorithmMode, int padding) { super(context, algorithmMode, padding); } http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/ec4150fe/src/main/java/org/apache/commons/crypto/cipher/OpenSslEvpCtrlValues.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/crypto/cipher/OpenSslEvpCtrlValues.java b/src/main/java/org/apache/commons/crypto/cipher/OpenSslEvpCtrlValues.java index 2b64ff5..f826af9 100644 --- a/src/main/java/org/apache/commons/crypto/cipher/OpenSslEvpCtrlValues.java +++ b/src/main/java/org/apache/commons/crypto/cipher/OpenSslEvpCtrlValues.java @@ -46,7 +46,7 @@ enum OpenSslEvpCtrlValues { this.value = value; } - public int getValue() { + int getValue() { return value; } }