commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject commons-compress git commit: small fixme
Date Fri, 05 Jan 2018 06:33:30 GMT
Repository: commons-compress
Updated Branches:
  refs/heads/COMPRESS-380 53ec58298 -> bca3b08b2


small fixme


Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/bca3b08b
Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/bca3b08b
Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/bca3b08b

Branch: refs/heads/COMPRESS-380
Commit: bca3b08b2779c1bc95d23455bae441dfaf781e83
Parents: 53ec582
Author: Stefan Bodewig <bodewig@apache.org>
Authored: Fri Jan 5 07:33:14 2018 +0100
Committer: Stefan Bodewig <bodewig@apache.org>
Committed: Fri Jan 5 07:33:14 2018 +0100

----------------------------------------------------------------------
 .../commons/compress/archivers/zip/ZipArchiveInputStream.java       | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-compress/blob/bca3b08b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
index 5ea9c0a..ea2b34f 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java
@@ -314,6 +314,7 @@ public class ZipArchiveInputStream extends ArchiveInputStream {
         current.entry.setStreamContiguous(true);
 
         if (current.entry.getCompressedSize() != ArchiveEntry.SIZE_UNKNOWN) {
+            // FIXME this currently leaks bis if the method is not one of the supported ones
             InputStream bis = new BoundedInputStream(in, current.entry.getCompressedSize());
             if (current.entry.getMethod() == ZipMethod.UNSHRINKING.getCode()) {
                 current.in = new UnshrinkingInputStream(bis);


Mime
View raw message