Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6EC60200D69 for ; Wed, 27 Dec 2017 20:03:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6CD81160C23; Wed, 27 Dec 2017 19:03:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8A7B160C10 for ; Wed, 27 Dec 2017 20:03:00 +0100 (CET) Received: (qmail 44472 invoked by uid 500); 27 Dec 2017 19:02:59 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 44463 invoked by uid 99); 27 Dec 2017 19:02:59 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Dec 2017 19:02:59 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 762013A00E7 for ; Wed, 27 Dec 2017 19:02:57 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1819350 - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ test/java/org/apache/commons/beanutils/ test/java/org/apache/commons/beanutils/bugs/ test/java/org... Date: Wed, 27 Dec 2017 19:02:55 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20171227190258.762013A00E7@svn01-us-west.apache.org> archived-at: Wed, 27 Dec 2017 19:03:02 -0000 Author: ggregory Date: Wed Dec 27 19:02:55 2017 New Revision: 1819350 URL: http://svn.apache.org/viewvc?rev=1819350&view=rev Log: Use final. Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/FluentPropertyBeanIntrospectorTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira492TestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira493TestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/other/Jira492IndexedListsSupport.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java Wed Dec 27 19:02:55 2017 @@ -134,7 +134,7 @@ public abstract class BaseDynaBeanMapDec */ public boolean containsValue(final Object value) { final DynaProperty[] properties = getDynaProperties(); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { final String key = propertie.getName(); final Object prop = getDynaBean().get(key); if (value == null) { @@ -163,7 +163,7 @@ public abstract class BaseDynaBeanMapDec public Set> entrySet() { final DynaProperty[] properties = getDynaProperties(); final Set> set = new HashSet>(properties.length); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { final K key = convertKey(propertie.getName()); final Object value = getDynaBean().get(propertie.getName()); set.add(new MapEntry(key, value)); @@ -212,7 +212,7 @@ public abstract class BaseDynaBeanMapDec // Create a Set of the keys final DynaProperty[] properties = getDynaProperties(); Set set = new HashSet(properties.length); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { set.add(convertKey(propertie.getName())); } set = Collections.unmodifiableSet(set); @@ -292,7 +292,7 @@ public abstract class BaseDynaBeanMapDec public Collection values() { final DynaProperty[] properties = getDynaProperties(); final List values = new ArrayList(properties.length); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { final String key = propertie.getName(); final Object value = getDynaBean().get(key); values.add(value); Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java Wed Dec 27 19:02:55 2017 @@ -293,7 +293,7 @@ public class BasicDynaClass implements D this.properties = properties; propertiesMap.clear(); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { propertiesMap.put(propertie.getName(), propertie); } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java Wed Dec 27 19:02:55 2017 @@ -294,7 +294,7 @@ public class BeanMap extends AbstractMap // copy only properties that are readable and writable. If its // not readable, we can't get the value from the old map. If // its not writable, we can't write a value into the new map. - for (Object key : readMethods.keySet()) { + for (final Object key : readMethods.keySet()) { if(getWriteMethod(key) != null) { newMap.put(key, get(key)); } @@ -317,7 +317,7 @@ public class BeanMap extends AbstractMap * @param map the BeanMap whose properties to put */ public void putAllWriteable(final BeanMap map) { - for (Object key : map.readMethods.keySet()) { + for (final Object key : map.readMethods.keySet()) { if (getWriteMethod(key) != null) { this.put(key, map.get(key)); } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java Wed Dec 27 19:02:55 2017 @@ -247,7 +247,7 @@ public class BeanUtilsBean { if (orig instanceof DynaBean) { final DynaProperty[] origDescriptors = ((DynaBean) orig).getDynaClass().getDynaProperties(); - for (DynaProperty origDescriptor : origDescriptors) { + for (final DynaProperty origDescriptor : origDescriptors) { final String name = origDescriptor.getName(); // Need to check isReadable() for WrapDynaBean // (see Jira issue# BEANUTILS-61) @@ -271,7 +271,7 @@ public class BeanUtilsBean { } else /* if (orig is a standard JavaBean) */ { final PropertyDescriptor[] origDescriptors = getPropertyUtils().getPropertyDescriptors(orig); - for (PropertyDescriptor origDescriptor : origDescriptors) { + for (final PropertyDescriptor origDescriptor : origDescriptors) { final String name = origDescriptor.getName(); if ("class".equals(name)) { continue; // No point in trying to set an object's class @@ -499,7 +499,7 @@ public class BeanUtilsBean { if (bean instanceof DynaBean) { final DynaProperty[] descriptors = ((DynaBean) bean).getDynaClass().getDynaProperties(); - for (DynaProperty descriptor : descriptors) { + for (final DynaProperty descriptor : descriptors) { final String name = descriptor.getName(); description.put(name, getProperty(bean, name)); } @@ -507,7 +507,7 @@ public class BeanUtilsBean { final PropertyDescriptor[] descriptors = getPropertyUtils().getPropertyDescriptors(bean); final Class clazz = bean.getClass(); - for (PropertyDescriptor descriptor : descriptors) { + for (final PropertyDescriptor descriptor : descriptors) { final String name = descriptor.getName(); if (getPropertyUtils().getReadMethod(clazz, descriptor) != null) { description.put(name, getProperty(bean, name)); Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java Wed Dec 27 19:02:55 2017 @@ -400,7 +400,7 @@ public class ConstructorUtils { // search through all methods final int paramSize = parameterTypes.length; final Constructor[] ctors = clazz.getConstructors(); - for (Constructor ctor2 : ctors) { + for (final Constructor ctor2 : ctors) { // compare parameters final Class[] ctorParams = ctor2.getParameterTypes(); final int ctorParamSize = ctorParams.length; Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java Wed Dec 27 19:02:55 2017 @@ -75,7 +75,7 @@ class DefaultIntrospectionContext implem "Array with descriptors must not be null!"); } - for (PropertyDescriptor desc : descs) { + for (final PropertyDescriptor desc : descs) { addPropertyDescriptor(desc); } } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java Wed Dec 27 19:02:55 2017 @@ -250,7 +250,7 @@ abstract class JDBCDynaClass implements // Convert this list into the internal data structures we need properties = list.toArray(new DynaProperty[list.size()]); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { propertiesMap.put(propertie.getName(), propertie); } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java Wed Dec 27 19:02:55 2017 @@ -247,7 +247,7 @@ public class LazyDynaList extends ArrayL */ public LazyDynaList(final Object[] array) { super(array.length); - for (Object element : array) { + for (final Object element : array) { add(element); } } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java Wed Dec 27 19:02:55 2017 @@ -124,7 +124,7 @@ public class LazyDynaMap extends LazyDyn public LazyDynaMap(final String name, final DynaProperty[] properties) { this(name, (Map)null); if (properties != null) { - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { add(propertie); } } @@ -285,7 +285,7 @@ public class LazyDynaMap extends LazyDyn final LazyDynaMap lazyMap = new LazyDynaMap(newMap); final DynaProperty[] properties = this.getDynaProperties(); if (properties != null) { - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { lazyMap.add(propertie); } } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java Wed Dec 27 19:02:55 2017 @@ -363,7 +363,7 @@ public class MappedPropertyDescriptor ex // the argument class is itself an interface, and when the argument // class is an abstract class. final Class[] interfaces = initial.getInterfaces(); - for (Class interface1 : interfaces) { + for (final Class interface1 : interfaces) { final Method method = internalGetMethod(interface1, methodName, parameterCount); if (method != null) { return method; Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java Wed Dec 27 19:02:55 2017 @@ -973,7 +973,7 @@ public class MethodUtils { final Method[] methods = clazz.getMethods(); float bestMatchCost = Float.MAX_VALUE; float myCost = Float.MAX_VALUE; - for (Method method2 : methods) { + for (final Method method2 : methods) { if (method2.getName().equals(methodName)) { // log some trace information if (log.isTraceEnabled()) { Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java Wed Dec 27 19:02:55 2017 @@ -279,7 +279,7 @@ public class PropertyUtilsBean { if (orig instanceof DynaBean) { final DynaProperty[] origDescriptors = ((DynaBean) orig).getDynaClass().getDynaProperties(); - for (DynaProperty origDescriptor : origDescriptors) { + for (final DynaProperty origDescriptor : origDescriptors) { final String name = origDescriptor.getName(); if (isReadable(orig, name) && isWriteable(dest, name)) { try { @@ -297,7 +297,7 @@ public class PropertyUtilsBean { } } } else if (orig instanceof Map) { - for (Map.Entry entry : ((Map) orig).entrySet()) { + for (final Map.Entry entry : ((Map) orig).entrySet()) { final String name = (String)entry.getKey(); if (isWriteable(dest, name)) { try { @@ -316,7 +316,7 @@ public class PropertyUtilsBean { } else /* if (orig is a standard JavaBean) */ { final PropertyDescriptor[] origDescriptors = getPropertyDescriptors(orig); - for (PropertyDescriptor origDescriptor : origDescriptors) { + for (final PropertyDescriptor origDescriptor : origDescriptors) { final String name = origDescriptor.getName(); if (isReadable(orig, name) && isWriteable(dest, name)) { try { @@ -368,14 +368,14 @@ public class PropertyUtilsBean { if (bean instanceof DynaBean) { final DynaProperty[] descriptors = ((DynaBean) bean).getDynaClass().getDynaProperties(); - for (DynaProperty descriptor : descriptors) { + for (final DynaProperty descriptor : descriptors) { final String name = descriptor.getName(); description.put(name, getProperty(bean, name)); } } else { final PropertyDescriptor[] descriptors = getPropertyDescriptors(bean); - for (PropertyDescriptor descriptor : descriptors) { + for (final PropertyDescriptor descriptor : descriptors) { final String name = descriptor.getName(); if (descriptor.getReadMethod() != null) { description.put(name, getProperty(bean, name)); Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java Wed Dec 27 19:02:55 2017 @@ -287,7 +287,7 @@ public class RowSetDynaClass extends JDB int cnt = 0; while (resultSet.next() && (limit < 0 || cnt++ < limit) ) { final DynaBean bean = createDynaBean(); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { final String name = propertie.getName(); final Object value = getObject(resultSet, name); bean.set(name, value); Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/WrapDynaClass.java Wed Dec 27 19:02:55 2017 @@ -476,7 +476,7 @@ public class WrapDynaClass implements Dy properties[i]); } int j = regulars.length; - for (Map.Entry entry : mappeds.entrySet()) { + for (final Map.Entry entry : mappeds.entrySet()) { final String name = (String) entry.getKey(); final PropertyDescriptor descriptor = (PropertyDescriptor) entry.getValue(); Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java Wed Dec 27 19:02:55 2017 @@ -453,7 +453,7 @@ public class ArrayConverter extends Abst st.whitespaceChars(delimiter , delimiter); // Set the delimiters st.ordinaryChars('0', '9'); // Needed to turn off numeric flag st.wordChars('0', '9'); // Needed to make part of tokens - for (char allowedChar : allowedChars) { + for (final char allowedChar : allowedChars) { st.ordinaryChars(allowedChar, allowedChar); st.wordChars(allowedChar, allowedChar); } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java Wed Dec 27 19:02:55 2017 @@ -214,13 +214,13 @@ public final class BooleanConverter exte // instead of the less-efficient String.equalsIgnoreCase method. final String stringValue = value.toString().toLowerCase(); - for (String trueString : trueStrings) { + for (final String trueString : trueStrings) { if (trueString.equals(stringValue)) { return type.cast(Boolean.TRUE); } } - for (String falseString : falseStrings) { + for (final String falseString : falseStrings) { if (falseString.equals(stringValue)) { return type.cast(Boolean.FALSE); } Modified: commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java (original) +++ commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java Wed Dec 27 19:02:55 2017 @@ -524,7 +524,7 @@ public abstract class DateTimeConverter */ private Calendar parse(final Class sourceType, final Class targetType, final String value) throws Exception { Exception firstEx = null; - for (String pattern : patterns) { + for (final String pattern : patterns) { try { final DateFormat format = getFormat(pattern); final Calendar calendar = parse(sourceType, targetType, value, format); Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java Wed Dec 27 19:02:55 2017 @@ -287,7 +287,7 @@ public class BasicDynaBeanTestCase exten final DynaProperty pd[] = bean.getDynaClass().getDynaProperties(); assertNotNull("Got descriptors", pd); final int count[] = new int[properties.length]; - for (DynaProperty element : pd) { + for (final DynaProperty element : pd) { final String name = element.getName(); for (int j = 0; j < properties.length; j++) { if (name.equals(properties[j])) { Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java Wed Dec 27 19:02:55 2017 @@ -342,7 +342,7 @@ public class BeanMapTestCase extends Abs // make sure containsKey is working to verify the bean was cloned // ok, and the read methods were properly initialized final Object[] keys = getSampleKeys(); - for (Object key : keys) { + for (final Object key : keys) { assertTrue("Cloned BeanMap should contain the same keys", map2.containsKey(key)); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java Wed Dec 27 19:02:55 2017 @@ -394,7 +394,7 @@ public class BeanUtilsTestCase extends T } // Verify existence of all the properties that should be present - for (String describe : describes) { + for (final String describe : describes) { assertTrue("Property '" + describe + "' is present", map.containsKey(describe)); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java Wed Dec 27 19:02:55 2017 @@ -483,7 +483,7 @@ public class DynaBeanUtilsTestCase exten } // Verify existence of all the properties that should be present - for (String describe : describes) { + for (final String describe : describes) { assertTrue("Property '" + describe + "' is present", map.containsKey(describe)); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java Wed Dec 27 19:02:55 2017 @@ -253,7 +253,7 @@ public class DynaPropertyUtilsTestCase e } // Verify existence of all the properties that should be present - for (String describe : describes) { + for (final String describe : describes) { assertTrue("Property '" + describe + "' is present", map.containsKey(describe)); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/FluentPropertyBeanIntrospectorTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/FluentPropertyBeanIntrospectorTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/FluentPropertyBeanIntrospectorTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/FluentPropertyBeanIntrospectorTestCase.java Wed Dec 27 19:02:55 2017 @@ -105,7 +105,7 @@ public class FluentPropertyBeanIntrospec final Map props = createDescriptorMap( pu.getPropertyDescriptors(CapsBean.class)); - PropertyDescriptor aDescriptor = fetchDescriptor(props, "URI"); + final PropertyDescriptor aDescriptor = fetchDescriptor(props, "URI"); assertNotNull("missing property", aDescriptor); Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java Wed Dec 27 19:02:55 2017 @@ -328,7 +328,7 @@ public class LazyDynaListTestCase extend */ private String findStringProperty(final DynaClass dynaClass) { final DynaProperty[] properties = dynaClass.getDynaProperties(); - for (DynaProperty propertie : properties) { + for (final DynaProperty propertie : properties) { if (propertie.getType() == String.class) { return propertie.getName(); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java Wed Dec 27 19:02:55 2017 @@ -321,7 +321,7 @@ public class PropertyUtilsTestCase exten } // Verify existence of all the properties that should be present - for (String describe : describes) { + for (final String describe : describes) { assertTrue("Property '" + describe + "' is present", map.containsKey(describe)); } @@ -573,7 +573,7 @@ public class PropertyUtilsTestCase exten PropertyUtils.getPropertyDescriptors(bean); assertNotNull("Got descriptors", pd); final int count[] = new int[properties.length]; - for (PropertyDescriptor element : pd) { + for (final PropertyDescriptor element : pd) { final String name = element.getName(); for (int j = 0; j < properties.length; j++) { if (name.equals(properties[j])) { @@ -3992,7 +3992,7 @@ public class PropertyUtilsTestCase exten final PropertyDescriptor pd[] = PropertyUtils.getPropertyDescriptors(bean); - for (String propertie : properties) { + for (final String propertie : properties) { // Identify the property descriptor for this property if (propertie.equals("intIndexed")) { @@ -4050,7 +4050,7 @@ public class PropertyUtilsTestCase exten final PropertyDescriptor pd[] = PropertyUtils.getPropertyDescriptors(bean); - for (String propertie : properties) { + for (final String propertie : properties) { // Identify the property descriptor for this property if (propertie.equals("intIndexed")) { @@ -4503,7 +4503,7 @@ public class PropertyUtilsTestCase exten */ private static PropertyDescriptor findNameDescriptor( final PropertyDescriptor[] desc) { - for (PropertyDescriptor element : desc) { + for (final PropertyDescriptor element : desc) { if (element.getName().equals("name")) { return element; } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java Wed Dec 27 19:02:55 2017 @@ -126,7 +126,7 @@ public class Jira357TestCase extends Tes */ private PropertyDescriptor findDescriptor(final String propertyName, final PropertyDescriptor[] descriptors) { if (descriptors != null) { - for (PropertyDescriptor descriptor : descriptors) { + for (final PropertyDescriptor descriptor : descriptors) { if (propertyName.equals(descriptor.getName())) { return descriptor; } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java Wed Dec 27 19:02:55 2017 @@ -51,8 +51,8 @@ public class Jira422TestCase { */ @BeforeClass public static void assumeSupportsIndexedLists() throws IntrospectionException { - BeanInfo beanInfo = Introspector.getBeanInfo(RootBean.class); - for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) { + final BeanInfo beanInfo = Introspector.getBeanInfo(RootBean.class); + for (final PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) { if (pd.getName().equals("file")) { Assume.assumeTrue("BEANUTILS-492: IndexedPropertyDescriptor no longer supported for java.util.List", pd instanceof IndexedPropertyDescriptor); Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira492TestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira492TestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira492TestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira492TestCase.java Wed Dec 27 19:02:55 2017 @@ -79,12 +79,12 @@ public class Jira492TestCase { @Test public void getPropertyUnconverted() throws Exception { - Object someList = propertyUtils.getProperty(bean, "someList"); + final Object someList = propertyUtils.getProperty(bean, "someList"); assertTrue("Did not retrieve list", someList instanceof List); } public void getArrayProperty() throws Exception { - String[] arr = beanUtils.getArrayProperty(bean, "someList"); + final String[] arr = beanUtils.getArrayProperty(bean, "someList"); assertEquals(2, arr.length); assertEquals("item0", arr[0]); assertEquals("item1", arr[1]); @@ -92,7 +92,7 @@ public class Jira492TestCase { @Test public void describe() throws Exception { - Map described = beanUtils.describe(bean); + final Map described = beanUtils.describe(bean); // Only first element survives as a String assertEquals("item0", described.get("someList")); } @@ -109,10 +109,10 @@ public class Jira492TestCase { @Test public void getPropertyDescriptor() throws Exception { - PropertyDescriptor propDesc = propertyUtils.getPropertyDescriptor(bean, "someList"); + final PropertyDescriptor propDesc = propertyUtils.getPropertyDescriptor(bean, "someList"); if (supportsIndexedLists()) { // Java 7 or earlier? (BEANUTILS-492) - IndexedPropertyDescriptor indexed = (IndexedPropertyDescriptor) propDesc; + final IndexedPropertyDescriptor indexed = (IndexedPropertyDescriptor) propDesc; assertEquals(String.class, indexed.getIndexedReadMethod().getReturnType()); } } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira493TestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira493TestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira493TestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira493TestCase.java Wed Dec 27 19:02:55 2017 @@ -32,11 +32,11 @@ public class Jira493TestCase { @Test public void testIndexedProperties() throws Exception { - LazyDynaBean lazyDynaBean = new LazyDynaBean(); - BeanUtilsBean beanUtilsBean = BeanUtilsBean.getInstance(); + final LazyDynaBean lazyDynaBean = new LazyDynaBean(); + final BeanUtilsBean beanUtilsBean = BeanUtilsBean.getInstance(); beanUtilsBean.setProperty(lazyDynaBean, "x[0]", "x1"); beanUtilsBean.setProperty(lazyDynaBean, "x[1]", "x2"); - Object x = lazyDynaBean.get("x"); + final Object x = lazyDynaBean.get("x"); assertEquals("[x1, x2]", x.toString()); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/other/Jira492IndexedListsSupport.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/other/Jira492IndexedListsSupport.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/other/Jira492IndexedListsSupport.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/other/Jira492IndexedListsSupport.java Wed Dec 27 19:02:55 2017 @@ -37,20 +37,20 @@ public class Jira492IndexedListsSupport public List getSomeList() { return someList; } - public void setSomeList(List someList) { + public void setSomeList(final List someList) { this.someList = someList; } - public void setSomeList(int i, String value) { + public void setSomeList(final int i, final String value) { someList.set(i, value); } - public String getSomeList(int i) { + public String getSomeList(final int i) { return someList.get(i); } } public static boolean supportsIndexedLists() throws IntrospectionException { - BeanInfo beanInfo = Introspector.getBeanInfo(IndexedBean.class); - for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) { + final BeanInfo beanInfo = Introspector.getBeanInfo(IndexedBean.class); + for (final PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) { if (pd.getName().equals("someList")) { return pd instanceof IndexedPropertyDescriptor; } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java Wed Dec 27 19:02:55 2017 @@ -217,7 +217,7 @@ public class ArrayConverterTestCase exte // Test Data final String[] array = new String[] {"10", " 11", "12 ", " 13 "}; final ArrayList list = new ArrayList(); - for (String element : array) { + for (final String element : array) { list.add(element); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java Wed Dec 27 19:02:55 2017 @@ -119,10 +119,10 @@ public class BooleanConverterTestCase ex protected void testConversionValues(final BooleanConverter converter, final String[] trueValues, final String[] falseValues) { - for (String trueValue : trueValues) { + for (final String trueValue : trueValues) { assertEquals(Boolean.TRUE, converter.convert(Boolean.class, trueValue)); } - for (String falseValue : falseValues) { + for (final String falseValue : falseValues) { assertEquals(Boolean.FALSE, converter.convert(Boolean.class, falseValue)); } } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java Wed Dec 27 19:02:55 2017 @@ -56,7 +56,7 @@ public class SqlTimestampConverterTestCa private boolean isUSFormatWithComma() { // BEANUTILS-495 workaround - sometimes Java 9 expects "," in date even if // the format is set to lenient - DateFormat loc = DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT, Locale.US); + final DateFormat loc = DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT, Locale.US); return loc.format(new Date()).contains(","); } Modified: commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1819350&r1=1819349&r2=1819350&view=diff ============================================================================== --- commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java (original) +++ commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java Wed Dec 27 19:02:55 2017 @@ -496,7 +496,7 @@ public class MemoryLeakTestCase { final boolean isNotNull = ref.get() != null; System.out.println("Count " + count+ " " + isNotNull); // debug for Continuum failure - String message = "Your JVM is not releasing SoftReference, try running the testcase with less memory (-Xmx)"; + final String message = "Your JVM is not releasing SoftReference, try running the testcase with less memory (-Xmx)"; Assume.assumeFalse(message, isNotNull); }