commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject commons-rdf git commit: Use final.
Date Mon, 30 Oct 2017 16:23:10 GMT
Repository: commons-rdf
Updated Branches:
  refs/heads/master bfc1e07dc -> d77f8dd45


Use final.

Project: http://git-wip-us.apache.org/repos/asf/commons-rdf/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rdf/commit/d77f8dd4
Tree: http://git-wip-us.apache.org/repos/asf/commons-rdf/tree/d77f8dd4
Diff: http://git-wip-us.apache.org/repos/asf/commons-rdf/diff/d77f8dd4

Branch: refs/heads/master
Commit: d77f8dd4594d471f640d70f7a97ea7241756dd7b
Parents: bfc1e07
Author: Gary Gregory <ggregory@apache.org>
Authored: Mon Oct 30 10:23:07 2017 -0600
Committer: Gary Gregory <ggregory@apache.org>
Committed: Mon Oct 30 10:23:07 2017 -0600

----------------------------------------------------------------------
 .../apache/commons/rdf/api/W3CRDFSyntax.java    |  6 +-
 .../commons/rdf/api/AbstractDatasetTest.java    | 18 +++---
 .../commons/rdf/api/AbstractGraphTest.java      |  8 +--
 .../apache/commons/rdf/api/AbstractRDFTest.java | 10 ++--
 .../apache/commons/rdf/api/RDFSyntaxTest.java   |  2 +-
 .../rdf/integrationtests/JSONLDParsingTest.java | 20 +++----
 .../commons/rdf/jena/impl/AbstractQuadLike.java |  4 +-
 .../commons/rdf/jena/impl/JenaLiteralImpl.java  |  2 +-
 .../rdf/jena/DefaultGraphInQuadTest.java        | 30 +++++-----
 .../rdf/jena/GeneralizedRDFQuadTest.java        | 62 ++++++++++----------
 .../rdf/jena/GeneralizedRDFTripleTest.java      | 34 +++++------
 .../commons/rdf/jsonldjava/JsonLdGraphLike.java |  2 +-
 .../commons/rdf/jsonldjava/JsonLdLiteral.java   |  2 +-
 .../rdf/jsonldjava/JsonLdComparisonTest.java    | 62 ++++++++++----------
 .../commons/rdf/rdf4j/impl/LiteralImpl.java     |  2 +-
 .../rdf/rdf4j/RDF4JMethodOverloadsTest.java     |  2 +-
 .../apache/commons/rdf/simple/LiteralImpl.java  |  2 +-
 .../experimental/AbstractRDFParserTest.java     |  2 +-
 18 files changed, 135 insertions(+), 135 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/W3CRDFSyntax.java
----------------------------------------------------------------------
diff --git a/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/W3CRDFSyntax.java b/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/W3CRDFSyntax.java
index 2c31612..6794fac 100644
--- a/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/W3CRDFSyntax.java
+++ b/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/W3CRDFSyntax.java
@@ -128,7 +128,7 @@ class W3CRDFSyntax implements RDFSyntax {
 
     private final IRI iri;
 
-    private W3CRDFSyntax(String name, String title, String mediaType, String fileExtension,
boolean supportsDataset) {
+    private W3CRDFSyntax(final String name, final String title, final String mediaType, final
String fileExtension, final boolean supportsDataset) {
         this.name = name;
         this.title = title;
         this.mediaType = mediaType.toLowerCase(Locale.ROOT);
@@ -182,14 +182,14 @@ class W3CRDFSyntax implements RDFSyntax {
     }
 
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (obj == this) {
             return true;
         }
         if (!(obj instanceof RDFSyntax)) {
             return false;
         }
-        RDFSyntax other = (RDFSyntax) obj;
+        final RDFSyntax other = (RDFSyntax) obj;
         return mediaType.equals(other.mediaType().toLowerCase(Locale.ROOT));
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractDatasetTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractDatasetTest.java
b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractDatasetTest.java
index 8d0f90a..0bea504 100644
--- a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractDatasetTest.java
+++ b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractDatasetTest.java
@@ -162,8 +162,8 @@ public abstract class AbstractDatasetTest {
 
         // Pattern iteration which should cover multiple graphs.
 
-        Set<Quad> aliceQuads = new HashSet<>();
-        for (Quad aliceQ : dataset.iterate(null, alice, null, null)) {
+        final Set<Quad> aliceQuads = new HashSet<>();
+        for (final Quad aliceQ : dataset.iterate(null, alice, null, null)) {
             aliceQuads.add(aliceQ);
         }
         assertTrue(aliceQuads.contains(factory.createQuad(graph1, alice, name, aliceName)));
@@ -176,7 +176,7 @@ public abstract class AbstractDatasetTest {
 
         // Check the isPrimaryTopicOf statements in the default graph
         int topics = 0;
-        for (Quad topic : dataset.iterate(null, null, isPrimaryTopicOf, null)) {
+        for (final Quad topic : dataset.iterate(null, null, isPrimaryTopicOf, null)) {
             topics++;
             // COMMONSRDF-55: should not be <urn:x-arq:defaultgraph> or similar
             assertFalse(topic.getGraphName().isPresent());
@@ -187,7 +187,7 @@ public abstract class AbstractDatasetTest {
     @Test
     public void streamDefaultGraphNameAlice() throws Exception {
         // null below would match in ANY graph (including default graph)
-        Optional<? extends Quad> aliceTopic = dataset.stream(null, alice, isPrimaryTopicOf,
null).findAny();
+        final Optional<? extends Quad> aliceTopic = dataset.stream(null, alice, isPrimaryTopicOf,
null).findAny();
         assertTrue(aliceTopic.isPresent());
         // COMMONSRDF-55: should not be <urn:x-arq:defaultgraph> or similar
         assertNull(aliceTopic.get().getGraphName().orElse(null));
@@ -198,7 +198,7 @@ public abstract class AbstractDatasetTest {
     @Test
     public void streamDefaultGraphNameByPattern() throws Exception {
         // Explicitly select in only the default graph Optional.empty()
-        Optional<? extends Quad> aliceTopic = dataset.stream(Optional.empty(), null,
null, null).findAny();
+        final Optional<? extends Quad> aliceTopic = dataset.stream(Optional.empty(),
null, null, null).findAny();
         assertTrue(aliceTopic.isPresent());
         // COMMONSRDF-55: should not be <urn:x-arq:defaultgraph> or similar
         assertNull(aliceTopic.get().getGraphName().orElse(null));
@@ -621,7 +621,7 @@ public abstract class AbstractDatasetTest {
         // https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/
 
         // This is similar to the test in AbstractRDFTest, but on a graph
-        Locale defaultLocale = Locale.getDefault();
+        final Locale defaultLocale = Locale.getDefault();
         try {
             Locale.setDefault(Locale.ROOT);
             final Literal lowerROOT = factory.createLiteral("moi", "fi");
@@ -631,7 +631,7 @@ public abstract class AbstractDatasetTest {
             final IRI greeting = factory.createIRI("http://example.com/greeting");
             dataset.add(null, exampleROOT, greeting, mixedROOT);
 
-            Locale turkish = Locale.forLanguageTag("TR");
+            final Locale turkish = Locale.forLanguageTag("TR");
             Locale.setDefault(turkish);
             // If the below assertion fails, then the Turkish
             // locale no longer have this peculiarity that
@@ -698,7 +698,7 @@ public abstract class AbstractDatasetTest {
         assertFalse(dataset.contains(null, null, greeting, null));
     }
 
-    private static Optional<? extends Quad> closableFindAny(Stream<? extends Quad>
stream) {
+    private static Optional<? extends Quad> closableFindAny(final Stream<? extends
Quad> stream) {
         try (Stream<? extends Quad> s = stream) {
             return s.findAny();
         }
@@ -723,7 +723,7 @@ public abstract class AbstractDatasetTest {
         assertTrue(closableFindAny(dataset.stream(null, null, null, mixed)).isPresent());
 
         // Check the quad returned equal a new quad
-        Quad q = closableFindAny(dataset.stream(null, null, null, lower)).get();
+        final Quad q = closableFindAny(dataset.stream(null, null, null, lower)).get();
         assertEquals(q, factory.createQuad(null, example1, greeting, mixed));
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
index 449e1fb..b74a1c5 100644
--- a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
+++ b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
@@ -419,7 +419,7 @@ public abstract class AbstractGraphTest {
         // https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/
 
         // This is similar to the test in AbstractRDFTest, but on a graph
-        Locale defaultLocale = Locale.getDefault();
+        final Locale defaultLocale = Locale.getDefault();
         try {
             Locale.setDefault(Locale.ROOT);
             final Literal lowerROOT = factory.createLiteral("moi", "fi");
@@ -430,7 +430,7 @@ public abstract class AbstractGraphTest {
             final IRI greeting = factory.createIRI("http://example.com/greeting");
             g.add(exampleROOT, greeting, mixedROOT);
 
-            Locale turkish = Locale.forLanguageTag("TR");
+            final Locale turkish = Locale.forLanguageTag("TR");
             Locale.setDefault(turkish);
             // If the below assertion fails, then the Turkish
             // locale no longer have this peculiarity that
@@ -498,7 +498,7 @@ public abstract class AbstractGraphTest {
         assertFalse(graph.contains(null, greeting, null));
     }
 
-    private static Optional<? extends Triple> closableFindAny(Stream<? extends Triple>
stream) {
+    private static Optional<? extends Triple> closableFindAny(final Stream<? extends
Triple> stream) {
         try (Stream<? extends Triple> s = stream) {
             return s.findAny();
         }
@@ -524,7 +524,7 @@ public abstract class AbstractGraphTest {
         assertTrue(closableFindAny(graph.stream(null, null, mixed)).isPresent());
 
         // Check the triples returned equal a new triple
-        Triple t = closableFindAny(graph.stream(null, null, lower)).get();
+        final Triple t = closableFindAny(graph.stream(null, null, lower)).get();
         assertEquals(t, factory.createTriple(example1, greeting, mixed));
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java
b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java
index bb4dc5b..0450f0d 100644
--- a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java
+++ b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java
@@ -195,7 +195,7 @@ public abstract class AbstractRDFTest {
     }
 
 
-    private void assertEqualsBothWays(Object a, Object b) {
+    private void assertEqualsBothWays(final Object a, final Object b) {
         assertEquals(a, b);
         assertEquals(b, a);
         // hashCode must match as well
@@ -255,7 +255,7 @@ public abstract class AbstractRDFTest {
         final Literal lower = factory.createLiteral("Hello", "en-gb");
         final Literal mixed = factory.createLiteral("Hello", "en-GB");
 
-        Literal otherLiteral = new Literal() {
+        final Literal otherLiteral = new Literal() {
             @Override
             public String ntriplesString() {
                 return "Hello@eN-Gb";
@@ -273,7 +273,7 @@ public abstract class AbstractRDFTest {
                 return factory.createIRI("http://www.w3.org/1999/02/22-rdf-syntax-ns#langString");
             }
             @Override
-            public boolean equals(Object obj) {
+            public boolean equals(final Object obj) {
                 throw new RuntimeException("Wrong way comparison of literal");
             }
         };
@@ -291,14 +291,14 @@ public abstract class AbstractRDFTest {
         // "i".toLowerCase() != "i"
         // See also:
         // https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/
-        Locale defaultLocale = Locale.getDefault();
+        final Locale defaultLocale = Locale.getDefault();
         try {
             Locale.setDefault(Locale.ROOT);
             final Literal mixedROOT = factory.createLiteral("moi", "fI");
             final Literal lowerROOT = factory.createLiteral("moi", "fi");
             final Literal upperROOT = factory.createLiteral("moi", "FI");
 
-            Locale turkish = Locale.forLanguageTag("TR");
+            final Locale turkish = Locale.forLanguageTag("TR");
             Locale.setDefault(turkish);
             // If the below assertion fails, then the Turkish
             // locale no longer have this peculiarity that

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java
index 6e298ae..1cd59d3 100644
--- a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java
+++ b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java
@@ -138,7 +138,7 @@ public class RDFSyntaxTest {
 
     @Test
     public void byName() throws Exception {
-        for (RDFSyntax s : RDFSyntax.w3cSyntaxes()) {
+        for (final RDFSyntax s : RDFSyntax.w3cSyntaxes()) {
             assertEquals(s, RDFSyntax.byName(s.name()).get());
         }
     }

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-integration-tests/src/test/java/org/apache/commons/rdf/integrationtests/JSONLDParsingTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-integration-tests/src/test/java/org/apache/commons/rdf/integrationtests/JSONLDParsingTest.java
b/commons-rdf-integration-tests/src/test/java/org/apache/commons/rdf/integrationtests/JSONLDParsingTest.java
index 05a59d1..7f5dbb7 100644
--- a/commons-rdf-integration-tests/src/test/java/org/apache/commons/rdf/integrationtests/JSONLDParsingTest.java
+++ b/commons-rdf-integration-tests/src/test/java/org/apache/commons/rdf/integrationtests/JSONLDParsingTest.java
@@ -97,7 +97,7 @@ public class JSONLDParsingTest {
         // (We'll use these to ensure our HTTPClient dependency works)
     }
 
-    private void checkGraph(Graph g) {
+    private void checkGraph(final Graph g) {
         assertTrue(g.contains(alice, name, aliceWLand));
         assertTrue(g.contains(alice, type, person));
     }
@@ -114,8 +114,8 @@ public class JSONLDParsingTest {
         jenaParse(aliceCached);
     }
 
-    private void jenaParse(URL url) {
-        JenaDataset dataset = new JenaRDF().createDataset();
+    private void jenaParse(final URL url) {
+        final JenaDataset dataset = new JenaRDF().createDataset();
         RDFDataMgr.read(dataset.asJenaDatasetGraph(), url.toExternalForm());
         checkGraph(dataset.getGraph());
     }
@@ -132,12 +132,12 @@ public class JSONLDParsingTest {
         rdf4jParse(aliceCached);
     }
 
-    private void rdf4jParse(URL url) throws IOException {
+    private void rdf4jParse(final URL url) throws IOException {
         Model model;
         try (InputStream in = url.openStream()) {
             model = Rio.parse(in, url.toExternalForm(), RDFFormat.JSONLD);
         }
-        RDF4JGraph graph = new RDF4J().asGraph(model);
+        final RDF4JGraph graph = new RDF4J().asGraph(model);
         checkGraph(graph);
     }
 
@@ -153,12 +153,12 @@ public class JSONLDParsingTest {
         jsonldParse(aliceCached);
     }
 
-    private void jsonldParse(URL url) throws JsonParseException, IOException, JsonLdError
{
-        Object aliceJson = JsonUtils.fromURL(url, JsonUtils.getDefaultHttpClient());
-        JsonLdOptions options = new JsonLdOptions();
+    private void jsonldParse(final URL url) throws JsonParseException, IOException, JsonLdError
{
+        final Object aliceJson = JsonUtils.fromURL(url, JsonUtils.getDefaultHttpClient());
+        final JsonLdOptions options = new JsonLdOptions();
         options.setBase(url.toExternalForm());
-        RDFDataset ds = (RDFDataset) JsonLdProcessor.toRDF(aliceJson);
-        JsonLdGraph graph = new JsonLdRDF().asGraph(ds);
+        final RDFDataset ds = (RDFDataset) JsonLdProcessor.toRDF(aliceJson);
+        final JsonLdGraph graph = new JsonLdRDF().asGraph(ds);
         checkGraph(graph);
     }
 }

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/AbstractQuadLike.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/AbstractQuadLike.java
b/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/AbstractQuadLike.java
index 698f444..b05bf5c 100644
--- a/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/AbstractQuadLike.java
+++ b/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/AbstractQuadLike.java
@@ -79,7 +79,7 @@ abstract class AbstractQuadLike<S extends RDFTerm, P extends RDFTerm,
O extends
          * @return <code>true</code> if the RDFTerm does not indicate a default
          *         graph in Jena
          */
-        public boolean isNotDefaultGraph(RDFTerm graphName) {
+        public boolean isNotDefaultGraph(final RDFTerm graphName) {
             return !(graphName.equals(defaultGraph) || graphName.equals(defaultGraphNodeGenerated));
         }
 
@@ -92,7 +92,7 @@ abstract class AbstractQuadLike<S extends RDFTerm, P extends RDFTerm,
O extends
          * @return <code>true</code> if the RDFTerm does not indicate a default
          *         graph in Jena
          */
-        public boolean isNotDefaultGraphJenaNode(RDFTerm graphName) {
+        public boolean isNotDefaultGraphJenaNode(final RDFTerm graphName) {
             return ! (graphName instanceof JenaRDFTerm) ||
                     ! Quad.isDefaultGraph(((JenaRDFTerm)graphName).asJenaNode());
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaLiteralImpl.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaLiteralImpl.java
b/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaLiteralImpl.java
index 8b981a6..44f3814 100644
--- a/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaLiteralImpl.java
+++ b/commons-rdf-jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaLiteralImpl.java
@@ -39,7 +39,7 @@ class JenaLiteralImpl extends AbstractJenaRDFTerm implements JenaLiteral
{
         }
     }
 
-    private static String lowerCase(String langTag) {
+    private static String lowerCase(final String langTag) {
         return langTag.toLowerCase(Locale.ROOT);
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/DefaultGraphInQuadTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/DefaultGraphInQuadTest.java
b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/DefaultGraphInQuadTest.java
index 3e8e7fa..612958d 100644
--- a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/DefaultGraphInQuadTest.java
+++ b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/DefaultGraphInQuadTest.java
@@ -41,7 +41,7 @@ public class DefaultGraphInQuadTest {
 
     @Test
     public void createFromNull() throws Exception {
-        JenaQuad q = rdf.createQuad(null, example, example, example);
+        final JenaQuad q = rdf.createQuad(null, example, example, example);
         assertFalse(q.getGraphName().isPresent());
         assertTrue(q.asJenaQuad().isDefaultGraph());
         assertEquals(Quad.defaultGraphIRI,  q.asJenaQuad().getGraph());
@@ -49,8 +49,8 @@ public class DefaultGraphInQuadTest {
 
     @Test
     public void createFromDefaultGraphIRI() throws Exception {
-        JenaIRI defaultGraph = (JenaIRI) rdf.asRDFTerm(Quad.defaultGraphIRI);
-        JenaQuad q = rdf.createQuad(defaultGraph, example, example, example);
+        final JenaIRI defaultGraph = (JenaIRI) rdf.asRDFTerm(Quad.defaultGraphIRI);
+        final JenaQuad q = rdf.createQuad(defaultGraph, example, example, example);
         // NOTE: JenaRDF specially recognize this JenaIRI constant,
         // even if this breaks the SHOULD of RDF.createQuad()
         assertTrue(q.asJenaQuad().isDefaultGraph());
@@ -63,8 +63,8 @@ public class DefaultGraphInQuadTest {
     @Test
     public void createFromForeignDefaultGraph() throws Exception {
         // What if <urn:x-arq:DefaultGraph> appear in a non-Jena IRI?
-        IRI foreignDefaultGraph = simpleRDF.createIRI(Quad.defaultGraphIRI.getURI());
-        JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
+        final IRI foreignDefaultGraph = simpleRDF.createIRI(Quad.defaultGraphIRI.getURI());
+        final JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
         // As the IRI was NOT a JenaIRI we preserve it as-is,
         // rather than replacing it with Optional.empty()
         assertTrue(q.asJenaQuad().isDefaultGraph());
@@ -79,8 +79,8 @@ public class DefaultGraphInQuadTest {
     @Test
     public void createFromDefaultGraphNodeGeneratedIRINode() throws Exception {
         // What if <urn:x-arq:DefaultGraphNode> appear as an IRI instance?
-        IRI foreignDefaultGraph = rdf.createIRI(Quad.defaultGraphNodeGenerated.getURI());
-        JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
+        final IRI foreignDefaultGraph = rdf.createIRI(Quad.defaultGraphNodeGenerated.getURI());
+        final JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
         // NOTE: JenaRDF specially recognize this JenaIRI constant,
         // even if this breaks the SHOULD of RDF.createQuad()
         assertTrue(q.asJenaQuad().isDefaultGraph());
@@ -92,8 +92,8 @@ public class DefaultGraphInQuadTest {
     @Test
     public void createFromDefaultGraphNodeGeneratedIRIString() throws Exception {
         // What if <urn:x-arq:DefaultGraphNode> appear in a non-Jena IRI?
-        IRI foreignDefaultGraph = simpleRDF.createIRI(Quad.defaultGraphNodeGenerated.getURI());
-        JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
+        final IRI foreignDefaultGraph = simpleRDF.createIRI(Quad.defaultGraphNodeGenerated.getURI());
+        final JenaQuad q = rdf.createQuad(foreignDefaultGraph, example, example, example);
         // We'll expect JenaRDF to preserve the graph IRI as-is
         assertTrue(q.asJenaQuad().isDefaultGraph());
         assertTrue(q.getGraphName().isPresent()); // INCONSISTENT WITH above
@@ -105,8 +105,8 @@ public class DefaultGraphInQuadTest {
 
     @Test
     public void defaultGraphIRI() throws Exception {
-        Quad jenaQuad = Quad.create(Quad.defaultGraphIRI, exampleJena, exampleJena, exampleJena);
-        JenaQuad q = rdf.asQuad(jenaQuad);
+        final Quad jenaQuad = Quad.create(Quad.defaultGraphIRI, exampleJena, exampleJena,
exampleJena);
+        final JenaQuad q = rdf.asQuad(jenaQuad);
         assertFalse(q.getGraphName().isPresent());
         assertTrue(q.asJenaQuad().isDefaultGraph());
     }
@@ -114,8 +114,8 @@ public class DefaultGraphInQuadTest {
     @Test
     public void defaultGraphNodeGenerated() throws Exception {
         // <urn:x-arq:DefaultGraphNode> might appear in parser output
-        Quad jenaQuad = Quad.create(Quad.defaultGraphNodeGenerated, exampleJena, exampleJena,
exampleJena);
-        JenaQuad q = rdf.asQuad(jenaQuad);
+        final Quad jenaQuad = Quad.create(Quad.defaultGraphNodeGenerated, exampleJena, exampleJena,
exampleJena);
+        final JenaQuad q = rdf.asQuad(jenaQuad);
         assertFalse(q.getGraphName().isPresent());
         assertTrue(q.asJenaQuad().isDefaultGraph());
         // Preserves <urn:x-arq:DefaultGraphNode>
@@ -126,8 +126,8 @@ public class DefaultGraphInQuadTest {
     public void unionGraph() throws Exception {
         // unionGraph shouldn't really appear as a quad except
         // in a pattern
-        Quad jenaQuad = Quad.create(Quad.unionGraph, exampleJena, exampleJena, exampleJena);
-        JenaQuad q = rdf.asQuad(jenaQuad);
+        final Quad jenaQuad = Quad.create(Quad.unionGraph, exampleJena, exampleJena, exampleJena);
+        final JenaQuad q = rdf.asQuad(jenaQuad);
         // But at least we can agree it is NOT (necessarily) in the
         // default graph
         assertFalse(q.asJenaQuad().isDefaultGraph());

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFQuadTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFQuadTest.java
b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFQuadTest.java
index 924768c..5877b82 100644
--- a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFQuadTest.java
+++ b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFQuadTest.java
@@ -32,12 +32,12 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void bnodeProperty() throws Exception {
-        BlankNode b1 = jena.createBlankNode("b1");
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
+        final BlankNode b1 = jena.createBlankNode("b1");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
 
-        JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, b1, ex2, ex3);
+        final JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, b1, ex2, ex3);
         assertEquals(ex1, q.getSubject());
         assertEquals(ex2, q.getObject());
         assertEquals(b1, q.getPredicate()); // it's a bnode!
@@ -47,12 +47,12 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void literalPredicate() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, lit, ex2, ex3);
+        final JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, lit, ex2, ex3);
         assertEquals(ex1, q.getSubject());
         assertEquals(ex2, q.getObject());
         assertEquals(lit, q.getPredicate()); // it's a literal!
@@ -63,12 +63,12 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void literalSubject() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(lit, ex1, ex2, ex3);
+        final JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(lit, ex1, ex2, ex3);
         assertEquals(lit, q.getSubject()); // it's a literal!
         assertEquals(ex1, q.getPredicate());
         assertEquals(ex2, q.getObject());
@@ -78,13 +78,13 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void literalSubjectDefaultGraphGen() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
         // No need to cast to JenaIRI
-        JenaRDFTerm defG = jena.asRDFTerm(Quad.defaultGraphNodeGenerated);
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaRDFTerm defG = jena.asRDFTerm(Quad.defaultGraphNodeGenerated);
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(lit, ex1, ex2, defG);
+        final JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(lit, ex1, ex2, defG);
         assertEquals(lit, q.getSubject()); // it's a literal!
         assertEquals(ex1, q.getPredicate());
         assertEquals(ex2, q.getObject());
@@ -95,12 +95,12 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void asGeneralizedQuad() throws Exception {
-        Node s = NodeFactory.createLiteral("Hello");
-        Node p = NodeFactory.createBlankNode();
-        Node o = NodeFactory.createURI("http://example.com/ex");
-        Node g = Quad.defaultGraphIRI;
-        Quad jq = Quad.create(g, s, p, o);
-        JenaQuadLike<RDFTerm> q = jena.asGeneralizedQuad(jq);
+        final Node s = NodeFactory.createLiteral("Hello");
+        final Node p = NodeFactory.createBlankNode();
+        final Node o = NodeFactory.createURI("http://example.com/ex");
+        final Node g = Quad.defaultGraphIRI;
+        final Quad jq = Quad.create(g, s, p, o);
+        final JenaQuadLike<RDFTerm> q = jena.asGeneralizedQuad(jq);
         assertEquals(jena.createLiteral("Hello"), q.getSubject());
         assertEquals(jena.asRDFTerm(p), q.getPredicate());
         assertEquals(jena.createIRI("http://example.com/ex"), q.getObject());
@@ -109,12 +109,12 @@ public class GeneralizedRDFQuadTest {
 
     @Test
     public void literalGraph() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaIRI ex3 = jena.createIRI("http://example.com/ex3");
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, ex2, ex3, lit);
+        final JenaGeneralizedQuadLike q = jena.createGeneralizedQuad(ex1, ex2, ex3, lit);
         assertEquals(ex1, q.getSubject());
         assertEquals(ex2, q.getPredicate());
         assertEquals(ex3, q.getObject());

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFTripleTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFTripleTest.java
b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFTripleTest.java
index f7bfbf5..687cc78 100644
--- a/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFTripleTest.java
+++ b/commons-rdf-jena/src/test/java/org/apache/commons/rdf/jena/GeneralizedRDFTripleTest.java
@@ -32,11 +32,11 @@ public class GeneralizedRDFTripleTest {
 
     @Test
     public void bnodeProperty() throws Exception {
-        BlankNode b1 = jena.createBlankNode("b1");
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final BlankNode b1 = jena.createBlankNode("b1");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
 
-        JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(ex1, b1, ex2);
+        final JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(ex1, b1, ex2);
         assertEquals(ex1, t.getSubject());
         assertEquals(ex2, t.getObject());
         assertEquals(b1, t.getPredicate()); // it's a bnode!
@@ -45,11 +45,11 @@ public class GeneralizedRDFTripleTest {
 
     @Test
     public void literalPredicate() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(ex1, lit, ex2);
+        final JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(ex1, lit, ex2);
         assertEquals(ex1, t.getSubject());
         assertEquals(ex2, t.getObject());
         assertEquals(lit, t.getPredicate()); // it's a literal!
@@ -59,11 +59,11 @@ public class GeneralizedRDFTripleTest {
 
     @Test
     public void literalSubject() throws Exception {
-        JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
-        JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
-        JenaLiteral lit = jena.createLiteral("Hello");
+        final JenaIRI ex1 = jena.createIRI("http://example.com/ex1");
+        final JenaIRI ex2 = jena.createIRI("http://example.com/ex2");
+        final JenaLiteral lit = jena.createLiteral("Hello");
 
-        JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(lit, ex1, ex2);
+        final JenaGeneralizedTripleLike t = jena.createGeneralizedTriple(lit, ex1, ex2);
         assertEquals(lit, t.getSubject()); // it's a literal!
         assertEquals(ex1, t.getPredicate());
         assertEquals(ex2, t.getObject());
@@ -72,11 +72,11 @@ public class GeneralizedRDFTripleTest {
 
     @Test
     public void asGeneralizedTriple() throws Exception {
-        Node s = NodeFactory.createLiteral("Hello");
-        Node p = NodeFactory.createBlankNode();
-        Node o = NodeFactory.createURI("http://example.com/ex");
-        Triple jt = Triple.create(s, p, o);
-        JenaTripleLike t = jena.asGeneralizedTriple(jt);
+        final Node s = NodeFactory.createLiteral("Hello");
+        final Node p = NodeFactory.createBlankNode();
+        final Node o = NodeFactory.createURI("http://example.com/ex");
+        final Triple jt = Triple.create(s, p, o);
+        final JenaTripleLike t = jena.asGeneralizedTriple(jt);
         assertEquals(jena.createLiteral("Hello"), t.getSubject());
         assertEquals(jena.asRDFTerm(p), t.getPredicate());
         assertEquals(jena.createIRI("http://example.com/ex"), t.getObject());

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdGraphLike.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdGraphLike.java
b/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdGraphLike.java
index b5694f0..ce4b640 100644
--- a/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdGraphLike.java
+++ b/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdGraphLike.java
@@ -209,7 +209,7 @@ abstract class AbstractJsonLdGraphLike<T extends TripleLike> implements
JsonLdGr
                     // Special handling for COMMONSRDF-56, COMMONSRDF-51:
                     // Less efficient wrapper to a Commons RDF Literal so
                     // we can use our RDF 1.1-compliant .equals()
-                    RDFTerm otherObj = factory.asRDFTerm(q.getObject());
+                    final RDFTerm otherObj = factory.asRDFTerm(q.getObject());
                     if (! (object.equals(otherObj))) {
                         return false;
                     }

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdLiteral.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdLiteral.java
b/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdLiteral.java
index 173906f..b0f92e4 100644
--- a/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdLiteral.java
+++ b/commons-rdf-jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdLiteral.java
@@ -39,7 +39,7 @@ class JsonLdLiteralImpl extends JsonLdTermImpl implements JsonLdLiteral
{
         }
     }
 
-    private static String lowerCase(String langTag) {
+    private static String lowerCase(final String langTag) {
         return langTag.toLowerCase(Locale.ROOT);
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdComparisonTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdComparisonTest.java
b/commons-rdf-jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdComparisonTest.java
index 4c1edbc..17adab2 100644
--- a/commons-rdf-jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdComparisonTest.java
+++ b/commons-rdf-jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdComparisonTest.java
@@ -33,47 +33,47 @@ public class JsonLdComparisonTest {
 
     @Test
     public void literalEqual() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
-        JsonLdLiteral lit2 = rdf.createLiteral("Hello");
-        JsonLdLiteral lit3 = rdf.createLiteral("Hello", Types.XSD_STRING);
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdLiteral lit2 = rdf.createLiteral("Hello");
+        final JsonLdLiteral lit3 = rdf.createLiteral("Hello", Types.XSD_STRING);
         assertEquals(lit1, lit2);
         assertEquals(lit1, lit3);
     }
 
     @Test
     public void literalNotEqual() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
-        JsonLdLiteral lit2 = rdf.createLiteral("Hello there");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdLiteral lit2 = rdf.createLiteral("Hello there");
         assertNotEquals(lit1, lit2);
     }
 
     @Test
     public void literalEqualLang() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("Allo Allo", "fr");
-        JsonLdLiteral lit2 = rdf.createLiteral("Allo Allo", "fr");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Allo Allo", "fr");
+        final JsonLdLiteral lit2 = rdf.createLiteral("Allo Allo", "fr");
         assertEquals(lit1, lit2);
     }
 
     @Test
     public void literalNotEqualLang() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello", "en");
-        JsonLdLiteral lit2 = rdf.createLiteral("Hello", "en-us");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello", "en");
+        final JsonLdLiteral lit2 = rdf.createLiteral("Hello", "en-us");
         assertNotEquals(lit1, lit2);
     }
 
     @Test
     public void literalEqualType() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("1", Types.XSD_INTEGER);
-        JsonLdLiteral lit2 = rdf.createLiteral("1", Types.XSD_INTEGER);
+        final JsonLdLiteral lit1 = rdf.createLiteral("1", Types.XSD_INTEGER);
+        final JsonLdLiteral lit2 = rdf.createLiteral("1", Types.XSD_INTEGER);
         assertEquals(lit1, lit2);
     }
 
 
     @Test
     public void literalNotEqualType() throws Exception {
-        JsonLdLiteral lit1 = rdf.createLiteral("1", Types.XSD_INTEGER);
-        JsonLdLiteral lit2 = rdf.createLiteral("2", Types.XSD_INTEGER);
-        JsonLdLiteral lit3 = rdf.createLiteral("1", Types.XSD_STRING);
+        final JsonLdLiteral lit1 = rdf.createLiteral("1", Types.XSD_INTEGER);
+        final JsonLdLiteral lit2 = rdf.createLiteral("2", Types.XSD_INTEGER);
+        final JsonLdLiteral lit3 = rdf.createLiteral("1", Types.XSD_STRING);
 
         assertNotEquals(lit1, lit2);
         assertNotEquals(lit1, lit3);
@@ -82,10 +82,10 @@ public class JsonLdComparisonTest {
 
     @Test
     public void grahContains() throws Exception {
-        JsonLdGraph graph = rdf.createGraph();
-        JsonLdIRI s = rdf.createIRI("http://example.com/s");
-        JsonLdIRI p = rdf.createIRI("http://example.com/p");
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdGraph graph = rdf.createGraph();
+        final JsonLdIRI s = rdf.createIRI("http://example.com/s");
+        final JsonLdIRI p = rdf.createIRI("http://example.com/p");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
 
         graph.add(s, p, lit1);
         assertTrue(graph.contains(s, p, rdf.createLiteral("Hello")));
@@ -97,10 +97,10 @@ public class JsonLdComparisonTest {
 
     @Test
     public void datasetContains() throws Exception {
-        JsonLdDataset dataset = rdf.createDataset();
-        JsonLdIRI s = rdf.createIRI("http://example.com/s");
-        JsonLdIRI p = rdf.createIRI("http://example.com/p");
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdDataset dataset = rdf.createDataset();
+        final JsonLdIRI s = rdf.createIRI("http://example.com/s");
+        final JsonLdIRI p = rdf.createIRI("http://example.com/p");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
 
         dataset.add(null, s, p, lit1);
         assertTrue(dataset.contains(Optional.empty(), s, p, rdf.createLiteral("Hello")));
@@ -112,10 +112,10 @@ public class JsonLdComparisonTest {
 
     @Test
     public void datasetRemove() throws Exception {
-        JsonLdDataset dataset = rdf.createDataset();
-        JsonLdIRI s = rdf.createIRI("http://example.com/s");
-        JsonLdIRI p = rdf.createIRI("http://example.com/p");
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdDataset dataset = rdf.createDataset();
+        final JsonLdIRI s = rdf.createIRI("http://example.com/s");
+        final JsonLdIRI p = rdf.createIRI("http://example.com/p");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
 
         dataset.add(null, s, p, lit1);
         assertTrue(dataset.contains(Optional.empty(), s, p, lit1));
@@ -127,11 +127,11 @@ public class JsonLdComparisonTest {
 
     @Test
     public void datasetStream() throws Exception {
-        JsonLdDataset dataset = rdf.createDataset();
-        JsonLdIRI s = rdf.createIRI("http://example.com/s");
-        JsonLdIRI p = rdf.createIRI("http://example.com/p");
-        JsonLdLiteral lit1 = rdf.createLiteral("Hello");
-        JsonLdLiteral lit2 = rdf.createLiteral("Other");
+        final JsonLdDataset dataset = rdf.createDataset();
+        final JsonLdIRI s = rdf.createIRI("http://example.com/s");
+        final JsonLdIRI p = rdf.createIRI("http://example.com/p");
+        final JsonLdLiteral lit1 = rdf.createLiteral("Hello");
+        final JsonLdLiteral lit2 = rdf.createLiteral("Other");
 
         dataset.add(null, s, p, lit1);
         assertTrue(dataset.stream(Optional.empty(), s, p, lit1).findAny().isPresent());

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/LiteralImpl.java
----------------------------------------------------------------------
diff --git a/commons-rdf-rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/LiteralImpl.java
b/commons-rdf-rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/LiteralImpl.java
index be3b693..c6a9070 100644
--- a/commons-rdf-rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/LiteralImpl.java
+++ b/commons-rdf-rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/impl/LiteralImpl.java
@@ -33,7 +33,7 @@ final class LiteralImpl extends AbstractRDFTerm<org.eclipse.rdf4j.model.Literal>
         super(literal);
     }
 
-    private static String lowerCase(String langTag) {
+    private static String lowerCase(final String langTag) {
         return langTag.toLowerCase(Locale.ROOT);
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/RDF4JMethodOverloadsTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/RDF4JMethodOverloadsTest.java
b/commons-rdf-rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/RDF4JMethodOverloadsTest.java
index 10762e8..ae48ba8 100644
--- a/commons-rdf-rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/RDF4JMethodOverloadsTest.java
+++ b/commons-rdf-rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/RDF4JMethodOverloadsTest.java
@@ -33,7 +33,7 @@ public class RDF4JMethodOverloadsTest {
 
     @Test
     public void testAsRDFTermOverloads() {
-        RDF4J rdf4J = new RDF4J();
+        final RDF4J rdf4J = new RDF4J();
 
         final ValueFactory valueFactory = SimpleValueFactory.getInstance();
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java
----------------------------------------------------------------------
diff --git a/commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java
b/commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java
index 70a1e51..508b960 100644
--- a/commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java
+++ b/commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java
@@ -116,7 +116,7 @@ final class LiteralImpl implements Literal, SimpleRDF.SimpleRDFTerm {
         return Objects.hash(lexicalForm, dataType, languageTag);
     }
 
-    private static String lowerCase(String langTag) {
+    private static String lowerCase(final String langTag) {
         return langTag.toLowerCase(Locale.ROOT);
     }
 

http://git-wip-us.apache.org/repos/asf/commons-rdf/blob/d77f8dd4/commons-rdf-simple/src/test/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParserTest.java
----------------------------------------------------------------------
diff --git a/commons-rdf-simple/src/test/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParserTest.java
b/commons-rdf-simple/src/test/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParserTest.java
index a43c2eb..88bf5cc 100644
--- a/commons-rdf-simple/src/test/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParserTest.java
+++ b/commons-rdf-simple/src/test/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParserTest.java
@@ -66,7 +66,7 @@ public class AbstractRDFParserTest {
         // doesn't actually read anything
 
         // If supported, we'll make a symbolic link
-        Path symlinks = Files.createTempDirectory("symlinked");
+        final Path symlinks = Files.createTempDirectory("symlinked");
         try {
         	symlink = Files.createSymbolicLink(
         				symlinks.resolve("linked.ttl"), testNt);


Mime
View raw message