Return-Path: <commits-return-59261-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 4CB46200D0F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 29 Sep 2017 17:06:07 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 4B5921609C5; Fri, 29 Sep 2017 15:06:07 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 91B0E1609D1
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 29 Sep 2017 17:06:06 +0200 (CEST)
Received: (qmail 67512 invoked by uid 500); 29 Sep 2017 15:06:05 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 67503 invoked by uid 99); 29 Sep 2017 15:06:05 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 15:06:05 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9081FF570F; Fri, 29 Sep 2017 15:06:05 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: pascalschumacher@apache.org
To: commits@commons.apache.org
Message-Id: <3c76edebff5a431fa8377e04420cc465@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [lang] Boolean comparisons in CharRange (closes #289)
Date: Fri, 29 Sep 2017 15:06:05 +0000 (UTC)
archived-at: Fri, 29 Sep 2017 15:06:07 -0000

Repository: commons-lang
Updated Branches:
  refs/heads/master 1406f2a4f -> 7076b7408


Boolean comparisons in CharRange (closes #289)

Cleaned up comparisons to false to just use the boolean negation
operator (!).


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/7076b740
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/7076b740
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/7076b740

Branch: refs/heads/master
Commit: 7076b7408f06bc8a277f58e7bb6c2ec3372d5d6f
Parents: 1406f2a
Author: Allon Mureinik <amureini@redhat.com>
Authored: Fri Sep 22 05:35:51 2017 +0300
Committer: pascalschumacher <pascalschumacher@gmx.net>
Committed: Fri Sep 29 17:05:31 2017 +0200

----------------------------------------------------------------------
 src/main/java/org/apache/commons/lang3/CharRange.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7076b740/src/main/java/org/apache/commons/lang3/CharRange.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/CharRange.java b/src/main/java/org/apache/commons/lang3/CharRange.java
index b395306..6a416bb 100644
--- a/src/main/java/org/apache/commons/lang3/CharRange.java
+++ b/src/main/java/org/apache/commons/lang3/CharRange.java
@@ -206,7 +206,7 @@ final class CharRange implements Iterable<Character>, Serializable {
         if (obj == this) {
             return true;
         }
-        if (obj instanceof CharRange == false) {
+        if (!(obj instanceof CharRange)) {
             return false;
         }
         final CharRange other = (CharRange) obj;
@@ -335,7 +335,7 @@ final class CharRange implements Iterable<Character>, Serializable {
          */
         @Override
         public Character next() {
-            if (hasNext == false) {
+            if (!hasNext) {
                 throw new NoSuchElementException();
             }
             final char cur = current;