commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pascalschumac...@apache.org
Subject [lang] Clean up findbugs exclusions for old XYZRange classes (closes #287)
Date Wed, 20 Sep 2017 20:10:46 GMT
Repository: commons-lang
Updated Branches:
  refs/heads/master ff4967536 -> 466244ce3


Clean up findbugs exclusions for old XYZRange classes (closes #287)

Commit 56e830a removed all the old XYZRange classes from
org.apache.lang3.math, and left only the generic Range<T> class.

This patch removes the left-over findbugs exclusions for those
classes.


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/466244ce
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/466244ce
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/466244ce

Branch: refs/heads/master
Commit: 466244ce3d175ad97c2858e54152d5bb5243bcd5
Parents: ff49675
Author: Allon Mureinik <amureini@redhat.com>
Authored: Wed Sep 20 19:52:03 2017 +0300
Committer: pascalschumacher <pascalschumacher@gmx.net>
Committed: Wed Sep 20 22:10:16 2017 +0200

----------------------------------------------------------------------
 findbugs-exclude-filter.xml | 28 ----------------------------
 1 file changed, 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/466244ce/findbugs-exclude-filter.xml
----------------------------------------------------------------------
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index 23dddbd..0e710c4 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -80,34 +80,6 @@
     <Bug pattern="SF_SWITCH_FALLTHROUGH" />
   </Match>
 
-  <!-- Reason: hashCode is lazily loaded in Range classes -->
-  <!-- TODO: Work out why regex didn't work here -->
-  <Match>
-    <Class name="org.apache.commons.lang3.math.DoubleRange" />
-    <Field name="hashCode" />
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
-  </Match>
-  <Match>
-    <Class name="org.apache.commons.lang3.math.FloatRange" />
-    <Field name="hashCode" />
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
-  </Match>
-  <Match>
-    <Class name="org.apache.commons.lang3.math.IntRange" />
-    <Field name="hashCode" />
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
-  </Match>
-  <Match>
-    <Class name="org.apache.commons.lang3.math.LongRange" />
-    <Field name="hashCode" />
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
-  </Match>
-  <Match>
-    <Class name="org.apache.commons.lang3.math.NumberRange" />
-    <Field name="hashCode" />
-    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
-  </Match>
-
   <!-- Reason: toProperString is lazily loaded -->
   <Match>
     <Class name="org.apache.commons.lang3.math.Fraction" />


Mime
View raw message