commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1806245 - in /commons/proper/digester/trunk: core/src/main/java/org/apache/commons/digester3/ core/src/main/java/org/apache/commons/digester3/plugins/ core/src/main/java/org/apache/commons/digester3/substitution/ core/src/test/java/org/apa...
Date Fri, 25 Aug 2017 21:53:28 GMT
Author: ggregory
Date: Fri Aug 25 21:53:28 2017
New Revision: 1806245

URL: http://svn.apache.org/viewvc?rev=1806245&view=rev
Log:
Add final modifier to private fields.

Modified:
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/PatternRuleMatcher.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/RegexRules.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/WithDefaultsRulesWrapper.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/Declaration.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
    commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/substitution/VariableAttributes.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Box.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Employee.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestBean.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestRule.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/Container.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/TestConfigurablePluginAttributes.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/VariableExpansionTestCase.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/DigesterPatternStackTest.java
    commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/ObjectTestImpl.java
    commons/proper/digester/trunk/examples/api/catalog/src/main/java/org/apache/commons/digester3/examples/api/catalog/Book.java
    commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/Row.java
    commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/RowInserterRule.java
    commons/proper/digester/trunk/examples/plugins/pipeline/src/main/java/org/apache/commons/digester3/examples/plugins/pipeline/CompoundTransform.java
    commons/proper/digester/trunk/examples/xmlrules/addressbook/src/main/java/org/apache/commons/digester3/examples/xmlrules/addressbook/Person.java

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
Fri Aug 25 21:53:28 2017
@@ -156,7 +156,7 @@ public class ExtendedBaseRules
      * The decision algorithm used (unfortunately) doesn't preserve the entry order. This
map is used by a comparator
      * which orders the list of matches before it's returned. This map stores the entry number
keyed by the rule.
      */
-    private Map<Rule, Integer> order = new HashMap<Rule, Integer>();
+    private final Map<Rule, Integer> order = new HashMap<Rule, Integer>();
 
     // --------------------------------------------------------- Public Methods
 

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java
Fri Aug 25 21:53:28 2017
@@ -43,7 +43,7 @@ public class FactoryCreateRule
     // ----------------------------------------------------------- Fields
 
     /** Should exceptions thrown by the factory be ignored? */
-    private boolean ignoreCreateExceptions;
+    private final boolean ignoreCreateExceptions;
 
     /** Stock to manage */
     private Stack<Boolean> exceptionIgnoredStack;

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/PatternRuleMatcher.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/PatternRuleMatcher.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/PatternRuleMatcher.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/PatternRuleMatcher.java
Fri Aug 25 21:53:28 2017
@@ -32,7 +32,7 @@ final class PatternRuleMatcher
 
     private final String pattern;
 
-    private String namespaceURI;
+    private final String namespaceURI;
 
     public PatternRuleMatcher( String pattern )
     {

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/RegexRules.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/RegexRules.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/RegexRules.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/RegexRules.java
Fri Aug 25 21:53:28 2017
@@ -43,7 +43,7 @@ public class RegexRules
     // --------------------------------------------------------- Fields
 
     /** All registered <code>Rule</code>'s */
-    private ArrayList<RegisteredRule> registeredRules = new ArrayList<RegisteredRule>();
+    private final ArrayList<RegisteredRule> registeredRules = new ArrayList<RegisteredRule>();
 
     /** The regex strategy used by this RegexRules */
     private RegexMatcher matcher;

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java
Fri Aug 25 21:53:28 2017
@@ -108,7 +108,7 @@ public class SetNestedPropertiesRule
 
     private boolean allowUnknownChildElements = false;
 
-    private HashMap<String, String> elementNames = new HashMap<String, String>();
+    private final HashMap<String, String> elementNames = new HashMap<String, String>();
 
     // ----------------------------------------------------------- Constructors
 
@@ -334,9 +334,9 @@ public class SetNestedPropertiesRule
 
         private Rules decoratedRules = null;
 
-        private ArrayList<Rule> rules = new ArrayList<Rule>( 1 );
+        private final ArrayList<Rule> rules = new ArrayList<Rule>( 1 );
 
-        private AnyChildRule rule;
+        private final AnyChildRule rule;
 
         public AnyChildRules( AnyChildRule rule )
         {

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/WithDefaultsRulesWrapper.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/WithDefaultsRulesWrapper.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/WithDefaultsRulesWrapper.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/WithDefaultsRulesWrapper.java
Fri Aug 25 21:53:28 2017
@@ -62,13 +62,13 @@ public class WithDefaultsRulesWrapper
     // --------------------------------------------------------- Fields
 
     /** The Rules implementation that this class wraps. */
-    private Rules wrappedRules;
+    private final Rules wrappedRules;
 
     /** Rules to be fired when the wrapped implementations returns none. */
-    private List<Rule> defaultRules = new ArrayList<Rule>();
+    private final List<Rule> defaultRules = new ArrayList<Rule>();
 
     /** All rules (preserves order in which they were originally added) */
-    private List<Rule> allRules = new ArrayList<Rule>();
+    private final List<Rule> allRules = new ArrayList<Rule>();
 
     // --------------------------------------------------------- Constructor
 

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/Declaration.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/Declaration.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/Declaration.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/Declaration.java
Fri Aug 25 21:53:28 2017
@@ -37,13 +37,13 @@ public class Declaration
     private Class<?> pluginClass;
 
     /** The name of the class of the object to be instantiated. */
-    private String pluginClassName;
+    private final String pluginClassName;
 
     /** See {@link #setId}. */
     private String id;
 
     /** See {@link #setProperties}. */
-    private Properties properties = new Properties();
+    private final Properties properties = new Properties();
 
     /** See {@link #init}. */
     private boolean initialized = false;

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java
Fri Aug 25 21:53:28 2017
@@ -39,10 +39,10 @@ public class PluginManager
 {
 
     /** Map of classname->Declaration */
-    private HashMap<String, Declaration> declarationsByClass = new HashMap<String,
Declaration>();
+    private final HashMap<String, Declaration> declarationsByClass = new HashMap<String,
Declaration>();
 
     /** Map of id->Declaration */
-    private HashMap<String, Declaration> declarationsById = new HashMap<String,
Declaration>();
+    private final HashMap<String, Declaration> declarationsById = new HashMap<String,
Declaration>();
 
     /** the parent manager to which this one may delegate lookups. */
     private PluginManager parent;
@@ -50,7 +50,7 @@ public class PluginManager
     /**
      * The object containing data that should only exist once for each Digester instance.
      */
-    private PluginContext pluginContext;
+    private final PluginContext pluginContext;
 
     // ------------------- constructors ---------------------------------------
 

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/plugins/PluginRules.java
Fri Aug 25 21:53:28 2017
@@ -65,7 +65,7 @@ public class PluginRules
     private Rules decoratedRules;
 
     /** Object which contains information about all known plugins. */
-    private PluginManager pluginManager;
+    private final PluginManager pluginManager;
 
     /**
      * The path below which this rules object has responsibility. For paths shorter than
or equal the mountpoint, the

Modified: commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/substitution/VariableAttributes.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/substitution/VariableAttributes.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/substitution/VariableAttributes.java
(original)
+++ commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/substitution/VariableAttributes.java
Fri Aug 25 21:53:28 2017
@@ -35,7 +35,7 @@ public class VariableAttributes
 {
 
     // list of mapped attributes.
-    private ArrayList<String> values = new ArrayList<String>( 10 );
+    private final ArrayList<String> values = new ArrayList<String>( 10 );
 
     private Attributes attrs;
 

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Box.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Box.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Box.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Box.java
Fri Aug 25 21:53:28 2017
@@ -28,7 +28,7 @@ public class Box
 {
     private String id;
 
-    private List<Box> children = new LinkedList<Box>();
+    private final List<Box> children = new LinkedList<Box>();
 
     public Box()
     {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Employee.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Employee.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Employee.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/Employee.java
Fri Aug 25 21:53:28 2017
@@ -39,7 +39,7 @@ public class Employee
         setLastName( lastName );
     }
 
-    private ArrayList<Address> addresses = new ArrayList<Address>();
+    private final ArrayList<Address> addresses = new ArrayList<Address>();
 
     public void addAddress( Address address )
     {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java
Fri Aug 25 21:53:28 2017
@@ -42,7 +42,7 @@ public class ObjectParamRuleTestCase
 
     // ------------------------------------------------ Individual Test Methods
 
-    private StringBuilder sb =
+    private final StringBuilder sb =
         new StringBuilder().append( "<arraylist><A/><B/><C/><D
desc=\"the fourth\"/><E/></arraylist>" );
 
     /**

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestBean.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestBean.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestBean.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestBean.java
Fri Aug 25 21:53:28 2017
@@ -130,7 +130,7 @@ public class TestBean
         this.intArray = intArray;
     }
 
-    private int intIndexed[] = { 0, 10, 20, 30, 40 };
+    private final int intIndexed[] = { 0, 10, 20, 30, 40 };
 
     public int getIntIndexed( int index )
     {
@@ -272,7 +272,7 @@ public class TestBean
         this.stringArray = stringArray;
     }
 
-    private String stringIndexed[] = { "String 0", "String 1", "String 2", "String 3", "String
4" };
+    private final String stringIndexed[] = { "String 0", "String 1", "String 2", "String
3", "String 4" };
 
     public String getStringIndexed( int index )
     {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestRule.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestRule.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/TestRule.java
Fri Aug 25 21:53:28 2017
@@ -40,7 +40,7 @@ public class TestRule
     // ----------------------------------------------------- Instance Variables
 
     /** String identifing this particular <code>TestRule</code> */
-    private String identifier;
+    private final String identifier;
 
     /** Used when testing body text */
     private String bodyText;

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/binder/BinderClassLoaderTestCase.java
Fri Aug 25 21:53:28 2017
@@ -49,7 +49,7 @@ import org.junit.Test;
 public final class BinderClassLoaderTestCase
 {
 
-    private BinderClassLoader classLoader = createBinderClassLoader( new ExtendedClassLoader()
);
+    private final BinderClassLoader classLoader = createBinderClassLoader( new ExtendedClassLoader()
);
 
     @Test
     public void loadBoolean()

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/Container.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/Container.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/Container.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/Container.java
Fri Aug 25 21:53:28 2017
@@ -24,7 +24,7 @@ import java.util.LinkedList;
 public class Container
     implements Widget
 {
-    private LinkedList<Widget> children = new LinkedList<Widget>();
+    private final LinkedList<Widget> children = new LinkedList<Widget>();
 
     public Container()
     {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/TestConfigurablePluginAttributes.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/TestConfigurablePluginAttributes.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/TestConfigurablePluginAttributes.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/plugins/TestConfigurablePluginAttributes.java
Fri Aug 25 21:53:28 2017
@@ -219,9 +219,9 @@ public class TestConfigurablePluginAttri
 
     public static class MultiContainer
     {
-        private LinkedList<Widget> widgets = new LinkedList<Widget>();
+        private final LinkedList<Widget> widgets = new LinkedList<Widget>();
 
-        private LinkedList<Widget> gadgets = new LinkedList<Widget>();
+        private final LinkedList<Widget> gadgets = new LinkedList<Widget>();
 
         public MultiContainer()
         {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/CompoundSubstitutorTestCase.java
Fri Aug 25 21:53:28 2017
@@ -37,15 +37,15 @@ public final class CompoundSubstitutorTe
         extends Substitutor
     {
 
-        private String newBodyText;
+        private final String newBodyText;
 
-        private String uri;
+        private final String uri;
 
-        private String localName;
+        private final String localName;
 
-        private String type;
+        private final String type;
 
-        private String value;
+        private final String value;
 
         public SubstitutorStub( String bodyText, String uri, String localName, String type,
String value )
         {

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/VariableExpansionTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/VariableExpansionTestCase.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/VariableExpansionTestCase.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/substitution/VariableExpansionTestCase.java
Fri Aug 25 21:53:28 2017
@@ -45,7 +45,7 @@ public class VariableExpansionTestCase
     // --------------------------------------------------- Overall Test Methods
 
     // method used in tests4
-    private LinkedList<SimpleTestBean> simpleTestBeans = new LinkedList<SimpleTestBean>();
+    private final LinkedList<SimpleTestBean> simpleTestBeans = new LinkedList<SimpleTestBean>();
 
     public void addSimpleTestBean( SimpleTestBean bean )
     {
@@ -54,7 +54,7 @@ public class VariableExpansionTestCase
 
     // implementation of source shared by the variable expander and
     // is updatable during digesting via an Ant-like property element
-    private HashMap<String, Object> mutableSource = new HashMap<String, Object>();
+    private final HashMap<String, Object> mutableSource = new HashMap<String, Object>();
 
     /**
      * Used in test case "testExpansionWithMutableSource", where the set of variables available
to be substituted into

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/DigesterPatternStackTest.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/DigesterPatternStackTest.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/DigesterPatternStackTest.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/DigesterPatternStackTest.java
Fri Aug 25 21:53:28 2017
@@ -31,7 +31,7 @@ import org.junit.Test;
 public class DigesterPatternStackTest
 {
 
-    private PatternStack patternStack = new PatternStack();
+    private final PatternStack patternStack = new PatternStack();
 
     @Before
     public void setUp()

Modified: commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/ObjectTestImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/ObjectTestImpl.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/ObjectTestImpl.java
(original)
+++ commons/proper/digester/trunk/core/src/test/java/org/apache/commons/digester3/xmlrules/ObjectTestImpl.java
Fri Aug 25 21:53:28 2017
@@ -31,7 +31,7 @@ import java.util.HashMap;
 public class ObjectTestImpl
 {
 
-    private ArrayList<Object> children = new ArrayList<Object>();
+    private final ArrayList<Object> children = new ArrayList<Object>();
 
     private String value = "";
 
@@ -39,7 +39,7 @@ public class ObjectTestImpl
 
     private String property = "";
 
-    private HashMap<String, String> mapValue = new HashMap<String, String>();
+    private final HashMap<String, String> mapValue = new HashMap<String, String>();
 
     private boolean pushed = false;
 

Modified: commons/proper/digester/trunk/examples/api/catalog/src/main/java/org/apache/commons/digester3/examples/api/catalog/Book.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/examples/api/catalog/src/main/java/org/apache/commons/digester3/examples/api/catalog/Book.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/examples/api/catalog/src/main/java/org/apache/commons/digester3/examples/api/catalog/Book.java
(original)
+++ commons/proper/digester/trunk/examples/api/catalog/src/main/java/org/apache/commons/digester3/examples/api/catalog/Book.java
Fri Aug 25 21:53:28 2017
@@ -24,7 +24,7 @@ public class Book
     implements Item
 {
 
-    private String isbn;
+    private final String isbn;
 
     private String title;
 

Modified: commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/Row.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/Row.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/Row.java
(original)
+++ commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/Row.java
Fri Aug 25 21:53:28 2017
@@ -37,7 +37,7 @@ public class Row
      */
     public static class Column
     {
-        private String name, value;
+        private final String name, value;
 
         public Column( String name, String value )
         {
@@ -56,7 +56,7 @@ public class Row
         }
     }
 
-    private LinkedList<Column> columns = new LinkedList<Column>();
+    private final LinkedList<Column> columns = new LinkedList<Column>();
 
     public Row()
     {

Modified: commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/RowInserterRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/RowInserterRule.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/RowInserterRule.java
(original)
+++ commons/proper/digester/trunk/examples/api/dbinsert/src/main/java/org/apache/commons/digester3/examples/api/dbinsert/RowInserterRule.java
Fri Aug 25 21:53:28 2017
@@ -29,7 +29,7 @@ public class RowInserterRule
     extends Rule
 {
 
-    private Connection conn;
+    private final Connection conn;
 
     public RowInserterRule( Connection conn )
     {

Modified: commons/proper/digester/trunk/examples/plugins/pipeline/src/main/java/org/apache/commons/digester3/examples/plugins/pipeline/CompoundTransform.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/examples/plugins/pipeline/src/main/java/org/apache/commons/digester3/examples/plugins/pipeline/CompoundTransform.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/examples/plugins/pipeline/src/main/java/org/apache/commons/digester3/examples/plugins/pipeline/CompoundTransform.java
(original)
+++ commons/proper/digester/trunk/examples/plugins/pipeline/src/main/java/org/apache/commons/digester3/examples/plugins/pipeline/CompoundTransform.java
Fri Aug 25 21:53:28 2017
@@ -34,7 +34,7 @@ public class CompoundTransform
     implements Transform
 {
 
-    private LinkedList<Transform> transforms = new LinkedList<Transform>();
+    private final LinkedList<Transform> transforms = new LinkedList<Transform>();
 
     public void addTransform( Transform transform )
     {

Modified: commons/proper/digester/trunk/examples/xmlrules/addressbook/src/main/java/org/apache/commons/digester3/examples/xmlrules/addressbook/Person.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/examples/xmlrules/addressbook/src/main/java/org/apache/commons/digester3/examples/xmlrules/addressbook/Person.java?rev=1806245&r1=1806244&r2=1806245&view=diff
==============================================================================
--- commons/proper/digester/trunk/examples/xmlrules/addressbook/src/main/java/org/apache/commons/digester3/examples/xmlrules/addressbook/Person.java
(original)
+++ commons/proper/digester/trunk/examples/xmlrules/addressbook/src/main/java/org/apache/commons/digester3/examples/xmlrules/addressbook/Person.java
Fri Aug 25 21:53:28 2017
@@ -33,9 +33,9 @@ public class Person
 
     private String name;
 
-    private HashMap<String, String> emails = new HashMap<String, String>();
+    private final HashMap<String, String> emails = new HashMap<String, String>();
 
-    private List<Address> addresses = new ArrayList<Address>();
+    private final List<Address> addresses = new ArrayList<Address>();
 
     /**
      * A unique id for this person. Note that the Digester automatically converts the id
to an integer.



Mime
View raw message