Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CDCEB200CE1 for ; Fri, 7 Jul 2017 04:05:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CC569167E5D; Fri, 7 Jul 2017 02:05:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 27578167E5E for ; Fri, 7 Jul 2017 04:05:48 +0200 (CEST) Received: (qmail 74382 invoked by uid 500); 7 Jul 2017 02:05:38 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 72944 invoked by uid 99); 7 Jul 2017 02:05:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Jul 2017 02:05:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 575C7E78B0; Fri, 7 Jul 2017 02:05:37 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: thecarlhall@apache.org To: commits@commons.apache.org Date: Fri, 07 Jul 2017 02:05:59 -0000 Message-Id: In-Reply-To: <61130dcfb8c9434aba8ddd07d7d7485c@git.apache.org> References: <61130dcfb8c9434aba8ddd07d7d7485c@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [24/50] commons-dbutils git commit: Don't swallow test errors silently. Test works when running mvn clean test, so remove try-catch-block. archived-at: Fri, 07 Jul 2017 02:05:49 -0000 Don't swallow test errors silently. Test works when running mvn clean test, so remove try-catch-block. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/dbutils/trunk@1630537 13f79535-47bb-0310-9956-ffa450edef68 Project: http://git-wip-us.apache.org/repos/asf/commons-dbutils/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-dbutils/commit/bdf0b337 Tree: http://git-wip-us.apache.org/repos/asf/commons-dbutils/tree/bdf0b337 Diff: http://git-wip-us.apache.org/repos/asf/commons-dbutils/diff/bdf0b337 Branch: refs/heads/master Commit: bdf0b337ea209c7e3fd7de52f4da3b1afa0678aa Parents: 82bb44f Author: Benedikt Ritter Authored: Thu Oct 9 17:22:05 2014 +0000 Committer: Benedikt Ritter Committed: Thu Oct 9 17:22:05 2014 +0000 ---------------------------------------------------------------------- .../apache/commons/dbutils/QueryLoaderTest.java | 23 +++++++------------- 1 file changed, 8 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-dbutils/blob/bdf0b337/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java b/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java index c4f42b6..957b309 100644 --- a/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java +++ b/src/test/java/org/apache/commons/dbutils/QueryLoaderTest.java @@ -28,22 +28,15 @@ public class QueryLoaderTest extends BaseTestCase { "/org/apache/commons/dbutils/TestQueries.properties"; public void testLoad() throws IOException { - try { - QueryLoader loader = QueryLoader.instance(); - Map q = loader.load(QUERIES); - Map q2 = loader.load(QUERIES); - assertTrue(q == q2); // pointer comparison should return true - assertEquals("SELECT * FROM SomeTable", q.get("test.query")); + QueryLoader loader = QueryLoader.instance(); + Map q = loader.load(QUERIES); + Map q2 = loader.load(QUERIES); + assertTrue(q == q2); // pointer comparison should return true + assertEquals("SELECT * FROM SomeTable", q.get("test.query")); - loader.unload(QUERIES); - Map q3 = loader.load(QUERIES); - assertTrue(q != q3); // pointer comparison should return false - - } catch (IllegalArgumentException e) { - // TODO Figure out why the Maven build can't find the properties - // file. The tests run fine in Eclipse so just catch this - // exception for now. - } + loader.unload(QUERIES); + Map q3 = loader.load(QUERIES); + assertTrue(q != q3); // pointer comparison should return false } }