commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject commons-compress git commit: explain why we still need to shadow ZipEntry's size attribute
Date Wed, 26 Jul 2017 07:03:47 GMT
Repository: commons-compress
Updated Branches:
  refs/heads/master 317ea114c -> 246addb22


explain why we still need to shadow ZipEntry's size attribute


Project: http://git-wip-us.apache.org/repos/asf/commons-compress/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-compress/commit/246addb2
Tree: http://git-wip-us.apache.org/repos/asf/commons-compress/tree/246addb2
Diff: http://git-wip-us.apache.org/repos/asf/commons-compress/diff/246addb2

Branch: refs/heads/master
Commit: 246addb226a9870bcde9413476f09d34d06bef83
Parents: 317ea11
Author: Stefan Bodewig <bodewig@apache.org>
Authored: Wed Jul 26 09:03:13 2017 +0200
Committer: Stefan Bodewig <bodewig@apache.org>
Committed: Wed Jul 26 09:03:13 2017 +0200

----------------------------------------------------------------------
 .../commons/compress/archivers/zip/ZipArchiveEntry.java       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-compress/blob/246addb2/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
index 69e4990..ba88a2f 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntry.java
@@ -74,8 +74,11 @@ public class ZipArchiveEntry extends java.util.zip.ZipEntry
     /**
      * The {@link java.util.zip.ZipEntry#setSize} method in the base
      * class throws an IllegalArgumentException if the size is bigger
-     * than 2GB for Java versions < 7.  Need to keep our own size
-     * information for Zip64 support.
+     * than 2GB for Java versions &lt; 7 and even in Java 7+ if the
+     * implementation in java.util.zip doesn't support Zip64 itself
+     * (it is an optional feature).
+     *
+     * <p>We need to keep our own size information for Zip64 support.</p>
      */
     private long size = SIZE_UNKNOWN;
 


Mime
View raw message