Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CFE37200C5E for ; Fri, 7 Apr 2017 18:26:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CE8D8160B93; Fri, 7 Apr 2017 16:26:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1A94D160BA5 for ; Fri, 7 Apr 2017 18:26:42 +0200 (CEST) Received: (qmail 37959 invoked by uid 500); 7 Apr 2017 16:26:41 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 37591 invoked by uid 99); 7 Apr 2017 16:26:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 16:26:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 79FB2E962B; Fri, 7 Apr 2017 16:26:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: erans@apache.org To: commits@commons.apache.org Date: Fri, 07 Apr 2017 16:26:42 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/4] commons-rng git commit: RNG-36: Performance improvement. archived-at: Fri, 07 Apr 2017 16:26:44 -0000 RNG-36: Performance improvement. Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/e591a656 Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/e591a656 Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/e591a656 Branch: refs/heads/master Commit: e591a65643c1383fd72033df6725de3ae7e2b27c Parents: 4ef78f5 Author: Gilles Authored: Fri Apr 7 16:03:50 2017 +0200 Committer: Gilles Committed: Fri Apr 7 16:03:50 2017 +0200 ---------------------------------------------------------------------- .../sampling/distribution/MarsagliaNormalizedGaussianSampler.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-rng/blob/e591a656/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java ---------------------------------------------------------------------- diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java index 6dc9f2a..6c86452 100644 --- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java +++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java @@ -55,8 +55,7 @@ public class MarsagliaNormalizedGaussianSampler if (r2 < 1) { // Pair (x, y) is within unit circle. - final double r = Math.sqrt(r2); - final double alpha = 2 * Math.sqrt(-Math.log(r)) / r; + final double alpha = Math.sqrt(-2 * Math.log(r2) / r2); // Return the first element of the generated pair. random = alpha * x;