commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pascalschumac...@apache.org
Subject [3/3] commons-io git commit: Update checkstyle plugin version and remove no longer supported checkstyle module "RedundantThrows".
Date Sun, 23 Apr 2017 16:38:41 GMT
Update checkstyle plugin version and remove no longer supported checkstyle module "RedundantThrows".

Make checkstyle run outside of the maven site lifecyle use checkstyle.xml.

Enable checkstyle on travis-ci.


Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/872c7446
Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/872c7446
Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/872c7446

Branch: refs/heads/master
Commit: 872c744692dc2cd485e28790a1f532ca85ece2de
Parents: d357d9d
Author: pascalschumacher <pascalschumacher@gmx.net>
Authored: Sun Apr 23 18:37:24 2017 +0200
Committer: pascalschumacher <pascalschumacher@gmx.net>
Committed: Sun Apr 23 18:37:24 2017 +0200

----------------------------------------------------------------------
 .travis.yml    |  2 +-
 checkstyle.xml |  4 ----
 pom.xml        | 12 +++++++++++-
 3 files changed, 12 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-io/blob/872c7446/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index f689f55..fd1f6f5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -22,7 +22,7 @@ jdk:
   - oraclejdk8
 
 script:
-  - mvn test apache-rat:check clirr:check javadoc:javadoc
+  - mvn test apache-rat:check clirr:check checkstyle:check javadoc:javadoc
 
 after_success:
   - mvn clean cobertura:cobertura coveralls:report

http://git-wip-us.apache.org/repos/asf/commons-io/blob/872c7446/checkstyle.xml
----------------------------------------------------------------------
diff --git a/checkstyle.xml b/checkstyle.xml
index bd420dd..b06c818 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -36,10 +36,6 @@ limitations under the License.
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>
     <module name="NeedBraces"/>
-    <module name="RedundantThrows">
-      <property name="allowUnchecked" value="true"/>
-      <property name="allowSubclasses" value="true"/>
-    </module>
     <module name="LineLength">
       <property name="max" value="160"/>
     </module>

http://git-wip-us.apache.org/repos/asf/commons-io/blob/872c7446/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 5241408..6246c77 100644
--- a/pom.xml
+++ b/pom.xml
@@ -261,6 +261,7 @@ file comparators, endian transformation classes, and much more.
     <commons.scmPubCheckoutDirectory>site-content</commons.scmPubCheckoutDirectory>
     <!-- Override clirr version to be able to build the site on Java 8 -->
     <commons.clirr.version>2.8</commons.clirr.version>
+    <checkstyle.plugin.version>2.17</checkstyle.plugin.version>
   </properties>
 
   <build>
@@ -314,6 +315,15 @@ file comparators, endian transformation classes, and much more.
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>${checkstyle.plugin.version}</version>
+        <configuration>
+          <configLocation>${basedir}/checkstyle.xml</configLocation>
+          <enableRulesSummary>false</enableRulesSummary>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-scm-publish-plugin</artifactId>
         <configuration>
           <ignorePathsToDelete>
@@ -334,7 +344,7 @@ file comparators, endian transformation classes, and much more.
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.12.1</version>
+        <version>${checkstyle.plugin.version}</version>
         <configuration>
           <configLocation>${basedir}/checkstyle.xml</configLocation>
           <enableRulesSummary>false</enableRulesSummary>


Mime
View raw message