Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DABB7200C45 for ; Tue, 28 Mar 2017 16:50:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D9321160B89; Tue, 28 Mar 2017 14:50:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2EAF0160B7E for ; Tue, 28 Mar 2017 16:50:43 +0200 (CEST) Received: (qmail 40624 invoked by uid 500); 28 Mar 2017 14:50:42 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 40615 invoked by uid 99); 28 Mar 2017 14:50:42 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 14:50:42 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 9DFD63A04C1 for ; Tue, 28 Mar 2017 14:50:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1789156 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/binary/BaseNCodec.java Date: Tue, 28 Mar 2017 14:50:41 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20170328145041.9DFD63A04C1@svn01-us-west.apache.org> archived-at: Tue, 28 Mar 2017 14:50:44 -0000 Author: sebb Date: Tue Mar 28 14:50:41 2017 New Revision: 1789156 URL: http://svn.apache.org/viewvc?rev=1789156&view=rev Log: CODEC-144 BaseNCodec: encodeToString and encodeAsString methods are identical Modified: commons/proper/codec/trunk/src/changes/changes.xml commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java Modified: commons/proper/codec/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1789156&r1=1789155&r2=1789156&view=diff ============================================================================== --- commons/proper/codec/trunk/src/changes/changes.xml (original) +++ commons/proper/codec/trunk/src/changes/changes.xml Tue Mar 28 14:50:41 2017 @@ -45,6 +45,7 @@ The type attribute can be add,u + BaseNCodec: encodeToString and encodeAsString methods are identical URLCodec is neither immutable nor threadsafe StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE URLCodec.WWW_FORM_URL should be private Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java?rev=1789156&r1=1789155&r2=1789156&view=diff ============================================================================== --- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java (original) +++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java Tue Mar 28 14:50:41 2017 @@ -356,6 +356,8 @@ public abstract class BaseNCodec impleme * * @param pArray a byte array containing binary data * @return String containing only character data in the appropriate alphabet. + * @since 1.5 + * This is a duplicate of {@link #encodeToString(byte[])}; it was merged during refactoring. */ public String encodeAsString(final byte[] pArray){ return StringUtils.newStringUtf8(encode(pArray));