commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pascalschumac...@apache.org
Subject [3/6] [lang] Upgrade maven-checkstyle-plugin to 2.17
Date Sun, 12 Mar 2017 16:58:09 GMT
Upgrade maven-checkstyle-plugin to 2.17

This patch upgrades maven-checkstyle-plugin to the latest available
version, 2.17.

This is done in order to consume a fix for checkstyle wrongfully
reporting an error if the @return javadoc tag was used in an
annotation type, as it is in Guarded (line 36).

Note that checkstyle has removed the RedundantThrows check (see
discussion at https://github.com/checkstyle/checkstyle/issues/473),
so it was removed from the project's checkstyle.xml configuration.


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/c121f03d
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c121f03d
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c121f03d

Branch: refs/heads/master
Commit: c121f03d5c6dae98b0c735cec0a5126520293f08
Parents: 4259a70
Author: Allon Mureinik <amureini@redhat.com>
Authored: Sat Mar 11 10:13:44 2017 +0200
Committer: pascalschumacher <pascalschumacher@gmx.net>
Committed: Sun Mar 12 17:41:50 2017 +0100

----------------------------------------------------------------------
 checkstyle.xml | 3 ---
 pom.xml        | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/c121f03d/checkstyle.xml
----------------------------------------------------------------------
diff --git a/checkstyle.xml b/checkstyle.xml
index bbec654..6f03c44 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -36,9 +36,6 @@ limitations under the License.
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>
     <module name="NeedBraces"/>
-    <module name="RedundantThrows">
-      <property name="allowUnchecked" value="true"/>
-    </module>
     <module name="JavadocMethod">
       <property name="allowUndeclaredRTE" value="true"/>
       <property name="scope" value="public" />

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/c121f03d/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index d467ecd..c4049c9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -654,7 +654,7 @@
     <plugins>
       <plugin>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.15</version>
+        <version>2.17</version>
         <configuration>
           <configLocation>${basedir}/checkstyle.xml</configLocation>
           <enableRulesSummary>false</enableRulesSummary>


Mime
View raw message