commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pascalschumac...@apache.org
Subject [lang] Remove redundant semicolons from enums (closes #240)
Date Tue, 21 Feb 2017 18:59:09 GMT
Repository: commons-lang
Updated Branches:
  refs/heads/master a64153a37 -> a6443e146


Remove redundant semicolons from enums (closes #240)

While enums allow ending the member list in a semicolon(;), it's
redundant. Some enums in the codebase use a semicolon in the end, and
some do not.

This patch standardizes the codebase's enum and cleans up the code by
removing these semicolons.


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/a6443e14
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/a6443e14
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/a6443e14

Branch: refs/heads/master
Commit: a6443e146f825291308319c6a0f2eb82aa34f8c3
Parents: a64153a
Author: Allon Mureinik <amureini@redhat.com>
Authored: Tue Feb 21 11:18:54 2017 +0200
Committer: pascalschumacher <pascalschumacher@gmx.net>
Committed: Tue Feb 21 19:58:49 2017 +0100

----------------------------------------------------------------------
 src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java | 2 +-
 src/test/java/org/apache/commons/lang3/EnumUtilsTest.java       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/a6443e14/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java b/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java
index cd0eda2..ee4a361 100644
--- a/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/AnnotationUtilsTest.java
@@ -378,7 +378,7 @@ public class AnnotationUtilsTest {
     }
 
     public static enum Stooge {
-        MOE, LARRY, CURLY, JOE, SHEMP;
+        MOE, LARRY, CURLY, JOE, SHEMP
     }
 
     private Field field1;

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/a6443e14/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java b/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
index 757cb16..d496cbb 100644
--- a/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
@@ -418,10 +418,10 @@ enum Enum64 {
     A00, A01, A02, A03, A04, A05, A06, A07, A08, A09, A10, A11, A12, A13, A14, A15,
     A16, A17, A18, A19, A20, A21, A22, A23, A24, A25, A26, A27, A28, A29, A30, A31,
     A32, A33, A34, A35, A36, A37, A38, A39, A40, A41, A42, A43, A44, A45, A46, A47,
-    A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63;
+    A48, A49, A50, A51, A52, A53, A54, A55, A56, A57, A58, A59, A60, A61, A62, A63
 }
 enum TooMany {
     A,B,C,D,E,F,G,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Y,Z,
     A1,B1,C1,D1,E1,F1,G1,H1,I1,J1,K1,L1,M1,N1,O1,P1,Q1,R1,S1,T1,U1,V1,W1,X1,Y1,Z1,
-    A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2;
+    A2,B2,C2,D2,E2,F2,G2,H2,I2,J2,K2,L2,M2
 }


Mime
View raw message