commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject [lang] Add missing '@Override' annotations.
Date Thu, 17 Nov 2016 00:47:02 GMT
Repository: commons-lang
Updated Branches:
  refs/heads/master c9a5e54a7 -> 23c706ff9


Add missing '@Override' annotations.

Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/23c706ff
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/23c706ff
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/23c706ff

Branch: refs/heads/master
Commit: 23c706ff915c4be7d371d3098fc8de2cc3aa2b67
Parents: c9a5e54
Author: Gary Gregory <ggregory@apache.org>
Authored: Wed Nov 16 16:47:00 2016 -0800
Committer: Gary Gregory <ggregory@apache.org>
Committed: Wed Nov 16 16:47:00 2016 -0800

----------------------------------------------------------------------
 .../commons/lang3/concurrent/AbstractCircuitBreaker.java       | 6 ++++++
 src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java     | 1 +
 .../java/org/apache/commons/lang3/CharSequenceUtilsTest.java   | 1 +
 .../apache/commons/lang3/builder/JsonToStringStyleTest.java    | 1 +
 .../commons/lang3/concurrent/EventCountCircuitBreakerTest.java | 1 +
 5 files changed, 10 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/23c706ff/src/main/java/org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.java
b/src/main/java/org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.java
index bcafeb6..6eeade0 100644
--- a/src/main/java/org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.java
+++ b/src/main/java/org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.java
@@ -49,6 +49,7 @@ public abstract class AbstractCircuitBreaker<T> implements CircuitBreaker<T>
{
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isOpen() {
         return isOpen(state.get());
     }
@@ -56,6 +57,7 @@ public abstract class AbstractCircuitBreaker<T> implements CircuitBreaker<T>
{
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isClosed() {
         return !isOpen();
     }
@@ -63,16 +65,19 @@ public abstract class AbstractCircuitBreaker<T> implements CircuitBreaker<T>
{
     /**
      * {@inheritDoc}
      */
+    @Override
     public abstract boolean checkState();
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public abstract boolean incrementAndCheckState(T increment);
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public void close() {
         changeState(State.CLOSED);
     }
@@ -80,6 +85,7 @@ public abstract class AbstractCircuitBreaker<T> implements CircuitBreaker<T>
{
     /**
      * {@inheritDoc}
      */
+    @Override
     public void open() {
         changeState(State.OPEN);
     }

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/23c706ff/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index 39edfb2..de61700 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -4289,6 +4289,7 @@ public class ArrayUtilsTest  {
     @Test
     public void testIsSortedComparator() {
         final Comparator<Integer> c = new Comparator<Integer>() {
+                @Override
                 public int compare(final Integer o1, final Integer o2) {
                         return o2.compareTo(o1);
                     }

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/23c706ff/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java b/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
index 7abafea..30e992c 100644
--- a/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/CharSequenceUtilsTest.java
@@ -104,6 +104,7 @@ public class CharSequenceUtilsTest {
             this.expected = false;
             this.throwable = throwable;
         }
+        @Override
         public String toString(){
             final StringBuilder sb = new StringBuilder();
             sb.append(source).append("[").append(toffset).append("]");

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/23c706ff/src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java b/src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java
index 682a6d2..3543988 100644
--- a/src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/JsonToStringStyleTest.java
@@ -229,6 +229,7 @@ public class JsonToStringStyleTest {
     @Test
     public void testNestingPerson() {
         final Person p = new Person(){
+            @Override
             public String toString(){
                 return new ToStringBuilder(this).append("name", this.name)
                     .append("age", this.age).append("smoker", this.smoker)

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/23c706ff/src/test/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreakerTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreakerTest.java
b/src/test/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreakerTest.java
index 3c5dfe4..8e0ee2a 100644
--- a/src/test/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreakerTest.java
+++ b/src/test/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreakerTest.java
@@ -379,6 +379,7 @@ public class EventCountCircuitBreakerTest {
             changedValues = new ArrayList<>();
         }
 
+        @Override
         public void propertyChange(final PropertyChangeEvent evt) {
             assertEquals("Wrong event source", expectedSource, evt.getSource());
             assertEquals("Wrong property name", "open", evt.getPropertyName());


Mime
View raw message